Re: adding meta-intel layers breaks parsing, was Re: Updating u-boot for oe-core or meta-yocto

[Darren Hart <dvhart@linux.intel.com>]

On 05/25/2011 07:38 AM, Phil Blundell wrote:
> On Wed, 2011-05-25 at 09:28 -0500, Tom Zanussi wrote:
>> I just finished building all of the above successfully using the latest
>> (as of yesterday) poky/master and meta-intel/master.
>>
>> Not sure why you're seeing parsing errors, none here...
> 
> The way meta-intel is using FILESEXTRAPATHS does look a bit dubious to
> me.  Your kernel .bbappend files seem to be doing:
> 
> FILESEXTRAPATHS := "${FILESEXTRAPATHS}:${THISDIR}/${PN}"
> 
> which seems wrong for two reasons: firstly it will lose if
> FILESEXTRAPATHS wasn't previously set (in which case you'll get a
> circular reference within the value, since bitbake won't expand that
> part of the rvalue during the assignment);

So the reason I had made this change was to allow for multiple layers to
aggregate their bbappends. As it was previously, the meta-intel layer
prevented other layers from working by clobbering the FILESEXTRAPATHS
rather than appending to it.

> and secondly, as far as I can
> tell from looking at utils.bbclass, FILESEXTRAPATHS isn't actually
> supposed to be colon separated in the first place.

Doh. My original patch was space separated and someone suggested colons
and I didn't see a build failure in my testing so I left it. Bad testing
methodology apparently.

If it is indeed space separated then I should be able to remedy both
issues by simply using the append operator and not self-referencing.
Correct?

> 
> (Also, as a tangential matter, this FILESEXTRAPATHS setting isn't going
> to be producing any useful effect since none of the meta-intel layers
> actually have any files in their recipes-kernel/linux directory.)

We do want it in place so these can be easily added for development
purposes, even though the ultimate goal would be to include such changes
in the kernel source repository.

> 
> p.
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel