Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <pb@pbcl.net>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] libc-locale: split locale handling from libc recipe.
Date: Thu, 09 Jun 2011 12:14:04 +0100	[thread overview]
Message-ID: <1307618044.2529.4810.camel@phil-desktop> (raw)
In-Reply-To: <1307547318.15712.109.camel@rex>

On Wed, 2011-06-08 at 16:35 +0100, Richard Purdie wrote:
> I'm not sure how this would reduce performance of builds of a few
> threads, it should just make better use of any available "spare"
> processing capacity throughout the build.

If I'm reading the patch right, it does involve a certain amount of
extra copying around of the locale-related files since they need to be
stashed away in some place where libc-locale.bb can find them later.  I
don't think these files are especially big, but there are quite a few of
them (which is the whole reason that libc's do_package was slow in the
first place). 

I must admit that I'm slightly surprised that libc's packaging stage is
becoming a bottleneck for anything other than the very smallest builds.
If there's any substantial amount of other material being compiled then
I would expect that there would be enough do_compile() work to keep the
other threads busy until libc was done packaging.  That's not to say
that I think this change is a bad idea, but I would be interested to
know what the actual impact is for real-world workloads.

And, just on a point of principle, any time we're making a chance for
performance-related reasons I think we should always have measurements
to back it up. 

p.





  reply	other threads:[~2011-06-09 11:17 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-08  9:08 [PATCH 0/1][RFC] libc locale split Dongxiao Xu
2011-06-08  9:08 ` [PATCH 1/1] libc-locale: split locale handling from libc recipe Dongxiao Xu
2011-06-08  9:36   ` Phil Blundell
2011-06-08 15:35     ` Richard Purdie
2011-06-09 11:14       ` Phil Blundell [this message]
2011-06-09 11:29         ` Richard Purdie
2011-06-09 11:43           ` Phil Blundell
2011-06-09 13:15             ` Richard Purdie
2011-06-09 13:51               ` Richard Purdie
2011-06-09 13:53               ` Koen Kooi
2011-06-09 13:55                 ` Phil Blundell
  -- strict thread matches above, loose matches on Subject: below --
2011-06-22  9:01 [PATCH 0/1 v2][PULL] libc locale split Dongxiao Xu
2011-06-22  9:01 ` [PATCH 1/1] libc-locale: split locale handling from libc recipe Dongxiao Xu
2011-06-22 11:44   ` Phil Blundell
2011-06-23  4:08     ` Xu, Dongxiao
2011-06-23  9:40       ` Phil Blundell
2011-06-23 10:14         ` Richard Purdie
2011-06-23 23:42           ` Khem Raj
2011-06-27  5:49             ` Xu, Dongxiao
2011-06-22 14:44   ` Khem Raj
2011-06-22 14:47     ` Phil Blundell
2011-06-22 15:17       ` Mark Hatle
2011-06-22 15:43         ` Khem Raj
2011-06-27  8:37 [PATCH 0/1 v3][PULL] libc locale split Dongxiao Xu
2011-06-27  8:37 ` [PATCH 1/1] libc-locale: split locale handling from libc recipe Dongxiao Xu
2011-06-27  8:58   ` Phil Blundell
2011-06-28  0:51     ` Xu, Dongxiao
2011-06-28  9:07       ` Phil Blundell
2011-06-28 11:07         ` Richard Purdie
2011-06-28 12:17           ` Koen Kooi
2011-06-28 14:00             ` Richard Purdie
2011-06-28 19:37               ` Koen Kooi
2011-06-28 20:15                 ` Koen Kooi
2011-06-28  4:12     ` Xu, Dongxiao
2011-07-08 14:55   ` Phil Blundell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1307618044.2529.4810.camel@phil-desktop \
    --to=pb@pbcl.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox