From: Phil Blundell <pb@pbcl.net>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] libc-locale: split locale handling from libc recipe.
Date: Wed, 22 Jun 2011 12:44:35 +0100 [thread overview]
Message-ID: <1308743075.21613.82.camel@phil-desktop> (raw)
In-Reply-To: <d7c256ba838d05c85c6e7c2569f0a6c7b276ab17.1308732995.git.dongxiao.xu@intel.com>
I still don't quite understand why the virtual/libiconv provider has
moved from eglibc to eglibc-locale. Can you explain what's going on
there?
p.
On Wed, 2011-06-22 at 17:01 +0800, Dongxiao Xu wrote:
> *libc's do_package will cost a lot of time due to the locale handing,
> which may delay the other recipe's do_package task and affect the build
> performance.
>
> This commit moves locale handling into a separate recipe *libc-locale.
>
> Signed-off-by: Dongxiao Xu <dongxiao.xu@intel.com>
> ---
> meta/classes/libc-common.bbclass | 23 ++++++++
> meta/classes/libc-package.bbclass | 24 --------
> meta/conf/distro/include/tclibc-eglibc.inc | 2 +-
> meta/conf/distro/include/tclibc-glibc.inc | 2 +-
> meta/recipes-core/eglibc/eglibc-initial_2.13.bb | 4 ++
> meta/recipes-core/eglibc/eglibc-locale_2.13.bb | 58 ++++++++++++++++++++
> meta/recipes-core/eglibc/eglibc-package.inc | 32 +----------
> meta/recipes-core/eglibc/eglibc.inc | 4 +-
> meta/recipes-core/eglibc/eglibc_2.13.bb | 12 ++++
> meta/recipes-core/glibc/glibc-initial_2.10.1.bb | 4 ++
> meta/recipes-core/glibc/glibc-locale_2.10.1.bb | 50 +++++++++++++++++
> meta/recipes-core/glibc/glibc-package.inc | 29 ++---------
> meta/recipes-core/glibc/glibc.inc | 2 +-
> meta/recipes-core/glibc/glibc_2.10.1.bb | 12 ++++
> .../meta/external-csl-toolchain_2008q3-72.bb | 1 +
> 15 files changed, 176 insertions(+), 83 deletions(-)
> create mode 100644 meta/classes/libc-common.bbclass
> create mode 100644 meta/recipes-core/eglibc/eglibc-locale_2.13.bb
> create mode 100644 meta/recipes-core/glibc/glibc-locale_2.10.1.bb
>
> diff --git a/meta/conf/distro/include/tclibc-eglibc.inc b/meta/conf/distro/include/tclibc-eglibc.inc
> index a4c648e..90de04f 100644
> --- a/meta/conf/distro/include/tclibc-eglibc.inc
> +++ b/meta/conf/distro/include/tclibc-eglibc.inc
> @@ -10,7 +10,7 @@ TARGET_OS_powerpc = "linux${@['','-gnuspe'][bb.data.getVar('BASE_PACKAGE_ARCH',d
> # Add glibc overrides to the overrides for eglibc.
> OVERRIDES .= ":libc-glibc"
>
> -PREFERRED_PROVIDER_virtual/libiconv ?= "eglibc"
> +PREFERRED_PROVIDER_virtual/libiconv ?= "eglibc-locale"
> PREFERRED_PROVIDER_virtual/libiconv-nativesdk ?= "eglibc-nativesdk"
> PREFERRED_PROVIDER_virtual/libintl ?= "eglibc"
> PREFERRED_PROVIDER_virtual/libc ?= "eglibc"
> diff --git a/meta/conf/distro/include/tclibc-glibc.inc b/meta/conf/distro/include/tclibc-glibc.inc
> index e5843b0..748c23f 100644
> --- a/meta/conf/distro/include/tclibc-glibc.inc
> +++ b/meta/conf/distro/include/tclibc-glibc.inc
> @@ -10,7 +10,7 @@ TARGET_OS_powerpc = "linux${@['','-gnuspe'][bb.data.getVar('BASE_PACKAGE_ARCH',d
> # Add glibc to the overrides.
> OVERRIDES =. "libc-glibc:"
>
> -PREFERRED_PROVIDER_virtual/libiconv ?= "glibc"
> +PREFERRED_PROVIDER_virtual/libiconv ?= "glibc-locale"
> PREFERRED_PROVIDER_virtual/libiconv-nativesdk ?= "glibc-nativesdk"
> PREFERRED_PROVIDER_virtual/libintl ?= "glibc"
> PREFERRED_PROVIDER_virtual/libc ?= "glibc"
next prev parent reply other threads:[~2011-06-22 11:48 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-22 9:01 [PATCH 0/1 v2][PULL] libc locale split Dongxiao Xu
2011-06-22 9:01 ` [PATCH 1/1] libc-locale: split locale handling from libc recipe Dongxiao Xu
2011-06-22 11:44 ` Phil Blundell [this message]
2011-06-23 4:08 ` Xu, Dongxiao
2011-06-23 9:40 ` Phil Blundell
2011-06-23 10:14 ` Richard Purdie
2011-06-23 23:42 ` Khem Raj
2011-06-27 5:49 ` Xu, Dongxiao
2011-06-22 14:44 ` Khem Raj
2011-06-22 14:47 ` Phil Blundell
2011-06-22 15:17 ` Mark Hatle
2011-06-22 15:43 ` Khem Raj
-- strict thread matches above, loose matches on Subject: below --
2011-06-27 8:37 [PATCH 0/1 v3][PULL] libc locale split Dongxiao Xu
2011-06-27 8:37 ` [PATCH 1/1] libc-locale: split locale handling from libc recipe Dongxiao Xu
2011-06-27 8:58 ` Phil Blundell
2011-06-28 0:51 ` Xu, Dongxiao
2011-06-28 9:07 ` Phil Blundell
2011-06-28 11:07 ` Richard Purdie
2011-06-28 12:17 ` Koen Kooi
2011-06-28 14:00 ` Richard Purdie
2011-06-28 19:37 ` Koen Kooi
2011-06-28 20:15 ` Koen Kooi
2011-06-28 4:12 ` Xu, Dongxiao
2011-07-08 14:55 ` Phil Blundell
2011-06-08 9:08 [PATCH 0/1][RFC] libc locale split Dongxiao Xu
2011-06-08 9:08 ` [PATCH 1/1] libc-locale: split locale handling from libc recipe Dongxiao Xu
2011-06-08 9:36 ` Phil Blundell
2011-06-08 15:35 ` Richard Purdie
2011-06-09 11:14 ` Phil Blundell
2011-06-09 11:29 ` Richard Purdie
2011-06-09 11:43 ` Phil Blundell
2011-06-09 13:15 ` Richard Purdie
2011-06-09 13:51 ` Richard Purdie
2011-06-09 13:53 ` Koen Kooi
2011-06-09 13:55 ` Phil Blundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308743075.21613.82.camel@phil-desktop \
--to=pb@pbcl.net \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox