Re: [PATCH 0/4 V4] Share gcc work directories

From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 0/4 V4] Share gcc work directories
Date: Tue, 28 Jun 2011 15:53:03 +0100	[thread overview]
Message-ID: <1309272783.20015.313.camel@rex> (raw)
In-Reply-To: <cover.1309243115.git.liezhi.yang@windriver.com>

Hi Robert,

I just wanted to let you know that these look good, thanks.

I need to get the changes into bitbake for this first (along with the
umask and multilib changes), let that version sit for a vew days, them
bump the version requirement of OE-Core so we can then merge these
patches.

They will therefore merge and I'm happy with them but it will be a few
more days before that happens. The bitbake piece is now merged already.

Cheers,

Richard

On Tue, 2011-06-28 at 17:05 +0800, Robert Yang wrote:
> Changes of V4:
> 
> * Change the definition of GLIBC_DYNAMIC_LINKER as Richard suggested.
> 
>   e.g., the entries in the files that look like:
>   #define GLIBC_DYNAMIC_LINKER64 "/lib64/ld-linux-x86-64.so.2"
> 
>   become
> 
>   #define GLIBC_DYNAMIC_LINKER64 SYSTEMLIBS_DIR"/ld-linux-x86-64.so.2"
> 
>   and we define SYSTEMLIBS_DIR in defaults.h.
> 
>   NOTE, the round brackets:
>   #define GLIBC_DYNAMIC_LINKER64 (SYSTEMLIBS_DIR "/ld-linux-x86-64.so.2")
> 
>   doesn't work in in the following define:
> 
>   #define LINUX_DYNAMIC_LINKER \
>           CHOOSE_DYNAMIC_LINKER (GLIBC_DYNAMIC_LINKER, UCLIBC_DYNAMIC_LINKER)
> 
>   so use:
>   #define GLIBC_DYNAMIC_LINKER64 SYSTEMLIBS_DIR"/ld-linux-x86-64.so.2"
> 
> * Compare to V3, reduce two patches which are for gcc-crosssdk.inc and
>   gcc-cross-canadian which are not needed any more.
> 
> * Fix the conflicts(gcc-4.6.0 -> gcc-4.6, and the ${BRANCH})
> 
> * Both tested 4.5.1 and 4.6:
>   $ bitbake meta-toolchain core-image-sato
>   $ runqemu qemurm
> 
>   Also unpack the sdk to /opt and test to make sure the toolchain works well.
> 
> 
> The following changes since commit a1f79a7896b6411669b3ccada6204d2695e80fc5:
> 
>   runqueue.py: Add umask task control (2011-06-24 12:23:12 +0100)
> 
> are available in the git repository at:
>   git://git.pokylinux.org/poky-contrib robert/share_gcc
>   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=robert/share_gcc
> 
> Robert Yang (4):
>   bitbake: share source directory
>   Share gcc work directories
>   gcc-4.5.1: share work directories
>   gcc-4.6: share work directories
> 
>  bitbake/lib/bb/build.py                            |    4 +-
>  bitbake/lib/bb/cache.py                            |    3 +
>  bitbake/lib/bb/runqueue.py                         |   10 +++
>  meta/recipes-devtools/gcc/gcc-4.5.1.inc            |    1 +
>  .../gcc-4.5.1/use-defaults.h-and-t-oe-in-B.patch   |   57 ++++++++++++++
>  meta/recipes-devtools/gcc/gcc-4.6.inc              |    5 +-
>  .../gcc/gcc-4.6/use-defaults.h-and-t-oe-in-B.patch |   80 ++++++++++++++++++++
>  meta/recipes-devtools/gcc/gcc-common.inc           |   32 +++++++-
>  meta/recipes-devtools/gcc/gcc-configure-common.inc |   48 +++++++-----
>  meta/recipes-devtools/gcc/gcc-configure-cross.inc  |    4 +-
>  meta/recipes-devtools/gcc/gcc-crosssdk.inc         |    6 --
>  11 files changed, 218 insertions(+), 32 deletions(-)
>  create mode 100644 meta/recipes-devtools/gcc/gcc-4.5.1/use-defaults.h-and-t-oe-in-B.patch
>  create mode 100644 meta/recipes-devtools/gcc/gcc-4.6/use-defaults.h-and-t-oe-in-B.patch
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core