Re: It's broken, please revert. Re: [PATCH 0/4 V4] Share gcc work directories

From: Khem Raj <raj.khem@gmail.com>
To: openembedded-core@lists.openembedded.org
Subject: Re: It's broken, please revert. Re: [PATCH 0/4 V4] Share gcc work directories
Date: Fri, 01 Jul 2011 09:55:53 -0700	[thread overview]
Message-ID: <4E0DFC19.2040706@gmail.com> (raw)
In-Reply-To: <AB227B7A-755C-454D-A38E-7FF913801989@dominion.thruhere.net>

On 07/01/2011 07:01 AM, Koen Kooi wrote:
>
> Op 1 jul 2011, om 15:57 heeft Khem Raj het volgende geschreven:
>
>>
>>
>> On Jul 1, 2011, at 4:00 AM, Koen Kooi<koen@dominion.thruhere.net>  wrote:
>>
>>>
>>> Op 1 jul 2011, om 10:32 heeft Richard Purdie het volgende geschreven:
>>>
>>>> On Fri, 2011-07-01 at 09:15 +0200, Koen Kooi wrote:
>>>>> incremental build with rm_work turned on:
>>>>>
>>>>> ERROR: Function 'do_configure' failed (see /OE/tentacle/build/tmp-angstrom_2010_x-eglibc/work/armv7a-angstrom-linux-gnueabi/gcc-cross-initial-4.5-r37.0+svnr175127/temp/log.do_configure.27092 for further information)
>>>>> ERROR: Logfile of failure stored in: /OE/tentacle/build/tmp-angstrom_2010_x-eglibc/work/armv7a-angstrom-linux-gnueabi/gcc-cross-initial-4.5-r37.0+svnr175127/temp/log.do_configure.27092
>>>>> Log data follows:
>>>>> | + cd /OE/tentacle/build/tmp-angstrom_2010_x-eglibc/work/armv7a-angstrom-linux-gnueabi/gcc-cross-initial-4.5-r37.0+svnr175127/gcc-4.5/build.x86_64-linux.arm-angstrom-linux-gnueabi
>>>>> | + do_configure
>>>>> | + sed -i '/OE/tentacle/build/tmp-angstrom_2010_x-eglibc/work/armv7a-angstrom-linux-gnueabi/gcc-cross-initial-4.5-r37.0+svnr175127/gcc-4_5-branch/gcc/config/*/linux*.h' -e 's#\(GLIBC_DYNAMIC_LINKER[^ ]*\)\( *"/lib.*\)#\1 SYSTEMLIBS_DIR\2#'
>>>>> | sed: can't read /OE/tentacle/build/tmp-angstrom_2010_x-eglibc/work/armv7a-angstrom-linux-gnueabi/gcc-cross-initial-4.5-r37.0+svnr175127/gcc-4_5-branch/gcc/config/*/linux*.h: No such file or directory
>>>>> | ERROR: Function 'do_configure' failed (see /OE/tentacle/build/tmp-angstrom_2010_x-eglibc/work/armv7a-angstrom-linux-gnueabi/gcc-cross-initial-4.5-r37.0+svnr175127/temp/log.do_configure.27092 for further information)
>>>>> NOTE: package gcc-cross-initial-4.5-r37.0+svnr175127: task do_configure: Failed
>>>>> ERROR: Task 764 (/OE/tentacle/sources/meta-openembedded/meta-oe/recipes-devtools/gcc/gcc-cross-initial_4.5.bb, do_configure) failed with exit code '1'
>>>>>
>>>>> Can this patchset get reverted please and reapplied when it actually has been tested to work?
>>>>
>>>> I checked and everything is fine with rm_work.
>>>>
>>>> Looking at this error, something is changing ${S} as there is no mention
>>>> of work-shared in the sed command yet there should be.
>>>>
>>>> At a guess this is coming from:
>>>>
>>>> http://git.angstrom-distribution.org/cgi-bin/cgit.cgi/meta-openembedded/tree/meta-oe/recipes-devtools/gcc/gcc-4.5.inc
>>>>
>>>> where it says:
>>>>
>>>> S = "${WORKDIR}/${BRANCH}"
>>>>
>>>> and if that is changed to
>>>>
>>>> S_append = "/${BRANCH}"
>>>>
>>>> or removed it will likely work better.
>>>
>>> It was indeed a bug in meta-oe and the following fixed it:
>>>
>>> https://github.com/koenkooi/meta-oe/commit/8a917caaa5506fa0f875202243658a1c2fe60c40
>>
>> Additionally you would need to port the patch which mucks makefile fragment I think
>
> Any volunteers for that? My incremental build seems to work now, haven't tried a from scratch yet.

I had a patch for it half of which you already have. Once it builds 
through I will post.

> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core