Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Phil Blundell <philb@gnu.org>
To: "Cui, Dexuan" <dexuan.cui@intel.com>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>,
	Darren Hart <dvhart@linux.intel.com>,
	Patches, oe-core layer <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] oe-init-build-env, scripts/oe-buildenv-internal: add error detecting for $BDIR
Date: Thu, 04 Aug 2011 15:53:41 +0100	[thread overview]
Message-ID: <1312469622.5417.1.camel@phil-desktop> (raw)
In-Reply-To: <1865303E0DED764181A9D882DEF65FB6B3046C9C11@shsmsx502.ccr.corp.intel.com>

On Thu, 2011-08-04 at 22:49 +0800, Cui, Dexuan wrote:
> +        BDIR=`readlink -f "$BDIR"`
> +        if [ -z "$BDIR" ]; then
> +            PARENTDIR=`dirname "$1"`
> +            echo >&2 "Error: the directory $PARENTDIR does not exist?"
>              return 1
>          fi
>      fi

Just out of curiosity, could you not just do "mkdir -p $BDIR" and avoid
this whole set of complicated tests?  Or is there some reason why it's
actually important to know whether the parent directory existed already?

p.





  reply	other threads:[~2011-08-04 14:58 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-02  6:08 [PATCH 0/1] fix to bug 671 Dexuan Cui
2011-08-02  6:08 ` [PATCH 1/1] oe-init-build-env, scripts/oe-buildenv-internal: add error detecting for $BDIR Dexuan Cui
2011-08-02 11:43   ` Richard Purdie
2011-08-03  4:06     ` Darren Hart
2011-08-03  6:46       ` Cui, Dexuan
2011-08-03 13:50         ` Darren Hart
2011-08-03 14:01           ` Paul Eggleton
2011-08-03 14:11             ` Phil Blundell
2011-08-03 14:21               ` Paul Eggleton
2011-08-03 14:25                 ` Phil Blundell
2011-08-04  2:25           ` Cui, Dexuan
2011-08-04  6:00             ` Darren Hart
2011-08-04  7:37               ` Cui, Dexuan
2011-08-04 13:44                 ` Darren Hart
2011-08-04 14:49                   ` Cui, Dexuan
2011-08-04 14:53                     ` Phil Blundell [this message]
2011-08-04 15:14                       ` Cui, Dexuan
2011-08-09  2:13                     ` Cui, Dexuan
2011-08-09  4:35                       ` Darren Hart
2011-08-09 14:04                         ` Cui, Dexuan
2011-08-09 15:06                           ` Darren Hart
2011-08-10  3:18                             ` Cui, Dexuan
2011-08-10 12:21                               ` Richard Purdie
2011-08-10 13:04                               ` Richard Purdie
2011-08-04 12:07       ` Richard Purdie
2011-08-04 13:37         ` Darren Hart
2011-08-04 14:19           ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1312469622.5417.1.camel@phil-desktop \
    --to=philb@gnu.org \
    --cc=dexuan.cui@intel.com \
    --cc=dvhart@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=paul.eggleton@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox