From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: openembedded-core@lists.openembedded.org
Cc: Darren Hart <dvhart@linux.intel.com>
Subject: Re: [PATCH 1/1] oe-init-build-env, scripts/oe-buildenv-internal: add error detecting for $BDIR
Date: Wed, 3 Aug 2011 15:01:58 +0100 [thread overview]
Message-ID: <201108031501.58796.paul.eggleton@linux.intel.com> (raw)
In-Reply-To: <4E395235.9010709@linux.intel.com>
On Wednesday 03 August 2011 14:50:45 Darren Hart wrote:
> if [ "$BDIR" == "/" ]; then
> echo "ERROR: / is not supported as a build directory."
> exit 1
> fi
> BDIR=${BDIR%/}
Works fine here - the only thing I'd suggest is use "=" instead of "==" as I
think "==" is a bashism (at least dash doesn't like it - not that we support
dash but we at least want the user to get past the setup script so they can
get a proper error from sanity.bbclass).
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2011-08-03 14:06 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 6:08 [PATCH 0/1] fix to bug 671 Dexuan Cui
2011-08-02 6:08 ` [PATCH 1/1] oe-init-build-env, scripts/oe-buildenv-internal: add error detecting for $BDIR Dexuan Cui
2011-08-02 11:43 ` Richard Purdie
2011-08-03 4:06 ` Darren Hart
2011-08-03 6:46 ` Cui, Dexuan
2011-08-03 13:50 ` Darren Hart
2011-08-03 14:01 ` Paul Eggleton [this message]
2011-08-03 14:11 ` Phil Blundell
2011-08-03 14:21 ` Paul Eggleton
2011-08-03 14:25 ` Phil Blundell
2011-08-04 2:25 ` Cui, Dexuan
2011-08-04 6:00 ` Darren Hart
2011-08-04 7:37 ` Cui, Dexuan
2011-08-04 13:44 ` Darren Hart
2011-08-04 14:49 ` Cui, Dexuan
2011-08-04 14:53 ` Phil Blundell
2011-08-04 15:14 ` Cui, Dexuan
2011-08-09 2:13 ` Cui, Dexuan
2011-08-09 4:35 ` Darren Hart
2011-08-09 14:04 ` Cui, Dexuan
2011-08-09 15:06 ` Darren Hart
2011-08-10 3:18 ` Cui, Dexuan
2011-08-10 12:21 ` Richard Purdie
2011-08-10 13:04 ` Richard Purdie
2011-08-04 12:07 ` Richard Purdie
2011-08-04 13:37 ` Darren Hart
2011-08-04 14:19 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201108031501.58796.paul.eggleton@linux.intel.com \
--to=paul.eggleton@linux.intel.com \
--cc=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox