From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: "Cui, Dexuan" <dexuan.cui@intel.com>
Cc: Phil Blundell <philb@gnu.org>,
Paul Eggleton <paul.eggleton@linux.intel.com>,
Darren Hart <dvhart@linux.intel.com>,
Patches, oe-core layer <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] oe-init-build-env, scripts/oe-buildenv-internal: add error detecting for $BDIR
Date: Wed, 10 Aug 2011 14:04:38 +0100 [thread overview]
Message-ID: <1312981478.14274.374.camel@rex> (raw)
In-Reply-To: <1865303E0DED764181A9D882DEF65FB6B6CD83BDA9@shsmsx502.ccr.corp.intel.com>
On Wed, 2011-08-10 at 11:18 +0800, Cui, Dexuan wrote:
> Darren Hart wrote on 2011-08-09:
> > On 08/09/2011 07:04 AM, Cui, Dexuan wrote:
> >> Hi Darren, thanks a lot for all the suggestions! I appreciate your
> >> efforts to help to make the patch better. Below is the updated patch
> >> (also pasted at the end of the mail):
> >> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dcu i/
> >> bug-671&id=2ece3a84d646bb4bf83f3c8aa3067cb99989da47
> >>
> >> -- Dexuan
> >>
> >> commit 2ece3a84d646bb4bf83f3c8aa3067cb99989da47
> >> Author: Dexuan Cui <dexuan.cui@intel.com>
> >> Date: Thu Aug 4 14:53:20 2011 +0800
> >>
> >> scripts/oe-buildenv-internal: improve the error detecting for
> >> $BDIR
> >>
> >> The previous fix for a bug in Ubuntu 10.04 readlink,
> >> be2a2764d8ceb398d81714661e6f199c8b11946c, notified the user when a
> >> trailing slash was used. As there is no semantic difference, simply
> >> remove any trailing slashes and proceed without nagging the user.
> >>
> >> See [YOCTO #671] for more details.
> >>
> >> Signed-off-by: Dexuan Cui <dexuan.cui@intel.com>
> >> Cc: Darren Hart <dvhart@linux.intel.com>
> >> Cc: Paul Eggleton <paul.eggleton@linux.intel.com>
> >
> > Looks good,
> >
> > Acked-by: Darren Hart <dvhart@linux.intel.com>
> Thanks, Darren!
>
> Hi RP, could you please pull the patch?
> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=dcui/bug-671&id=2ece3a84d646bb4bf83f3c8aa3067cb99989da47
Merged to master, thanks.
Richard
next prev parent reply other threads:[~2011-08-10 13:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-02 6:08 [PATCH 0/1] fix to bug 671 Dexuan Cui
2011-08-02 6:08 ` [PATCH 1/1] oe-init-build-env, scripts/oe-buildenv-internal: add error detecting for $BDIR Dexuan Cui
2011-08-02 11:43 ` Richard Purdie
2011-08-03 4:06 ` Darren Hart
2011-08-03 6:46 ` Cui, Dexuan
2011-08-03 13:50 ` Darren Hart
2011-08-03 14:01 ` Paul Eggleton
2011-08-03 14:11 ` Phil Blundell
2011-08-03 14:21 ` Paul Eggleton
2011-08-03 14:25 ` Phil Blundell
2011-08-04 2:25 ` Cui, Dexuan
2011-08-04 6:00 ` Darren Hart
2011-08-04 7:37 ` Cui, Dexuan
2011-08-04 13:44 ` Darren Hart
2011-08-04 14:49 ` Cui, Dexuan
2011-08-04 14:53 ` Phil Blundell
2011-08-04 15:14 ` Cui, Dexuan
2011-08-09 2:13 ` Cui, Dexuan
2011-08-09 4:35 ` Darren Hart
2011-08-09 14:04 ` Cui, Dexuan
2011-08-09 15:06 ` Darren Hart
2011-08-10 3:18 ` Cui, Dexuan
2011-08-10 12:21 ` Richard Purdie
2011-08-10 13:04 ` Richard Purdie [this message]
2011-08-04 12:07 ` Richard Purdie
2011-08-04 13:37 ` Darren Hart
2011-08-04 14:19 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1312981478.14274.374.camel@rex \
--to=richard.purdie@linuxfoundation.org \
--cc=dexuan.cui@intel.com \
--cc=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
--cc=philb@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox