Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
To: openembedded-core@lists.openembedded.org
Cc: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Subject: [PATCH 17/17] package.bbclass: make unshipped files a fatal error
Date: Wed, 21 Sep 2011 22:40:04 +0400	[thread overview]
Message-ID: <1316630404-10336-17-git-send-email-dbaryshkov@gmail.com> (raw)
In-Reply-To: <1316630404-10336-1-git-send-email-dbaryshkov@gmail.com>

I belive that "files were installed but not shipped in any package"
message should become a fatal error. While it's true that sometimes some
files are generated by do_install task, which aren't necessary for our
target systems. However in generic I think this is a very important and
usually overlooked QA sign. E.g. recently I've found/fixed some bugs in
eglibc packaging only due to making this a fatal error. Sometimes new
versions of a software add new files, but then they are sometimes
ignored, as this messages can be easily missed. You can come with more
examples if you'd like to.

Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
---
 meta/classes/package.bbclass |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index a9c510d..f4a535e 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -948,6 +948,7 @@ python populate_packages () {
 		bb.warn("For recipe %s, the following files were installed but not shipped in any package:" % pn)
 		for f in unshipped:
 			bb.warn("  " + f)
+		bb.fatal("Unshipped files found")
 
 	bb.build.exec_func("package_name_hook", d)
 
-- 
1.7.2.5




  parent reply	other threads:[~2011-09-21 18:46 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-21 18:39 [PATCH 01/17] icecc-create-env: rename to -native Dmitry Eremin-Solenikov
2011-09-21 18:39 ` [PATCH 02/17] icecc.bbclass: fix handling of nativesdk and cross-canadian packages Dmitry Eremin-Solenikov
2011-09-21 18:39 ` [PATCH 03/17] insane.bbclass: don't warn on .so files in -nativesdk packages Dmitry Eremin-Solenikov
2011-09-21 18:39 ` [PATCH 04/17] avahi: include dbus interfaces definitions into daemon package Dmitry Eremin-Solenikov
2011-09-21 18:39 ` [PATCH 05/17] gst-plugins-base: add support for non-X11-enabled distros Dmitry Eremin-Solenikov
2011-09-21 19:19   ` Koen Kooi
2011-09-21 18:39 ` [PATCH 06/17] libgpg-error: drop common-lisp files Dmitry Eremin-Solenikov
2011-09-21 18:39 ` [PATCH 07/17] gtk+: packaging fixups Dmitry Eremin-Solenikov
2011-09-21 18:39 ` [PATCH 08/17] polkit: fixup packaging Dmitry Eremin-Solenikov
2011-09-21 18:39 ` [PATCH 09/17] dbus-glib: disable bash-completion Dmitry Eremin-Solenikov
2011-09-21 19:19   ` Koen Kooi
2011-09-21 19:57     ` Dmitry Eremin-Solenikov
2011-09-21 20:00       ` Koen Kooi
2011-09-21 18:39 ` [PATCH 10/17] gettext: shut up unshipped files warning Dmitry Eremin-Solenikov
2011-09-21 18:39 ` [PATCH 11/17] eglibc: fix packaging of some of nativesdk packages Dmitry Eremin-Solenikov
2011-09-21 18:39 ` [PATCH 12/17] glib-2.0: include glib-gettextize stuff Dmitry Eremin-Solenikov
2011-09-21 18:40 ` [PATCH 13/17] libxml2: reinclude a -staticdev package Dmitry Eremin-Solenikov
2011-09-21 18:40 ` [PATCH 14/17] e2fsprogs: include devtools scripts Dmitry Eremin-Solenikov
2011-09-21 18:40 ` [PATCH 15/17] gcc: include plugin-related headers into packaged SDK Dmitry Eremin-Solenikov
2011-09-21 18:40 ` [PATCH 16/17] gcc: fix possible problems with nscd compilation during eglibc-nativesdk build Dmitry Eremin-Solenikov
2011-09-22  5:44   ` [PATCH 16s, Richard17] " Richard Purdie
2011-09-21 18:40 ` Dmitry Eremin-Solenikov [this message]
2011-09-22  5:48   ` [PATCH 17/17] package.bbclass: make unshipped files a fatal error Richard Purdie
2011-09-22  6:36     ` Dmitry Eremin-Solenikov
2011-09-22  9:45       ` Paul Eggleton
2011-09-22  9:50         ` Dmitry Eremin-Solenikov
2011-09-22  6:06 ` [PATCH 01/17] icecc-create-env: rename to -native Richard Purdie
2011-09-22  6:47   ` Dmitry Eremin-Solenikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316630404-10336-17-git-send-email-dbaryshkov@gmail.com \
    --to=dbaryshkov@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox