Re: [PATCH 17/17] package.bbclass: make unshipped files a fatal error

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Wed, 2011-09-21 at 22:40 +0400, Dmitry Eremin-Solenikov wrote:
> I belive that "files were installed but not shipped in any package"
> message should become a fatal error. While it's true that sometimes some
> files are generated by do_install task, which aren't necessary for our
> target systems. However in generic I think this is a very important and
> usually overlooked QA sign. E.g. recently I've found/fixed some bugs in
> eglibc packaging only due to making this a fatal error. Sometimes new
> versions of a software add new files, but then they are sometimes
> ignored, as this messages can be easily missed. You can come with more
> examples if you'd like to.
> 
> Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
> ---
>  meta/classes/package.bbclass |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index a9c510d..f4a535e 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -948,6 +948,7 @@ python populate_packages () {
>  		bb.warn("For recipe %s, the following files were installed but not shipped in any package:" % pn)
>  		for f in unshipped:
>  			bb.warn("  " + f)
> +		bb.fatal("Unshipped files found")
>  
>  	bb.build.exec_func("package_name_hook", d)

One of thee post-release things I want to sort out is the QA warnings
and I add this warning under that category. We introduced the ideas of
warnings to error and warn on into the QA class already and I'd like to
be able to control this warning in that way using the same variables.

Also, rather than being bb.fatal, this should be bb.error. An Error
message will allow the build to complete but will set the bitbake exit
code to show when errors have occurred. This means errors still light
the autobuilder up red when they occur so we're usually pretty good
about noticing and removing error messages.

Cheers,

Richard