[RFC] bitbake.conf: include only ${libdir}/${BPN}/*${SOLIBS} not whole ${libdir}/${BPN}/* in FILES_${PN}-dev

[RFC] bitbake.conf: include only ${libdir}/${BPN}/*${SOLIBS} not whole ${libdir}/${BPN}/* in FILES_${PN}-dev

[Martin Jansa]

* ie syslog-ng has a lot of .so and .la files in ${libdir}/${BPN}/ and
  fails with this QA check:
| ERROR: QA Issue: non -dev/-dbg/-nativesdk package contains symlink .so: syslog-ng path
'/work/i586-oe-linux/syslog-ng-3.2.2-r6.1/packages-split/syslog-ng/usr/lib/syslog-ng/libafsocket.so'
* I haven't tried to rebuild from scratch to check if this changes is
  creating more QA issues about unpackaged files then what is trying to
  fix (ie in syslog-ng), that's why it's RFC

Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
---
 meta/conf/bitbake.conf |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index e2c1b6f..772c09e 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -262,7 +262,7 @@ FILES_${PN} = "${bindir}/* ${sbindir}/* ${libexecdir}/* ${libdir}/lib*${SOLIBS}
             ${sysconfdir} ${sharedstatedir} ${localstatedir} \
             ${base_bindir}/* ${base_sbindir}/* \
             ${base_libdir}/*${SOLIBS} \
-            ${datadir}/${BPN} ${libdir}/${BPN}/* \
+            ${datadir}/${BPN} ${libdir}/${BPN}/*${SOLIBS} \
             ${datadir}/pixmaps ${datadir}/applications \
             ${datadir}/idl ${datadir}/omf ${datadir}/sounds \
             ${libdir}/bonobo/servers"
@@ -271,7 +271,7 @@ FILES_${PN}-doc = "${docdir} ${mandir} ${infodir} ${datadir}/gtk-doc \
             ${datadir}/gnome/help"
 SECTION_${PN}-doc = "doc"
 
-FILES_${PN}-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la \
+FILES_${PN}-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/${BPN}/*${SOLIBSDEV} ${libdir}/*.la \
                 ${libdir}/*.o ${libdir}/pkgconfig ${datadir}/pkgconfig \
                 ${datadir}/aclocal ${base_libdir}/*.o"
 SECTION_${PN}-dev = "devel"
-- 
1.7.7

Re: [RFC] bitbake.conf: include only ${libdir}/${BPN}/*${SOLIBS} not whole ${libdir}/${BPN}/* in FILES_${PN}-dev

[Otavio Salvador]

On Mon, Oct 17, 2011 at 10:52, Martin Jansa <martin.jansa@gmail.com> wrote:
> * ie syslog-ng has a lot of .so and .la files in ${libdir}/${BPN}/ and
>  fails with this QA check:
> | ERROR: QA Issue: non -dev/-dbg/-nativesdk package contains symlink .so: syslog-ng path
> '/work/i586-oe-linux/syslog-ng-3.2.2-r6.1/packages-split/syslog-ng/usr/lib/syslog-ng/libafsocket.so'
> * I haven't tried to rebuild from scratch to check if this changes is
>  creating more QA issues about unpackaged files then what is trying to
>  fix (ie in syslog-ng), that's why it's RFC
...

Even it raising new warinings it seems the way to go.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio@ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Re: [RFC] bitbake.conf: include only ${libdir}/${BPN}/*${SOLIBS} not whole ${libdir}/${BPN}/* in FILES_${PN}-dev

[Phil Blundell]

On Mon, 2011-10-17 at 14:52 +0200, Martin Jansa wrote:
> * ie syslog-ng has a lot of .so and .la files in ${libdir}/${BPN}/ and
>   fails with this QA check:
> | ERROR: QA Issue: non -dev/-dbg/-nativesdk package contains symlink .so: syslog-ng path
> '/work/i586-oe-linux/syslog-ng-3.2.2-r6.1/packages-split/syslog-ng/usr/lib/syslog-ng/libafsocket.so'
> * I haven't tried to rebuild from scratch to check if this changes is
>   creating more QA issues about unpackaged files then what is trying to
>   fix (ie in syslog-ng), that's why it's RFC
> 
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>

The subject line of this patch doesn't seem to match what it's actually
doing.  

If there are .la or .so files in ${libdir}/${PN} that are causing a
problem then it does seem reasonable to add them to FILES_${PN}-dev.
But I don't think that restricting the scope of FILES_${PN} is
desirable, or ought to be necessary.

p.

> ---
>  meta/conf/bitbake.conf |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index e2c1b6f..772c09e 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -262,7 +262,7 @@ FILES_${PN} = "${bindir}/* ${sbindir}/* ${libexecdir}/* ${libdir}/lib*${SOLIBS}
>              ${sysconfdir} ${sharedstatedir} ${localstatedir} \
>              ${base_bindir}/* ${base_sbindir}/* \
>              ${base_libdir}/*${SOLIBS} \
> -            ${datadir}/${BPN} ${libdir}/${BPN}/* \
> +            ${datadir}/${BPN} ${libdir}/${BPN}/*${SOLIBS} \
>              ${datadir}/pixmaps ${datadir}/applications \
>              ${datadir}/idl ${datadir}/omf ${datadir}/sounds \
>              ${libdir}/bonobo/servers"
> @@ -271,7 +271,7 @@ FILES_${PN}-doc = "${docdir} ${mandir} ${infodir} ${datadir}/gtk-doc \
>              ${datadir}/gnome/help"
>  SECTION_${PN}-doc = "doc"
>  
> -FILES_${PN}-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la \
> +FILES_${PN}-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/${BPN}/*${SOLIBSDEV} ${libdir}/*.la \
>                  ${libdir}/*.o ${libdir}/pkgconfig ${datadir}/pkgconfig \
>                  ${datadir}/aclocal ${base_libdir}/*.o"
>  SECTION_${PN}-dev = "devel"

Re: [RFC] bitbake.conf: include only ${libdir}/${BPN}/*${SOLIBS} not whole ${libdir}/${BPN}/* in FILES_${PN}-dev

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2977 bytes --]

On Mon, Oct 17, 2011 at 02:48:29PM +0100, Phil Blundell wrote:
> On Mon, 2011-10-17 at 14:52 +0200, Martin Jansa wrote:
> > * ie syslog-ng has a lot of .so and .la files in ${libdir}/${BPN}/ and
> >   fails with this QA check:
> > | ERROR: QA Issue: non -dev/-dbg/-nativesdk package contains symlink .so: syslog-ng path
> > '/work/i586-oe-linux/syslog-ng-3.2.2-r6.1/packages-split/syslog-ng/usr/lib/syslog-ng/libafsocket.so'
> > * I haven't tried to rebuild from scratch to check if this changes is
> >   creating more QA issues about unpackaged files then what is trying to
> >   fix (ie in syslog-ng), that's why it's RFC
> > 
> > Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> 
> The subject line of this patch doesn't seem to match what it's actually
> doing.  

Ah, sorry you're right it should be without '-dev' suffix in subject

> If there are .la or .so files in ${libdir}/${PN} that are causing a
> problem then it does seem reasonable to add them to FILES_${PN}-dev.
> But I don't think that restricting the scope of FILES_${PN} is
> desirable, or ought to be necessary.

How to do this with this order of PACKAGES, without redefining PACKAGES
itself?

PACKAGES = "${PN}-dbg ${PN} ${PN}-doc ${PN}-dev ${PN}-staticdev ${PN}-locale"

Regards,

> p.
> 
> > ---
> >  meta/conf/bitbake.conf |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index e2c1b6f..772c09e 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -262,7 +262,7 @@ FILES_${PN} = "${bindir}/* ${sbindir}/* ${libexecdir}/* ${libdir}/lib*${SOLIBS}
> >              ${sysconfdir} ${sharedstatedir} ${localstatedir} \
> >              ${base_bindir}/* ${base_sbindir}/* \
> >              ${base_libdir}/*${SOLIBS} \
> > -            ${datadir}/${BPN} ${libdir}/${BPN}/* \
> > +            ${datadir}/${BPN} ${libdir}/${BPN}/*${SOLIBS} \
> >              ${datadir}/pixmaps ${datadir}/applications \
> >              ${datadir}/idl ${datadir}/omf ${datadir}/sounds \
> >              ${libdir}/bonobo/servers"
> > @@ -271,7 +271,7 @@ FILES_${PN}-doc = "${docdir} ${mandir} ${infodir} ${datadir}/gtk-doc \
> >              ${datadir}/gnome/help"
> >  SECTION_${PN}-doc = "doc"
> >  
> > -FILES_${PN}-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/*.la \
> > +FILES_${PN}-dev = "${includedir} ${libdir}/lib*${SOLIBSDEV} ${libdir}/${BPN}/*${SOLIBSDEV} ${libdir}/*.la \
> >                  ${libdir}/*.o ${libdir}/pkgconfig ${datadir}/pkgconfig \
> >                  ${datadir}/aclocal ${base_libdir}/*.o"
> >  SECTION_${PN}-dev = "devel"
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [RFC] bitbake.conf: include only ${libdir}/${BPN}/*${SOLIBS} not whole ${libdir}/${BPN}/* in FILES_${PN}-dev

[Phil Blundell]

On Mon, 2011-10-17 at 15:59 +0200, Martin Jansa wrote:
> On Mon, Oct 17, 2011 at 02:48:29PM +0100, Phil Blundell wrote:
> > If there are .la or .so files in ${libdir}/${PN} that are causing a
> > problem then it does seem reasonable to add them to FILES_${PN}-dev.
> > But I don't think that restricting the scope of FILES_${PN} is
> > desirable, or ought to be necessary.
> 
> How to do this with this order of PACKAGES, without redefining PACKAGES
> itself?
> 
> PACKAGES = "${PN}-dbg ${PN} ${PN}-doc ${PN}-dev ${PN}-staticdev ${PN}-locale"

Ah, hm.  I had thought for some reason that ${PN}-dev was before ${PN}
but evidently that's not correct.  So you're right, there is probably no
good way to do it without fiddling FILES_${PN}.  

That being the case, I am inclined to say that this ought just to be
fixed locally in the recipes that have the problem: it isn't very
obvious to me that setting a restrictive glob on FILES_${PN} (and then
having to edit all the recipes that install non-library things in there)
is going to be a net win compared to just fixing the recipes that are
currently shipping .la files in there by mistake.

Or, maybe another solution would be to invent some sort of mechanism
like...

EXCLUDEFILES_${PN} = "*.la"

and get package.bbclass to skip anything matching that glob.

p.

Re: [RFC] bitbake.conf: include only ${libdir}/${BPN}/*${SOLIBS} not whole ${libdir}/${BPN}/* in FILES_${PN}-dev

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 2178 bytes --]

On Mon, Oct 17, 2011 at 03:06:24PM +0100, Phil Blundell wrote:
> On Mon, 2011-10-17 at 15:59 +0200, Martin Jansa wrote:
> > On Mon, Oct 17, 2011 at 02:48:29PM +0100, Phil Blundell wrote:
> > > If there are .la or .so files in ${libdir}/${PN} that are causing a
> > > problem then it does seem reasonable to add them to FILES_${PN}-dev.
> > > But I don't think that restricting the scope of FILES_${PN} is
> > > desirable, or ought to be necessary.
> > 
> > How to do this with this order of PACKAGES, without redefining PACKAGES
> > itself?
> > 
> > PACKAGES = "${PN}-dbg ${PN} ${PN}-doc ${PN}-dev ${PN}-staticdev ${PN}-locale"
> 
> Ah, hm.  I had thought for some reason that ${PN}-dev was before ${PN}
> but evidently that's not correct.  So you're right, there is probably no
> good way to do it without fiddling FILES_${PN}.  
> 
> That being the case, I am inclined to say that this ought just to be
> fixed locally in the recipes that have the problem: it isn't very
> obvious to me that setting a restrictive glob on FILES_${PN} (and then
> having to edit all the recipes that install non-library things in there)
> is going to be a net win compared to just fixing the recipes that are
> currently shipping .la files in there by mistake.

OK, I didn't any research to find what type of files are usually stored
in ${libdir}/${BPN} but find /usr/lib64 on my gentoo box suggests that
you're right (almost every directory under /usr/lib64 has something more
than .so and .la files:

# find /usr/lib64/ -mindepth 1 -maxdepth 1 -type d | wc -l 
186
# for i in `find /usr/lib64/ -mindepth 1 -maxdepth 1 -type d`; do ls -1 $i/* 2>/dev/null | grep -v ".so" | wc -l | grep -v '^0$'; done | wc -l
136
# for i in `find /usr/lib64/ -mindepth 1 -maxdepth 1 -type d`; do ls -1 $i/* 2>/dev/null | grep -v ".so" | grep -v ".la" | wc -l | grep -v '^0$'; done | wc -l
128

I've fixed it in syslog-ng by redifining FILES_${PN} in
http://git.openembedded.org/meta-openembedded/commit/?id=1ab4e30380da2444cfc66fe5283beb83168964a7

and we can ignore this conf/bitbake.conf patch.

Thanks

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]