[PATCH] useradd.bbclass: do not let depend native packages on base-passwd from target

[PATCH] useradd.bbclass: do not let depend native packages on base-passwd from target

[Henning Heinold]

Hi,

with the setup now in useradd.bbclass, at least dbus-native depends
on the base-passwd from target. I think this is not wanted.
My patch resets the DEPENDS line for native packages similar to
nativesdk.

Henning Heinold (1):
  useradd.bbclass: do not let depend native packages on base-passwd
    from target

 meta/classes/useradd.bbclass |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

-- 
1.7.7.3

[PATCH] useradd.bbclass: do not let depend native packages on base-passwd from target

[Henning Heinold]

Signed-off-by: Henning Heinold <heinold@inf.fu-berlin.de>
---
 meta/classes/useradd.bbclass |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
index 928f619..245588b 100644
--- a/meta/classes/useradd.bbclass
+++ b/meta/classes/useradd.bbclass
@@ -3,6 +3,7 @@
 # and support files needed to add and modify user and group accounts
 DEPENDS_append = "${USERADDDEPENDS}"
 USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot shadow"
+USERADDDEPENDS_virtclass-native = ""
 USERADDDEPENDS_virtclass-nativesdk = ""
 
 # This preinstall function will be run in two contexts: once for the
-- 
1.7.7.3

Re: [PATCH] useradd.bbclass: do not let depend native packages on base-passwd from target

[Richard Purdie]

On Thu, 2011-11-17 at 10:48 +0100, Henning Heinold wrote:
> Signed-off-by: Henning Heinold <heinold@inf.fu-berlin.de>
> ---
>  meta/classes/useradd.bbclass |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/classes/useradd.bbclass b/meta/classes/useradd.bbclass
> index 928f619..245588b 100644
> --- a/meta/classes/useradd.bbclass
> +++ b/meta/classes/useradd.bbclass
> @@ -3,6 +3,7 @@
>  # and support files needed to add and modify user and group accounts
>  DEPENDS_append = "${USERADDDEPENDS}"
>  USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot shadow"
> +USERADDDEPENDS_virtclass-native = ""
>  USERADDDEPENDS_virtclass-nativesdk = ""
>  
>  # This preinstall function will be run in two contexts: once for the


Do we also need to do this for:

SYSROOTFUNC = "useradd_sysroot"
SYSROOTFUNC_virtclass-nativesdk = ""

and

SYSROOTPOSTFUNC = "useradd_sysroot_sstate"
SYSROOTPOSTFUNC_virtclass-nativesdk = ""

?

Cheers,

Richard

Re: [PATCH] useradd.bbclass: do not let depend native packages on base-passwd from target

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 425 bytes --]

Dear Henning,


Am Donnerstag, den 17.11.2011, 10:48 +0100 schrieb Henning Heinold:

> with the setup now in useradd.bbclass, at least dbus-native depends
> on the base-passwd from target. I think this is not wanted.
> My patch resets the DEPENDS line for native packages similar to
> nativesdk.

why do not you use that as the commit message? That would be very
helpful for me at least. ;-)


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] useradd.bbclass: do not let depend native packages on base-passwd from target

[Henning Heinold]

On Thu, Nov 17, 2011 at 05:26:33PM +0100, Paul Menzel wrote:
> Dear Henning,
> 
> 
> Am Donnerstag, den 17.11.2011, 10:48 +0100 schrieb Henning Heinold:
> 
> > with the setup now in useradd.bbclass, at least dbus-native depends
> > on the base-passwd from target. I think this is not wanted.
> > My patch resets the DEPENDS line for native packages similar to
> > nativesdk.
> 
> why do not you use that as the commit message? That would be very
> helpful for me at least. ;-)

Becaus it is not rocket science.
 
> 
> Thanks,
> 
> Paul

Bye Henning

Re: [PATCH] useradd.bbclass: do not let depend native packages on base-passwd from target

[Chris Larson]

On Thu, Nov 17, 2011 at 9:26 AM, Paul Menzel
<paulepanter@users.sourceforge.net> wrote:
> Am Donnerstag, den 17.11.2011, 10:48 +0100 schrieb Henning Heinold:
>
>> with the setup now in useradd.bbclass, at least dbus-native depends
>> on the base-passwd from target. I think this is not wanted.
>> My patch resets the DEPENDS line for native packages similar to
>> nativesdk.
>
> why do not you use that as the commit message? That would be very
> helpful for me at least. ;-)


The summary often describes the what, the detailed description the
how. The summary here is accurate, particularly regarding the
behavioral change, rather than the implementation details.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

Re: [PATCH] useradd.bbclass: do not let depend native packages on base-passwd from target

[Paul Menzel]

[-- Attachment #1: Type: text/plain, Size: 1014 bytes --]

Am Donnerstag, den 17.11.2011, 14:37 -0700 schrieb Chris Larson:
> On Thu, Nov 17, 2011 at 9:26 AM, Paul Menzel wrote:
> > Am Donnerstag, den 17.11.2011, 10:48 +0100 schrieb Henning Heinold:
> >
> >> with the setup now in useradd.bbclass, at least dbus-native depends
> >> on the base-passwd from target. I think this is not wanted.
> >> My patch resets the DEPENDS line for native packages similar to
> >> nativesdk.
> >
> > why do not you use that as the commit message? That would be very
> > helpful for me at least. ;-)
> 
> The summary often describes the what, the detailed description the
> how. The summary here is accurate, particularly regarding the
> behavioral change, rather than the implementation details.

I did refer to that. Looking at the patch’s commit message you will see
it is empty. So just sending the patch with no patch introduction and
putting the message from the patch introduction into the patch’s commit
message would benefit everyone.


Thanks,

Paul

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 205 bytes --]

Re: [PATCH] useradd.bbclass: do not let depend native packages on base-passwd from target

[Saul Wold]

On 11/17/2011 01:48 AM, Henning Heinold wrote:
> Hi,
>
> with the setup now in useradd.bbclass, at least dbus-native depends
> on the base-passwd from target. I think this is not wanted.
> My patch resets the DEPENDS line for native packages similar to
> nativesdk.
>
> Henning Heinold (1):
>    useradd.bbclass: do not let depend native packages on base-passwd
>      from target
>
>   meta/classes/useradd.bbclass |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>

This was merged into OE-Core by Richard doing it with an updated commit 
message and adding the SYSROOTFUNC changes he suggested in the thread.

Thanks
	Sau!