* should recipes be distro agnostic?
@ 2012-01-26 6:52 Frans Meulenbroeks
2012-01-26 11:31 ` Paul Eggleton
0 siblings, 1 reply; 3+ messages in thread
From: Frans Meulenbroeks @ 2012-01-26 6:52 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 2360 bytes --]
By coincidence I bumped into this in oe-core:
./meta/recipes-devtools/apt/apt.inc:EXTRA_OECONF_append_angstrom = "
ac_cv_glibc_ver=libc6.4"
That also triggered me to do this:
frans@frans-desktop:~/workspace/openembedded-core$ grep -r _poky .
./meta/recipes-sato/pcmanfm/pcmanfm_0.9.10.bb:DEPENDS_append_poky = "
libowl"
./meta/recipes-sato/pcmanfm/pcmanfm_0.9.10.bb:SRC_URI_append_poky = "
file://owl-window-menu.patch"
./meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb:DEPENDS_append_poky = "
libowl"
./meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb:SRC_URI_append_poky += "
file://owl-menu.patch;apply=yes "
./meta/recipes-sato/pimlico/dates.inc:OWL_poky = "--enable-owl
--disable-dnd"
./meta/recipes-sato/pimlico/dates.inc:DEPENDS_append_poky = " libowl"
./meta/recipes-sato/pimlico/dates.inc:SRC_URI_append_poky = "
file://dates-owl-window-menu.patch;apply=yes "
./meta/recipes-sato/pimlico/tasks_0.19.bb:OWL_poky = "--with-owl"
./meta/recipes-sato/pimlico/contacts.inc:DEPENDS_append_poky = " libowl"
./meta/recipes-sato/pimlico/contacts.inc:OWL_poky = "--enable-owl"
./meta/recipes-sato/pimlico/contacts.inc:SRC_URI_append_poky = "
file://contacts-owl-window-menu.patch;apply=yes "
./meta/recipes-sato/pimlico/tasks.inc:DEPENDS_append_poky = " libowl"
./meta/recipes-sato/pimlico/tasks.inc:OWL_poky ?= "--enable-owl"
./meta/recipes-sato/puzzles/oh-puzzles_git.bb:DEPENDS_append_poky = "
libowl"
./meta/recipes-sato/puzzles/oh-puzzles_git.bb:SRC_URI_append_poky = "
file://oh-puzzles-owl-menu.patch;striplevel=0 "
./meta/recipes-devtools/gcc/gcc-runtime_4.6.bb:EXTRA_OECONF_append_poky-lsb
= " --enable-clocale=gnu"
I'd hoped oe-core to be core and not know things about distro's etc.
E.g. the first case with apt, this should probably be fixed with a
.bbappend in the angstrom layer, shouldn't it.
And the poky things in a poky layer.
(at least that is what I expected/hoped)
Btw did the same thing on meta-oe:
no _poky's, two for _angstrom:
./meta-oe/recipes-core/systemd/systemd_git.bb:SYSTEMDDISTRO_angstrom =
"angstrom"
./meta-gnome/recipes-gnome/system-tools/system-tools-backends_2.10.2.bb:SRC_URI_append_angstrom
= " \
In general I expected recipes to be without distro or hw suffixes (such a
suffx is an indication that the recipe is probably not at the proper place)
Best regards, Frans
[-- Attachment #2: Type: text/html, Size: 2643 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: should recipes be distro agnostic?
2012-01-26 6:52 should recipes be distro agnostic? Frans Meulenbroeks
@ 2012-01-26 11:31 ` Paul Eggleton
2012-01-26 11:38 ` Richard Purdie
0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggleton @ 2012-01-26 11:31 UTC (permalink / raw)
To: openembedded-core; +Cc: Frans Meulenbroeks
On Thursday 26 January 2012 07:52:22 Frans Meulenbroeks wrote:
> By coincidence I bumped into this in oe-core:
>
> ./meta/recipes-devtools/apt/apt.inc:EXTRA_OECONF_append_angstrom = "
> ac_cv_glibc_ver=libc6.4"
>
> That also triggered me to do this:
>
> frans@frans-desktop:~/workspace/openembedded-core$ grep -r _poky .
> ./meta/recipes-sato/pcmanfm/pcmanfm_0.9.10.bb:DEPENDS_append_poky = "
> libowl"
> ./meta/recipes-sato/pcmanfm/pcmanfm_0.9.10.bb:SRC_URI_append_poky = "
> file://owl-window-menu.patch"
> ./meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb:DEPENDS_append_poky = "
> libowl"
> ./meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb:SRC_URI_append_poky += "
> file://owl-menu.patch;apply=yes "
> ./meta/recipes-sato/pimlico/dates.inc:OWL_poky = "--enable-owl
> --disable-dnd"
> ./meta/recipes-sato/pimlico/dates.inc:DEPENDS_append_poky = " libowl"
> ./meta/recipes-sato/pimlico/dates.inc:SRC_URI_append_poky = "
> file://dates-owl-window-menu.patch;apply=yes "
> ./meta/recipes-sato/pimlico/tasks_0.19.bb:OWL_poky = "--with-owl"
> ./meta/recipes-sato/pimlico/contacts.inc:DEPENDS_append_poky = " libowl"
> ./meta/recipes-sato/pimlico/contacts.inc:OWL_poky = "--enable-owl"
> ./meta/recipes-sato/pimlico/contacts.inc:SRC_URI_append_poky = "
> file://contacts-owl-window-menu.patch;apply=yes "
> ./meta/recipes-sato/pimlico/tasks.inc:DEPENDS_append_poky = " libowl"
> ./meta/recipes-sato/pimlico/tasks.inc:OWL_poky ?= "--enable-owl"
> ./meta/recipes-sato/puzzles/oh-puzzles_git.bb:DEPENDS_append_poky = "
> libowl"
> ./meta/recipes-sato/puzzles/oh-puzzles_git.bb:SRC_URI_append_poky = "
> file://oh-puzzles-owl-menu.patch;striplevel=0 "
> ./meta/recipes-devtools/gcc/gcc-runtime_4.6.bb:EXTRA_OECONF_append_poky-lsb
> = " --enable-clocale=gnu"
>
> I'd hoped oe-core to be core and not know things about distro's etc.
> E.g. the first case with apt, this should probably be fixed with a
> .bbappend in the angstrom layer, shouldn't it.
> And the poky things in a poky layer.
Absolutely, there should be no distro-specific items in OE-Core at all, and I
have to admit I was not aware they were there. Most of the poky ones seem to
be related to enabling libowl in various Sato apps - I don't know enough about
this area to know if we should now just always be applying these or whether
they indeed need to be moved out. Richard/Saul/anyone else?
Regarding meta-oe, I think we have bigger issues than the items you found (see
other thread on OE-devel) although they shouldn't be in there either.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: should recipes be distro agnostic?
2012-01-26 11:31 ` Paul Eggleton
@ 2012-01-26 11:38 ` Richard Purdie
0 siblings, 0 replies; 3+ messages in thread
From: Richard Purdie @ 2012-01-26 11:38 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer; +Cc: Frans Meulenbroeks
On Thu, 2012-01-26 at 11:31 +0000, Paul Eggleton wrote:
> On Thursday 26 January 2012 07:52:22 Frans Meulenbroeks wrote:
> > By coincidence I bumped into this in oe-core:
> >
> > ./meta/recipes-devtools/apt/apt.inc:EXTRA_OECONF_append_angstrom = "
> > ac_cv_glibc_ver=libc6.4"
> >
> > That also triggered me to do this:
> >
> > frans@frans-desktop:~/workspace/openembedded-core$ grep -r _poky .
> > ./meta/recipes-sato/pcmanfm/pcmanfm_0.9.10.bb:DEPENDS_append_poky = "
> > libowl"
> > ./meta/recipes-sato/pcmanfm/pcmanfm_0.9.10.bb:SRC_URI_append_poky = "
> > file://owl-window-menu.patch"
> > ./meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb:DEPENDS_append_poky = "
> > libowl"
> > ./meta/recipes-sato/leafpad/leafpad_0.8.18.1.bb:SRC_URI_append_poky += "
> > file://owl-menu.patch;apply=yes "
> > ./meta/recipes-sato/pimlico/dates.inc:OWL_poky = "--enable-owl
> > --disable-dnd"
> > ./meta/recipes-sato/pimlico/dates.inc:DEPENDS_append_poky = " libowl"
> > ./meta/recipes-sato/pimlico/dates.inc:SRC_URI_append_poky = "
> > file://dates-owl-window-menu.patch;apply=yes "
> > ./meta/recipes-sato/pimlico/tasks_0.19.bb:OWL_poky = "--with-owl"
> > ./meta/recipes-sato/pimlico/contacts.inc:DEPENDS_append_poky = " libowl"
> > ./meta/recipes-sato/pimlico/contacts.inc:OWL_poky = "--enable-owl"
> > ./meta/recipes-sato/pimlico/contacts.inc:SRC_URI_append_poky = "
> > file://contacts-owl-window-menu.patch;apply=yes "
> > ./meta/recipes-sato/pimlico/tasks.inc:DEPENDS_append_poky = " libowl"
> > ./meta/recipes-sato/pimlico/tasks.inc:OWL_poky ?= "--enable-owl"
> > ./meta/recipes-sato/puzzles/oh-puzzles_git.bb:DEPENDS_append_poky = "
> > libowl"
> > ./meta/recipes-sato/puzzles/oh-puzzles_git.bb:SRC_URI_append_poky = "
> > file://oh-puzzles-owl-menu.patch;striplevel=0 "
> > ./meta/recipes-devtools/gcc/gcc-runtime_4.6.bb:EXTRA_OECONF_append_poky-lsb
> > = " --enable-clocale=gnu"
> >
> > I'd hoped oe-core to be core and not know things about distro's etc.
> > E.g. the first case with apt, this should probably be fixed with a
> > .bbappend in the angstrom layer, shouldn't it.
> > And the poky things in a poky layer.
>
> Absolutely, there should be no distro-specific items in OE-Core at all, and I
> have to admit I was not aware they were there. Most of the poky ones seem to
> be related to enabling libowl in various Sato apps - I don't know enough about
> this area to know if we should now just always be applying these or whether
> they indeed need to be moved out. Richard/Saul/anyone else?
Agreed, we need to find a better way to handle those. As you say, there
were nearly all libowl related. The poky-lsb override should become
linuxstdbase or whatever the dedicated override we created was, that is
just a simple mistake to fix.
The libowl changes shouldn't always be applied, they are rather sato
specific. We could add a sato override to replace that one?
Cheers,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-26 11:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-26 6:52 should recipes be distro agnostic? Frans Meulenbroeks
2012-01-26 11:31 ` Paul Eggleton
2012-01-26 11:38 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox