so what's the deal with "..._append +="?

so what's the deal with "..._append +="?

[Robert P. J. Day]

  pretty sure i mentioned this once before but this just looks weird:

$ grep -r "_append +=" *
meta/recipes-support/gmp/gmp_5.0.4.bb:SRC_URI_append += "file://use-includedir.patch \
meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-dev_append += "${bindir}/rpcgen ${libdir}/*_nonshared.a \
meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-staticdev_append += "${libdir}/*.a ${base_libdir}/*.a"
meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb:CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
$

  should those be just simple assignments?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: so what's the deal with "..._append +="?

[Richard Purdie]

On Mon, 2012-04-02 at 07:37 -0400, Robert P. J. Day wrote:
> pretty sure i mentioned this once before but this just looks weird:
> 
> $ grep -r "_append +=" *
> meta/recipes-support/gmp/gmp_5.0.4.bb:SRC_URI_append += "file://use-includedir.patch \
> meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-dev_append += "${bindir}/rpcgen ${libdir}/*_nonshared.a \
> meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-staticdev_append += "${libdir}/*.a ${base_libdir}/*.a"
> meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb:CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
> $
> 
>   should those be just simple assignments?

The += does add in a whitespace character. I agree it would be less
confusing if they were just plain _append = " xxx" though.

Cheers,

Richard

Re: so what's the deal with "..._append +="?

[Phil Blundell]

On Mon, 2012-04-02 at 07:37 -0400, Robert P. J. Day wrote:
> pretty sure i mentioned this once before but this just looks weird:
> 
> $ grep -r "_append +=" *
> meta/recipes-support/gmp/gmp_5.0.4.bb:SRC_URI_append += "file://use-includedir.patch \
> meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-dev_append += "${bindir}/rpcgen ${libdir}/*_nonshared.a \
> meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-staticdev_append += "${libdir}/*.a ${base_libdir}/*.a"
> meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb:CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
> $
> 
>   should those be just simple assignments?

Probably most of them should lose the _append and just use +=.  I doubt
many/any of them are actually relying on the delayed semantics of
_append.  

If they do require the delayed appending then yes, they should be
straight assignments with _append.  All except the last example would
need a space adding on the right hand side though, in that case.

p.

Re: so what's the deal with "..._append +="?

[Robert P. J. Day]

On Mon, 2 Apr 2012, Richard Purdie wrote:

> On Mon, 2012-04-02 at 07:37 -0400, Robert P. J. Day wrote:
> > pretty sure i mentioned this once before but this just looks weird:
> >
> > $ grep -r "_append +=" *
> > meta/recipes-support/gmp/gmp_5.0.4.bb:SRC_URI_append += "file://use-includedir.patch \
> > meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-dev_append += "${bindir}/rpcgen ${libdir}/*_nonshared.a \
> > meta/recipes-core/eglibc/eglibc-package.inc:FILES_${PN}-staticdev_append += "${libdir}/*.a ${base_libdir}/*.a"
> > meta/recipes-graphics/xorg-lib/libxp_1.0.1.bb:CFLAGS_append += " -I ${S}/include/X11/XprintUtil -I ${S}/include/X11/extensions"
> > $
> >
> >   should those be just simple assignments?
>
> The += does add in a whitespace character. I agree it would be less
> confusing if they were just plain _append = " xxx" though.

  dang, i'd forgotten about the whitespace.  but still, it's
definitely non-intuitive to use what appears to be a double-append
operation.  anyway, i'll leave that for people higher up the food
chain to decide if they want to do anything about it.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================