From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCHv2 2/3] u-boot: make FILESDIR a shared setting.
Date: Mon, 02 Jul 2012 20:03:35 +0100 [thread overview]
Message-ID: <1341255815.23146.262.camel@ted> (raw)
In-Reply-To: <CAP9ODKpVfDG31Bh=gy0xgPCcGMbH4g-=CNrrE2TVc+RHnvp7EA@mail.gmail.com>
On Mon, 2012-07-02 at 13:42 -0300, Otavio Salvador wrote:
> On Mon, Jul 2, 2012 at 10:33 AM, Chris Larson <clarson@kergoth.com> wrote:
> > On Mon, Jul 2, 2012 at 4:24 AM, Otavio Salvador <otavio@ossystems.com.br> wrote:
> >> On Mon, Jul 2, 2012 at 2:44 AM, Paul Gortmaker
> >> <paul.gortmaker@windriver.com> wrote:
> >>> The setting is the same in all recipes, so move it to
> >>> the shared settings in u-boot.inc
> >>>
> >>> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> >>
> >> Acked-by: Otavio Salvador <otavio@ossystems.com.br>
> >
> > It shouldn't be using the old, legacy FILESDIR mechanism at all.
>
> Indeed; grepping for it shows nothing.
>
> This can be removed :-D
This isn't what Chris meant. BitBake handles FILESDIR, not the metadata
(and grepping bitbake will show a result).
I'm tempted to take the patch on the grounds that a single reference to
fix is probably easier than several other references. The replacement is
probably something like:
FILESPATH =. "${FILE_DIRNAME}/u-boot-git/${MACHINE}:"
We should really get on, replace the remaining references and complete
removal of FILESDIR.
Cheers,
Richard
next prev parent reply other threads:[~2012-07-02 19:14 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 18:35 [PATCH 0/3] u-boot recipe updates Paul Gortmaker
2012-06-29 18:35 ` [PATCH 1/3] u-boot: Don't make the -Os removal part of global settings Paul Gortmaker
2012-06-29 21:55 ` Khem Raj
2012-06-29 22:01 ` Wolfgang Denk
2012-06-29 22:11 ` Khem Raj
2012-06-29 23:34 ` Wolfgang Denk
2012-06-30 2:49 ` Khem Raj
2012-07-01 22:03 ` Saul Wold
2012-07-01 23:14 ` Khem Raj
2012-07-02 3:04 ` Paul Gortmaker
2012-07-02 5:44 ` [PATCHv2 0/3] u-boot recipe updates Paul Gortmaker
2012-07-02 5:44 ` [PATCHv2 1/3] u-boot: Don't make the -Os removal part of global settings Paul Gortmaker
2012-07-02 11:23 ` Otavio Salvador
2012-07-02 5:44 ` [PATCHv2 2/3] u-boot: make FILESDIR a shared setting Paul Gortmaker
2012-07-02 11:24 ` Otavio Salvador
2012-07-02 13:33 ` Chris Larson
2012-07-02 16:42 ` Otavio Salvador
2012-07-02 19:03 ` Richard Purdie [this message]
2012-07-02 5:44 ` [PATCHv2 3/3] u-boot: do not clobber PARALLEL_MAKE setting Paul Gortmaker
2012-07-02 11:25 ` Otavio Salvador
2012-07-03 17:48 ` [PATCHv2 0/3] u-boot recipe updates Saul Wold
2012-07-04 14:12 ` Paul Gortmaker
2012-07-04 15:00 ` Paul Gortmaker
2012-07-04 15:29 ` Phil Blundell
2012-07-05 16:14 ` Paul Gortmaker
2012-07-09 16:01 ` Phil Blundell
2012-07-09 18:20 ` McClintock Matthew-B29882
2012-07-09 18:52 ` Paul Gortmaker
2012-07-09 19:08 ` Richard Purdie
2012-07-04 15:23 ` [PATCH] u-boot: make FILESDIR a shared setting via FILESPATH Paul Gortmaker
2012-07-04 15:38 ` Martin Jansa
2012-07-04 17:01 ` Richard Purdie
2012-07-05 17:19 ` Saul Wold
2012-06-29 18:35 ` [PATCH 2/3] u-boot: make FILESDIR a shared setting Paul Gortmaker
2012-06-29 18:35 ` [PATCH 3/3] u-boot: make sure CROSS_COMPILE is passed into build Paul Gortmaker
2012-06-29 20:04 ` McClintock Matthew-B29882
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1341255815.23146.262.camel@ted \
--to=richard.purdie@linuxfoundation.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox