From: Martin Jansa <martin.jansa@gmail.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] u-boot: make FILESDIR a shared setting via FILESPATH
Date: Wed, 4 Jul 2012 17:38:43 +0200 [thread overview]
Message-ID: <20120704153843.GD15100@jama.jama.net> (raw)
In-Reply-To: <1341415425-16073-1-git-send-email-paul.gortmaker@windriver.com>
[-- Attachment #1: Type: text/plain, Size: 3640 bytes --]
On Wed, Jul 04, 2012 at 11:23:45AM -0400, Paul Gortmaker wrote:
> The setting is the same in all recipes, so move it to
> the shared settings in u-boot.inc
>
> Since FILESDIR is also being phased out, use the FILESPATH
> setting as suggested by Richard Purdie.
Shouldn't it be added in FILESEXTRAPATHS instead of FILESPATH?
Cheers,
> Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
>
> [ PG: Retested builds for 8315 and beagleboard ]
>
> meta/recipes-bsp/u-boot/u-boot.inc | 1 +
> meta/recipes-bsp/u-boot/u-boot_2011.03.bb | 2 --
> meta/recipes-bsp/u-boot/u-boot_2011.06.bb | 2 --
> meta/recipes-bsp/u-boot/u-boot_2012.04.01.bb | 2 --
> 4 files changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
> index 5de3583..664c2e6 100644
> --- a/meta/recipes-bsp/u-boot/u-boot.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot.inc
> @@ -59,6 +59,7 @@ do_install () {
> }
>
> FILES_${PN} = "/boot"
> +FILESPATH =. "${FILE_DIRNAME}/u-boot-git/${MACHINE}:"
>
> do_deploy () {
> install -d ${DEPLOYDIR}
> diff --git a/meta/recipes-bsp/u-boot/u-boot_2011.03.bb b/meta/recipes-bsp/u-boot/u-boot_2011.03.bb
> index e99bc2c..ed38f54 100644
> --- a/meta/recipes-bsp/u-boot/u-boot_2011.03.bb
> +++ b/meta/recipes-bsp/u-boot/u-boot_2011.03.bb
> @@ -10,8 +10,6 @@ LICENSE = "GPLv2+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb \
> file://README;beginline=1;endline=22;md5=3a00ef51d3fc96e9d6c1bc4708ccd3b5"
>
> -FILESDIR = "${@os.path.dirname(d.getVar('FILE',1))}/u-boot-git/${MACHINE}"
> -
> # This revision corresponds to the tag "v2011.03"
> # We use the revision in order to avoid having to fetch it from the repo during parse
> SRCREV = "19b54a701811220221fc4d5089a2bb18892018ca"
> diff --git a/meta/recipes-bsp/u-boot/u-boot_2011.06.bb b/meta/recipes-bsp/u-boot/u-boot_2011.06.bb
> index 680401f..da61852 100644
> --- a/meta/recipes-bsp/u-boot/u-boot_2011.06.bb
> +++ b/meta/recipes-bsp/u-boot/u-boot_2011.06.bb
> @@ -10,8 +10,6 @@ LICENSE = "GPLv2+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb \
> file://README;beginline=1;endline=22;md5=5ba4218ac89af7846802d0348df3fb90"
>
> -FILESDIR = "${@os.path.dirname(d.getVar('FILE',1))}/u-boot-git/${MACHINE}"
> -
> # This revision corresponds to the tag "v2011.06"
> # We use the revision in order to avoid having to fetch it from the repo during parse
> SRCREV = "b1af6f532e0d348b153d5c148369229d24af361a"
> diff --git a/meta/recipes-bsp/u-boot/u-boot_2012.04.01.bb b/meta/recipes-bsp/u-boot/u-boot_2012.04.01.bb
> index dbdc663..25cc8c9 100644
> --- a/meta/recipes-bsp/u-boot/u-boot_2012.04.01.bb
> +++ b/meta/recipes-bsp/u-boot/u-boot_2012.04.01.bb
> @@ -14,8 +14,6 @@ DEFAULT_PREFERENCE = "-1"
> LICENSE = "GPLv2+"
> LIC_FILES_CHKSUM = "file://COPYING;md5=1707d6db1d42237583f50183a5651ecb"
>
> -FILESDIR = "${@os.path.dirname(d.getVar('FILE',1))}/u-boot-git/${MACHINE}"
> -
> # This revision corresponds to the tag "v2012.04.01"
> # We use the revision in order to avoid having to fetch it from the
> # repo during parse
> --
> 1.7.9.6
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2012-07-04 15:49 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 18:35 [PATCH 0/3] u-boot recipe updates Paul Gortmaker
2012-06-29 18:35 ` [PATCH 1/3] u-boot: Don't make the -Os removal part of global settings Paul Gortmaker
2012-06-29 21:55 ` Khem Raj
2012-06-29 22:01 ` Wolfgang Denk
2012-06-29 22:11 ` Khem Raj
2012-06-29 23:34 ` Wolfgang Denk
2012-06-30 2:49 ` Khem Raj
2012-07-01 22:03 ` Saul Wold
2012-07-01 23:14 ` Khem Raj
2012-07-02 3:04 ` Paul Gortmaker
2012-07-02 5:44 ` [PATCHv2 0/3] u-boot recipe updates Paul Gortmaker
2012-07-02 5:44 ` [PATCHv2 1/3] u-boot: Don't make the -Os removal part of global settings Paul Gortmaker
2012-07-02 11:23 ` Otavio Salvador
2012-07-02 5:44 ` [PATCHv2 2/3] u-boot: make FILESDIR a shared setting Paul Gortmaker
2012-07-02 11:24 ` Otavio Salvador
2012-07-02 13:33 ` Chris Larson
2012-07-02 16:42 ` Otavio Salvador
2012-07-02 19:03 ` Richard Purdie
2012-07-02 5:44 ` [PATCHv2 3/3] u-boot: do not clobber PARALLEL_MAKE setting Paul Gortmaker
2012-07-02 11:25 ` Otavio Salvador
2012-07-03 17:48 ` [PATCHv2 0/3] u-boot recipe updates Saul Wold
2012-07-04 14:12 ` Paul Gortmaker
2012-07-04 15:00 ` Paul Gortmaker
2012-07-04 15:29 ` Phil Blundell
2012-07-05 16:14 ` Paul Gortmaker
2012-07-09 16:01 ` Phil Blundell
2012-07-09 18:20 ` McClintock Matthew-B29882
2012-07-09 18:52 ` Paul Gortmaker
2012-07-09 19:08 ` Richard Purdie
2012-07-04 15:23 ` [PATCH] u-boot: make FILESDIR a shared setting via FILESPATH Paul Gortmaker
2012-07-04 15:38 ` Martin Jansa [this message]
2012-07-04 17:01 ` Richard Purdie
2012-07-05 17:19 ` Saul Wold
2012-06-29 18:35 ` [PATCH 2/3] u-boot: make FILESDIR a shared setting Paul Gortmaker
2012-06-29 18:35 ` [PATCH 3/3] u-boot: make sure CROSS_COMPILE is passed into build Paul Gortmaker
2012-06-29 20:04 ` McClintock Matthew-B29882
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120704153843.GD15100@jama.jama.net \
--to=martin.jansa@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox