Re: [PATCH 1/1] EFI: Make installer EFI aware

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2012-07-19 at 09:27 -0700, Darren Hart wrote:
> 
> On 07/19/2012 09:15 AM, Richard Purdie wrote:
> > On Tue, 2012-07-17 at 12:47 -0700, Darren Hart wrote:
> >>
> >> On 07/17/2012 12:40 PM, Saul Wold wrote:
> >>> On 07/17/2012 12:29 PM, Darren Hart wrote:
> >>
> >>>> --- a/meta/recipes-core/images/core-image-minimal-initramfs.bb
> >>>> +++ b/meta/recipes-core/images/core-image-minimal-initramfs.bb
> >>>> @@ -3,7 +3,7 @@ DESCRIPTION = "Small image capable of booting a device. The kernel includes \
> >>>>   the Minimal RAM-based Initial Root Filesystem (initramfs), which finds the \
> >>>>   first “init” program more efficiently."
> >>>>
> >>>> -IMAGE_INSTALL = "initramfs-live-boot initramfs-live-install busybox udev base-passwd"
> >>>> +IMAGE_INSTALL = "initramfs-live-boot initramfs-live-install initramfs-live-install-efi busybox udev base-passwd"
> >>>>
> >>>>   # Do not pollute the initrd image with rootfs features
> >>>>   IMAGE_FEATURES = ""
> >>>
> >>> Does this now need a PR bump also?
> >>
> >> I didn't think so as this recipe is rebuilt for every image anyway.
> >> There is no PR in this recipe.
> >>
> >>>> diff --git a/meta/recipes-core/initrdscripts/initramfs-live-install-efi_1.0.bb b/meta/recipes-core/initrdscripts/initramfs-live-install-efi_1.0.bb
> >>>> new file mode 100644
> >>>> index 0000000..6696d94
> >>>> --- /dev/null
> >>>> +++ b/meta/recipes-core/initrdscripts/initramfs-live-install-efi_1.0.bb
> >>>> @@ -0,0 +1,22 @@
> >>>> +DESCRIPTION = "A live image init script for grub-efi"
> >>>> +LICENSE = "MIT"
> >>>> +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
> >>>> +SRC_URI = "file://init-install-efi.sh"
> >>>> +
> >>>> +PR = "r7"
> >>>> +
> >>> Why PR = r7 for a new recipe, there should be no PR as it defaults to r0?
> >>
> >> Good catch, just my forcing rebuilds during development, or perhaps a
> >> left-over copy from the initramfs-live-install_1.0.bb I based it on.
> >> Updated as r0 in the branch.
> > 
> > Could I ask you to update this on top of Radu's fix please?
> 
> Will do.

Thanks, merged to master.

Richard