Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@linux.intel.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 1/1] EFI: Make installer EFI aware
Date: Tue, 17 Jul 2012 12:47:00 -0700	[thread overview]
Message-ID: <5005C134.4080805@linux.intel.com> (raw)
In-Reply-To: <5005BFA6.5050809@linux.intel.com>



On 07/17/2012 12:40 PM, Saul Wold wrote:
> On 07/17/2012 12:29 PM, Darren Hart wrote:

>> --- a/meta/recipes-core/images/core-image-minimal-initramfs.bb
>> +++ b/meta/recipes-core/images/core-image-minimal-initramfs.bb
>> @@ -3,7 +3,7 @@ DESCRIPTION = "Small image capable of booting a device. The kernel includes \
>>   the Minimal RAM-based Initial Root Filesystem (initramfs), which finds the \
>>   first “init” program more efficiently."
>>
>> -IMAGE_INSTALL = "initramfs-live-boot initramfs-live-install busybox udev base-passwd"
>> +IMAGE_INSTALL = "initramfs-live-boot initramfs-live-install initramfs-live-install-efi busybox udev base-passwd"
>>
>>   # Do not pollute the initrd image with rootfs features
>>   IMAGE_FEATURES = ""
> 
> Does this now need a PR bump also?

I didn't think so as this recipe is rebuilt for every image anyway.
There is no PR in this recipe.

>> diff --git a/meta/recipes-core/initrdscripts/initramfs-live-install-efi_1.0.bb b/meta/recipes-core/initrdscripts/initramfs-live-install-efi_1.0.bb
>> new file mode 100644
>> index 0000000..6696d94
>> --- /dev/null
>> +++ b/meta/recipes-core/initrdscripts/initramfs-live-install-efi_1.0.bb
>> @@ -0,0 +1,22 @@
>> +DESCRIPTION = "A live image init script for grub-efi"
>> +LICENSE = "MIT"
>> +LIC_FILES_CHKSUM = "file://${COREBASE}/meta/COPYING.MIT;md5=3da9cfbcb788c80a0384361b4de20420"
>> +SRC_URI = "file://init-install-efi.sh"
>> +
>> +PR = "r7"
>> +
> Why PR = r7 for a new recipe, there should be no PR as it defaults to r0?

Good catch, just my forcing rebuilds during development, or perhaps a
left-over copy from the initramfs-live-install_1.0.bb I based it on.
Updated as r0 in the branch.

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel





  reply	other threads:[~2012-07-17 20:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17 19:29 [PATCH 0/1 V2] EFI: Make installer EFI aware Darren Hart
2012-07-17 19:29 ` [PATCH 1/1] " Darren Hart
2012-07-17 19:40   ` Saul Wold
2012-07-17 19:47     ` Darren Hart [this message]
2012-07-19 16:15       ` Richard Purdie
2012-07-19 16:27         ` Darren Hart
2012-07-19 16:54           ` Richard Purdie
  -- strict thread matches above, loose matches on Subject: below --
2012-07-19 16:45 [PATCH V3 0/1] " Darren Hart
2012-07-19 16:45 ` [PATCH 1/1] " Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5005C134.4080805@linux.intel.com \
    --to=dvhart@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sgw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox