* [PATCH] arch-ia32: Add x32 to MACHINEOVERRIDES @ 2012-09-11 15:07 Saul Wold 2012-09-11 15:13 ` Richard Purdie 0 siblings, 1 reply; 5+ messages in thread From: Saul Wold @ 2012-09-11 15:07 UTC (permalink / raw) To: openembedded-core This will allow the KERNEL_FEATURES to trigger the x32 ABI via overrides Signed-off-by: Saul Wold <sgw@linux.intel.com> --- meta/conf/machine/include/ia32/arch-ia32.inc | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/meta/conf/machine/include/ia32/arch-ia32.inc b/meta/conf/machine/include/ia32/arch-ia32.inc index 15f67d7..fa70e57 100644 --- a/meta/conf/machine/include/ia32/arch-ia32.inc +++ b/meta/conf/machine/include/ia32/arch-ia32.inc @@ -24,6 +24,7 @@ ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", "x32", "" ,d)}" TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-mx32", "", d)}" TUNE_LDARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-m elf32_x86_64", "", d)}" TUNE_ASARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-x32", "", d)}" +MACHINEOVERRIDES .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", ":x32", "" ,d)}" # ELF64 ABI TUNEVALID[m64] = "IA32e (x86_64) ELF64 standard ABI" -- 1.7.7.6 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] arch-ia32: Add x32 to MACHINEOVERRIDES 2012-09-11 15:07 [PATCH] arch-ia32: Add x32 to MACHINEOVERRIDES Saul Wold @ 2012-09-11 15:13 ` Richard Purdie 2012-09-11 15:36 ` Saul Wold 0 siblings, 1 reply; 5+ messages in thread From: Richard Purdie @ 2012-09-11 15:13 UTC (permalink / raw) To: Saul Wold; +Cc: openembedded-core On Tue, 2012-09-11 at 08:07 -0700, Saul Wold wrote: > This will allow the KERNEL_FEATURES to trigger the x32 ABI via overrides > > Signed-off-by: Saul Wold <sgw@linux.intel.com> > --- > meta/conf/machine/include/ia32/arch-ia32.inc | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/meta/conf/machine/include/ia32/arch-ia32.inc b/meta/conf/machine/include/ia32/arch-ia32.inc > index 15f67d7..fa70e57 100644 > --- a/meta/conf/machine/include/ia32/arch-ia32.inc > +++ b/meta/conf/machine/include/ia32/arch-ia32.inc > @@ -24,6 +24,7 @@ ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", "x32", "" ,d)}" > TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-mx32", "", d)}" > TUNE_LDARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-m elf32_x86_64", "", d)}" > TUNE_ASARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-x32", "", d)}" > +MACHINEOVERRIDES .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", ":x32", "" ,d)}" > > # ELF64 ABI > TUNEVALID[m64] = "IA32e (x86_64) ELF64 standard ABI" This is just for the kernel issue, right? In that case, just use ${@bb.utils.contains("TUNE_FEATURES", "mx32", "xxxx", "" ,d)} in the kernel recipe code... Cheers, Richard ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arch-ia32: Add x32 to MACHINEOVERRIDES 2012-09-11 15:13 ` Richard Purdie @ 2012-09-11 15:36 ` Saul Wold 2012-09-11 15:53 ` Mark Hatle 2012-09-11 15:56 ` Richard Purdie 0 siblings, 2 replies; 5+ messages in thread From: Saul Wold @ 2012-09-11 15:36 UTC (permalink / raw) To: Richard Purdie; +Cc: openembedded-core On 09/11/2012 08:13 AM, Richard Purdie wrote: > On Tue, 2012-09-11 at 08:07 -0700, Saul Wold wrote: >> This will allow the KERNEL_FEATURES to trigger the x32 ABI via overrides >> >> Signed-off-by: Saul Wold <sgw@linux.intel.com> >> --- >> meta/conf/machine/include/ia32/arch-ia32.inc | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/meta/conf/machine/include/ia32/arch-ia32.inc b/meta/conf/machine/include/ia32/arch-ia32.inc >> index 15f67d7..fa70e57 100644 >> --- a/meta/conf/machine/include/ia32/arch-ia32.inc >> +++ b/meta/conf/machine/include/ia32/arch-ia32.inc >> @@ -24,6 +24,7 @@ ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", "x32", "" ,d)}" >> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-mx32", "", d)}" >> TUNE_LDARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-m elf32_x86_64", "", d)}" >> TUNE_ASARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-x32", "", d)}" >> +MACHINEOVERRIDES .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", ":x32", "" ,d)}" >> >> # ELF64 ABI >> TUNEVALID[m64] = "IA32e (x86_64) ELF64 standard ABI" > > This is just for the kernel issue, right? > > In that case, just use ${@bb.utils.contains("TUNE_FEATURES", "mx32", > "xxxx", "" ,d)} in the kernel recipe code... > It's possible that there will be other recipes that need patches or other changes in the future, but I guess we can cross that bridge when we come to it. I think I will actually use the features update that Bruce just added from here instead. Since multiple BSP could take advantage of x32 we should not have to edit each of there kernel recipes. It should just be enabled based on the x32 DEFAULTTUNE. Thanks Sau! > Cheers, > > Richard > > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arch-ia32: Add x32 to MACHINEOVERRIDES 2012-09-11 15:36 ` Saul Wold @ 2012-09-11 15:53 ` Mark Hatle 2012-09-11 15:56 ` Richard Purdie 1 sibling, 0 replies; 5+ messages in thread From: Mark Hatle @ 2012-09-11 15:53 UTC (permalink / raw) To: openembedded-core On 9/11/12 10:36 AM, Saul Wold wrote: > On 09/11/2012 08:13 AM, Richard Purdie wrote: >> On Tue, 2012-09-11 at 08:07 -0700, Saul Wold wrote: >>> This will allow the KERNEL_FEATURES to trigger the x32 ABI via overrides >>> >>> Signed-off-by: Saul Wold <sgw@linux.intel.com> >>> --- >>> meta/conf/machine/include/ia32/arch-ia32.inc | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> >>> diff --git a/meta/conf/machine/include/ia32/arch-ia32.inc b/meta/conf/machine/include/ia32/arch-ia32.inc >>> index 15f67d7..fa70e57 100644 >>> --- a/meta/conf/machine/include/ia32/arch-ia32.inc >>> +++ b/meta/conf/machine/include/ia32/arch-ia32.inc >>> @@ -24,6 +24,7 @@ ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", "x32", "" ,d)}" >>> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-mx32", "", d)}" >>> TUNE_LDARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-m elf32_x86_64", "", d)}" >>> TUNE_ASARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-x32", "", d)}" >>> +MACHINEOVERRIDES .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", ":x32", "" ,d)}" >>> >>> # ELF64 ABI >>> TUNEVALID[m64] = "IA32e (x86_64) ELF64 standard ABI" >> >> This is just for the kernel issue, right? >> >> In that case, just use ${@bb.utils.contains("TUNE_FEATURES", "mx32", >> "xxxx", "" ,d)} in the kernel recipe code... >> > It's possible that there will be other recipes that need patches or > other changes in the future, but I guess we can cross that bridge when > we come to it. > > I think I will actually use the features update that Bruce just added > from here instead. Since multiple BSP could take advantage of x32 we > should not have to edit each of there kernel recipes. It should just be > enabled based on the x32 DEFAULTTUNE. I know there are a few other things that can (and should) change behavior based on the x32 flag.. but flag or override, it just changes slightly the implementation mechanism -- either should work as long as we consistently use it. --Mark > Thanks > Sau! > > > >> Cheers, >> >> Richard >> >> >> > > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arch-ia32: Add x32 to MACHINEOVERRIDES 2012-09-11 15:36 ` Saul Wold 2012-09-11 15:53 ` Mark Hatle @ 2012-09-11 15:56 ` Richard Purdie 1 sibling, 0 replies; 5+ messages in thread From: Richard Purdie @ 2012-09-11 15:56 UTC (permalink / raw) To: Saul Wold; +Cc: openembedded-core On Tue, 2012-09-11 at 08:36 -0700, Saul Wold wrote: > On 09/11/2012 08:13 AM, Richard Purdie wrote: > > On Tue, 2012-09-11 at 08:07 -0700, Saul Wold wrote: > >> This will allow the KERNEL_FEATURES to trigger the x32 ABI via overrides > >> > >> Signed-off-by: Saul Wold <sgw@linux.intel.com> > >> --- > >> meta/conf/machine/include/ia32/arch-ia32.inc | 1 + > >> 1 files changed, 1 insertions(+), 0 deletions(-) > >> > >> diff --git a/meta/conf/machine/include/ia32/arch-ia32.inc b/meta/conf/machine/include/ia32/arch-ia32.inc > >> index 15f67d7..fa70e57 100644 > >> --- a/meta/conf/machine/include/ia32/arch-ia32.inc > >> +++ b/meta/conf/machine/include/ia32/arch-ia32.inc > >> @@ -24,6 +24,7 @@ ABIEXTENSION .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", "x32", "" ,d)}" > >> TUNE_CCARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-mx32", "", d)}" > >> TUNE_LDARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-m elf32_x86_64", "", d)}" > >> TUNE_ASARGS += "${@bb.utils.contains("TUNE_FEATURES", "mx32", "-x32", "", d)}" > >> +MACHINEOVERRIDES .= "${@bb.utils.contains("TUNE_FEATURES", "mx32", ":x32", "" ,d)}" > >> > >> # ELF64 ABI > >> TUNEVALID[m64] = "IA32e (x86_64) ELF64 standard ABI" > > > > This is just for the kernel issue, right? > > > > In that case, just use ${@bb.utils.contains("TUNE_FEATURES", "mx32", > > "xxxx", "" ,d)} in the kernel recipe code... > > > It's possible that there will be other recipes that need patches or > other changes in the future, but I guess we can cross that bridge when > we come to it. > > I think I will actually use the features update that Bruce just added > from here instead. Since multiple BSP could take advantage of x32 we > should not have to edit each of there kernel recipes. It should just be > enabled based on the x32 DEFAULTTUNE. No, no, no. DEFAULTTUNE is a really bad idea for these kind of decisions, what if x32 is one of the other tunes enabled? You're not the first person to use DEFAULTTUNE like this recently and its not what its intended for at all :/. Also, the kernel features are specific to linux-yocto so you can't use them from a core ABI file. Cheers, Richard ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-09-11 16:08 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-09-11 15:07 [PATCH] arch-ia32: Add x32 to MACHINEOVERRIDES Saul Wold 2012-09-11 15:13 ` Richard Purdie 2012-09-11 15:36 ` Saul Wold 2012-09-11 15:53 ` Mark Hatle 2012-09-11 15:56 ` Richard Purdie
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox