Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Mark Hatle <mark.hatle@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 2/6] classes/*_rpm: integrate Smart into RPM filesystem construction
Date: Thu, 06 Dec 2012 15:31:26 +0000	[thread overview]
Message-ID: <1354807886.12928.9.camel@ted> (raw)
In-Reply-To: <04747ce39a3fbbd538556c67247452b931a3ccc5.1354650148.git.mark.hatle@windriver.com>

On Tue, 2012-12-04 at 13:49 -0600, Mark Hatle wrote:
> From: Paul Eggleton <paul.eggleton@linux.intel.com>
> 
> Use Smart to construct the root filesystem for images and the contents
> of SDKs rather than the custom scripts around rpm we had previously.
> This ensures the result when producing an updated image will be the
> same as upgrading to the same package versions from an older image on
> the target, as well as allowing us to remove a substantial amount of
> code making the rpm classes much easier to follow.
> 
> Some bugfixes from Bogdan Marinescu <bogdan.marinescu@intel.com>.
> SDK implementation and testing as well as a number of bugfixes from
> Mark Hatle <mark.hatle@windriver.com>.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
> Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
> ---
>  meta/classes/package_rpm.bbclass      |  533 ++++++---------------------------
>  meta/classes/populate_sdk_rpm.bbclass |   48 +---
>  meta/classes/rootfs_rpm.bbclass       |   31 +-
>  3 files changed, 117 insertions(+), 495 deletions(-)
> 
> diff --git a/meta/classes/package_rpm.bbclass b/meta/classes/package_rpm.bbclass
> index 200a941..aa5b156 100644
> --- a/meta/classes/package_rpm.bbclass
> +++ b/meta/classes/package_rpm.bbclass
> @@ -8,6 +8,8 @@ RPMBUILD="rpmbuild"
>  PKGWRITEDIRRPM = "${WORKDIR}/deploy-rpms"
>  PKGWRITEDIRSRPM = "${DEPLOY_DIR}/sources/deploy-srpm"
>  
> +EXTRANATIVEPATH += "python-native"
> +

Er, no!

Why do we need to do this? We now need python-native at package
generation time? Why?

There is no dependency for that and this would totally kill build
performance if we did add it.

Cheers,

Richard




  reply	other threads:[~2012-12-06 15:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-04 19:49 [PATCH 0/6] Integrate Smart for RPM image generation Mark Hatle
2012-12-04 19:49 ` [PATCH 1/6] rootfs_rpm.bbclass: Revert to default shell logging behavior Mark Hatle
2012-12-04 19:49 ` [PATCH 2/6] classes/*_rpm: integrate Smart into RPM filesystem construction Mark Hatle
2012-12-06 15:31   ` Richard Purdie [this message]
2012-12-06 16:13     ` Paul Eggleton
2012-12-06 17:19       ` Mark Hatle
2012-12-04 19:49 ` [PATCH 3/6] classes/rootfs_rpm: install smart instead of zypper in rpm-based images Mark Hatle
2012-12-04 19:49 ` [PATCH 4/6] package_rpm: Update the way the multilib package names are translated Mark Hatle
2012-12-04 19:49 ` [PATCH 5/6] package_rpm.bbclass: Add additional logging Mark Hatle
2012-12-04 19:49 ` [PATCH 6/6] package_rpm.bbclass: Add support for incremental installs Mark Hatle
2012-12-06  5:08 ` [PATCH 0/6] Integrate Smart for RPM image generation Saul Wold
2012-12-06 13:58   ` Paul Eggleton
2012-12-06 17:04   ` Mark Hatle
2012-12-06 17:22     ` Paul Eggleton
2012-12-08  3:29 ` Saul Wold
2012-12-08  6:37 ` Saul Wold
2012-12-08 17:10   ` Mark Hatle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354807886.12928.9.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=mark.hatle@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox