* [PATCH] image.bbclass: depend on gdk-pixbuf-native
@ 2013-05-29 21:30 Eric Bénard
2013-05-29 21:53 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Eric Bénard @ 2013-05-29 21:30 UTC (permalink / raw)
To: openembedded-core
it's using scripts from scripts/postinst-intercepts/ which contain
gdk-pixbuf-query-loaders so it should depend on gdk-pixbuf-native
else the host binary will be used and it will try to update the
host's cache
[YOCTO #4572]
Signed-off-by: Eric Bénard <eric@eukrea.com>
---
fix the same problem in dylan
meta/classes/image.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
index 04db533..6c16a1a 100644
--- a/meta/classes/image.bbclass
+++ b/meta/classes/image.bbclass
@@ -10,7 +10,7 @@ inherit gzipnative
LICENSE = "MIT"
PACKAGES = ""
-DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross"
+DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross gdk-pixbuf-native"
RDEPENDS += "${IMAGE_INSTALL} ${LINGUAS_INSTALL} ${NORMAL_FEATURE_INSTALL} ${ROOTFS_BOOTSTRAP_INSTALL}"
RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"
--
1.8.1.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] image.bbclass: depend on gdk-pixbuf-native
2013-05-29 21:30 [PATCH] image.bbclass: depend on gdk-pixbuf-native Eric Bénard
@ 2013-05-29 21:53 ` Richard Purdie
2013-05-30 7:00 ` Eric Bénard
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2013-05-29 21:53 UTC (permalink / raw)
To: Eric Bénard; +Cc: openembedded-core
On Wed, 2013-05-29 at 23:30 +0200, Eric Bénard wrote:
> it's using scripts from scripts/postinst-intercepts/ which contain
> gdk-pixbuf-query-loaders so it should depend on gdk-pixbuf-native
> else the host binary will be used and it will try to update the
> host's cache
>
> [YOCTO #4572]
>
> Signed-off-by: Eric Bénard <eric@eukrea.com>
> ---
> fix the same problem in dylan
>
> meta/classes/image.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 04db533..6c16a1a 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -10,7 +10,7 @@ inherit gzipnative
>
> LICENSE = "MIT"
> PACKAGES = ""
> -DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross"
> +DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross gdk-pixbuf-native"
> RDEPENDS += "${IMAGE_INSTALL} ${LINGUAS_INSTALL} ${NORMAL_FEATURE_INSTALL} ${ROOTFS_BOOTSTRAP_INSTALL}"
> RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"
Ah, this has made me realise what the real problem is and that there is
a better way to fix this. We need to add
DEPENDS += "gdk-pixbuf-native"
to pixbufcache.bbclass and gtk-icon-cache.bbclass then people not using
those things don't get the dependency added.
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] image.bbclass: depend on gdk-pixbuf-native
2013-05-29 21:53 ` Richard Purdie
@ 2013-05-30 7:00 ` Eric Bénard
2013-05-30 7:36 ` Eric Bénard
0 siblings, 1 reply; 4+ messages in thread
From: Eric Bénard @ 2013-05-30 7:00 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
Le Wed, 29 May 2013 22:53:31 +0100,
Richard Purdie <richard.purdie@linuxfoundation.org> a écrit :
> On Wed, 2013-05-29 at 23:30 +0200, Eric Bénard wrote:
> > it's using scripts from scripts/postinst-intercepts/ which contain
> > gdk-pixbuf-query-loaders so it should depend on gdk-pixbuf-native
> > else the host binary will be used and it will try to update the
> > host's cache
> >
> > [YOCTO #4572]
> >
> > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > ---
> > fix the same problem in dylan
> >
> > meta/classes/image.bbclass | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> > index 04db533..6c16a1a 100644
> > --- a/meta/classes/image.bbclass
> > +++ b/meta/classes/image.bbclass
> > @@ -10,7 +10,7 @@ inherit gzipnative
> >
> > LICENSE = "MIT"
> > PACKAGES = ""
> > -DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross"
> > +DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross gdk-pixbuf-native"
> > RDEPENDS += "${IMAGE_INSTALL} ${LINGUAS_INSTALL} ${NORMAL_FEATURE_INSTALL} ${ROOTFS_BOOTSTRAP_INSTALL}"
> > RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"
>
> Ah, this has made me realise what the real problem is and that there is
> a better way to fix this. We need to add
>
> DEPENDS += "gdk-pixbuf-native"
>
> to pixbufcache.bbclass and gtk-icon-cache.bbclass then people not using
> those things don't get the dependency added.
>
I tried on gtk-icon-cache and that didn't work ... seems I missed
pixbufcache.bbclass ;-)
Eric
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] image.bbclass: depend on gdk-pixbuf-native
2013-05-30 7:00 ` Eric Bénard
@ 2013-05-30 7:36 ` Eric Bénard
0 siblings, 0 replies; 4+ messages in thread
From: Eric Bénard @ 2013-05-30 7:36 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core
Le Thu, 30 May 2013 09:00:55 +0200,
Eric Bénard <eric@eukrea.com> a écrit :
> Le Wed, 29 May 2013 22:53:31 +0100,
> Richard Purdie <richard.purdie@linuxfoundation.org> a écrit :
>
> > On Wed, 2013-05-29 at 23:30 +0200, Eric Bénard wrote:
> > > it's using scripts from scripts/postinst-intercepts/ which contain
> > > gdk-pixbuf-query-loaders so it should depend on gdk-pixbuf-native
> > > else the host binary will be used and it will try to update the
> > > host's cache
> > >
> > > [YOCTO #4572]
> > >
> > > Signed-off-by: Eric Bénard <eric@eukrea.com>
> > > ---
> > > fix the same problem in dylan
> > >
> > > meta/classes/image.bbclass | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> > > index 04db533..6c16a1a 100644
> > > --- a/meta/classes/image.bbclass
> > > +++ b/meta/classes/image.bbclass
> > > @@ -10,7 +10,7 @@ inherit gzipnative
> > >
> > > LICENSE = "MIT"
> > > PACKAGES = ""
> > > -DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross"
> > > +DEPENDS += "${MLPREFIX}qemuwrapper-cross ${MLPREFIX}depmodwrapper-cross gdk-pixbuf-native"
> > > RDEPENDS += "${IMAGE_INSTALL} ${LINGUAS_INSTALL} ${NORMAL_FEATURE_INSTALL} ${ROOTFS_BOOTSTRAP_INSTALL}"
> > > RRECOMMENDS += "${NORMAL_FEATURE_INSTALL_OPTIONAL}"
> >
> > Ah, this has made me realise what the real problem is and that there is
> > a better way to fix this. We need to add
> >
> > DEPENDS += "gdk-pixbuf-native"
> >
> > to pixbufcache.bbclass and gtk-icon-cache.bbclass then people not using
> > those things don't get the dependency added.
> >
> I tried on gtk-icon-cache and that didn't work ... seems I missed
> pixbufcache.bbclass ;-)
>
OK that was not the real problem. The real problem is that my image
installs hicolor-icon-theme which has :
inherit gnome allarch
DEPENDS = ""
so despite the classes that this recipe inherit have the correct
dependencies, it won't have any dependency so if you install this
package without any gnome package that will fail ...
Patch is following.
Eric
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-05-30 7:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-29 21:30 [PATCH] image.bbclass: depend on gdk-pixbuf-native Eric Bénard
2013-05-29 21:53 ` Richard Purdie
2013-05-30 7:00 ` Eric Bénard
2013-05-30 7:36 ` Eric Bénard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox