Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] packagegroup-core-basic: libuser has a hard depenency on libpam
@ 2013-10-15 22:22 Saul Wold
  2013-10-16 10:25 ` Paul Eggleton
  0 siblings, 1 reply; 6+ messages in thread
From: Saul Wold @ 2013-10-15 22:22 UTC (permalink / raw)
  To: openembedded-core

Since libpam is only built when DISTRO_FEATURES pam is enabled we should
not be trying to build libuser also.

[YOCTO #4949]

Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
 meta/recipes-extended/packagegroups/packagegroup-core-basic.bb |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-extended/packagegroups/packagegroup-core-basic.bb b/meta/recipes-extended/packagegroups/packagegroup-core-basic.bb
index 2e6f576..596fede 100644
--- a/meta/recipes-extended/packagegroups/packagegroup-core-basic.bb
+++ b/meta/recipes-extended/packagegroups/packagegroup-core-basic.bb
@@ -107,7 +107,7 @@ RDEPENDS_packagegroup-core-initscripts = "\
 RDEPENDS_packagegroup-core-multiuser = "\
     cracklib \
     gzip \
-    libuser \
+    ${@base_contains('DISTRO_FEATURES', 'pam', 'libuser', '', d)} \
     shadow \
     sudo \
     "
-- 
1.7.10.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] packagegroup-core-basic: libuser has a hard depenency on libpam
  2013-10-15 22:22 [PATCH] packagegroup-core-basic: libuser has a hard depenency on libpam Saul Wold
@ 2013-10-16 10:25 ` Paul Eggleton
  2013-10-16 11:23   ` Koen Kooi
  0 siblings, 1 reply; 6+ messages in thread
From: Paul Eggleton @ 2013-10-16 10:25 UTC (permalink / raw)
  To: Saul Wold; +Cc: openembedded-core

On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
> Since libpam is only built when DISTRO_FEATURES pam is enabled we should
> not be trying to build libuser also.

Should this packagegroup be bringing in libraries such as this at all, given 
that libraries are generally pulled in as dependencies of applications that 
link to them?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] packagegroup-core-basic: libuser has a hard depenency on libpam
  2013-10-16 10:25 ` Paul Eggleton
@ 2013-10-16 11:23   ` Koen Kooi
  2013-10-16 11:47     ` Paul Eggleton
  0 siblings, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2013-10-16 11:23 UTC (permalink / raw)
  To: Paul Eggleton; +Cc: openembedded-core


Op 16 okt. 2013, om 12:25 heeft Paul Eggleton <paul.eggleton@linux.intel.com> het volgende geschreven:

> On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
>> Since libpam is only built when DISTRO_FEATURES pam is enabled we should
>> not be trying to build libuser also.
> 
> Should this packagegroup be bringing in libraries such as this at all, given 
> that libraries are generally pulled in as dependencies of applications that 
> link to them?

If it is a pure library, no. But libuser doesn't seem to be a pure library package:

[koen@rrMBP libuser]$ cat libuser/latest
PV = 0.58
PR = r0
PKGR = r0.0
RPROVIDES = 
RDEPENDS = eglibc (>= 2.17) glib-2.0 (>= 2.34.3) libffi (>= 3.0.11) libpam (>= 1.1.6) popt (>= 1.16)
RRECOMMENDS = 
PKGSIZE = 283679
FILES = /usr/bin/* /usr/sbin/* /usr/lib/libuser/* /usr/lib/lib*.so.* /etc /com /var /bin/* /sbin/* /lib/*.so.* /lib/udev/rules.d /usr/lib/udev/rules.d /usr/share/libuser /usr/lib/libuser/* /usr/share/pixmaps /usr/share/applications /usr/share/idl /usr/share/omf /usr/share/sounds /usr/lib/bonobo/servers
FILELIST = /etc/libuser.conf /usr/bin/lchfn /usr/bin/lchsh /usr/lib/libuser.so.1 /usr/lib/libuser.so.1.4.0 /usr/lib/libuser/libuser_files.so /usr/lib/libuser/libuser_shadow.so /usr/sbin/lchage /usr/sbin/lgroupadd /usr/sbin/lgroupdel /usr/sbin/lgroupmod /usr/sbin/lid /usr/sbin/lnewusers /usr/sbin/lpasswd /usr/sbin/luseradd /usr/sbin/luserdel /usr/sbin/lusermod

regards,

Koen

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] packagegroup-core-basic: libuser has a hard depenency on libpam
  2013-10-16 11:23   ` Koen Kooi
@ 2013-10-16 11:47     ` Paul Eggleton
  2013-10-16 12:21       ` Koen Kooi
  0 siblings, 1 reply; 6+ messages in thread
From: Paul Eggleton @ 2013-10-16 11:47 UTC (permalink / raw)
  To: Koen Kooi, Saul Wold; +Cc: openembedded-core

On Wednesday 16 October 2013 13:23:08 Koen Kooi wrote:
> Op 16 okt. 2013, om 12:25 heeft Paul Eggleton
> <paul.eggleton@linux.intel.com> het volgende geschreven:
> > On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
> >> Since libpam is only built when DISTRO_FEATURES pam is enabled we should
> >> not be trying to build libuser also.
> > 
> > Should this packagegroup be bringing in libraries such as this at all,
> > given that libraries are generally pulled in as dependencies of
> > applications that link to them?
> 
> If it is a pure library, no. But libuser doesn't seem to be a pure library
> package:
> 
> [koen@rrMBP libuser]$ cat libuser/latest
> PV = 0.58
> PR = r0
> PKGR = r0.0
> RPROVIDES =
> RDEPENDS = eglibc (>= 2.17) glib-2.0 (>= 2.34.3) libffi (>= 3.0.11) libpam
> (>= 1.1.6) popt (>= 1.16) RRECOMMENDS =
> PKGSIZE = 283679
> FILES = /usr/bin/* /usr/sbin/* /usr/lib/libuser/* /usr/lib/lib*.so.* /etc
> /com /var /bin/* /sbin/* /lib/*.so.* /lib/udev/rules.d
> /usr/lib/udev/rules.d /usr/share/libuser /usr/lib/libuser/*
> /usr/share/pixmaps /usr/share/applications /usr/share/idl /usr/share/omf
> /usr/share/sounds /usr/lib/bonobo/servers FILELIST = /etc/libuser.conf
> /usr/bin/lchfn /usr/bin/lchsh /usr/lib/libuser.so.1
> /usr/lib/libuser.so.1.4.0 /usr/lib/libuser/libuser_files.so
> /usr/lib/libuser/libuser_shadow.so /usr/sbin/lchage /usr/sbin/lgroupadd
> /usr/sbin/lgroupdel /usr/sbin/lgroupmod /usr/sbin/lid /usr/sbin/lnewusers
> /usr/sbin/lpasswd /usr/sbin/luseradd /usr/sbin/luserdel /usr/sbin/lusermod

Right, in that case, ignore me :)

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] packagegroup-core-basic: libuser has a hard depenency on libpam
  2013-10-16 11:47     ` Paul Eggleton
@ 2013-10-16 12:21       ` Koen Kooi
  2013-10-16 12:24         ` Richard Purdie
  0 siblings, 1 reply; 6+ messages in thread
From: Koen Kooi @ 2013-10-16 12:21 UTC (permalink / raw)
  To: Paul Eggleton; +Cc: openembedded-core


Op 16 okt. 2013, om 13:47 heeft Paul Eggleton <paul.eggleton@linux.intel.com> het volgende geschreven:

> On Wednesday 16 October 2013 13:23:08 Koen Kooi wrote:
>> Op 16 okt. 2013, om 12:25 heeft Paul Eggleton
>> <paul.eggleton@linux.intel.com> het volgende geschreven:
>>> On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
>>>> Since libpam is only built when DISTRO_FEATURES pam is enabled we should
>>>> not be trying to build libuser also.
>>> 
>>> Should this packagegroup be bringing in libraries such as this at all,
>>> given that libraries are generally pulled in as dependencies of
>>> applications that link to them?
>> 
>> If it is a pure library, no. But libuser doesn't seem to be a pure library
>> package:
>> 
>> [koen@rrMBP libuser]$ cat libuser/latest
>> PV = 0.58
>> PR = r0
>> PKGR = r0.0
>> RPROVIDES =
>> RDEPENDS = eglibc (>= 2.17) glib-2.0 (>= 2.34.3) libffi (>= 3.0.11) libpam
>> (>= 1.1.6) popt (>= 1.16) RRECOMMENDS =
>> PKGSIZE = 283679
>> FILES = /usr/bin/* /usr/sbin/* /usr/lib/libuser/* /usr/lib/lib*.so.* /etc
>> /com /var /bin/* /sbin/* /lib/*.so.* /lib/udev/rules.d
>> /usr/lib/udev/rules.d /usr/share/libuser /usr/lib/libuser/*
>> /usr/share/pixmaps /usr/share/applications /usr/share/idl /usr/share/omf
>> /usr/share/sounds /usr/lib/bonobo/servers FILELIST = /etc/libuser.conf
>> /usr/bin/lchfn /usr/bin/lchsh /usr/lib/libuser.so.1
>> /usr/lib/libuser.so.1.4.0 /usr/lib/libuser/libuser_files.so
>> /usr/lib/libuser/libuser_shadow.so /usr/sbin/lchage /usr/sbin/lgroupadd
>> /usr/sbin/lgroupdel /usr/sbin/lgroupmod /usr/sbin/lid /usr/sbin/lnewusers
>> /usr/sbin/lpasswd /usr/sbin/luseradd /usr/sbin/luserdel /usr/sbin/lusermod
> 
> Right, in that case, ignore me :)

But I still don't know what it does and why it needs to be in packagegroup-core-basic, though.

regards,

Koen

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] packagegroup-core-basic: libuser has a hard depenency on libpam
  2013-10-16 12:21       ` Koen Kooi
@ 2013-10-16 12:24         ` Richard Purdie
  0 siblings, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2013-10-16 12:24 UTC (permalink / raw)
  To: Koen Kooi; +Cc: Paul Eggleton, openembedded-core

On Wed, 2013-10-16 at 14:21 +0200, Koen Kooi wrote:
> Op 16 okt. 2013, om 13:47 heeft Paul Eggleton <paul.eggleton@linux.intel.com> het volgende geschreven:
> 
> > On Wednesday 16 October 2013 13:23:08 Koen Kooi wrote:
> >> Op 16 okt. 2013, om 12:25 heeft Paul Eggleton
> >> <paul.eggleton@linux.intel.com> het volgende geschreven:
> >>> On Tuesday 15 October 2013 15:22:46 Saul Wold wrote:
> >>>> Since libpam is only built when DISTRO_FEATURES pam is enabled we should
> >>>> not be trying to build libuser also.
> >>> 
> >>> Should this packagegroup be bringing in libraries such as this at all,
> >>> given that libraries are generally pulled in as dependencies of
> >>> applications that link to them?
> >> 
> >> If it is a pure library, no. But libuser doesn't seem to be a pure library
> >> package:
> >> 
> >> [koen@rrMBP libuser]$ cat libuser/latest
> >> PV = 0.58
> >> PR = r0
> >> PKGR = r0.0
> >> RPROVIDES =
> >> RDEPENDS = eglibc (>= 2.17) glib-2.0 (>= 2.34.3) libffi (>= 3.0.11) libpam
> >> (>= 1.1.6) popt (>= 1.16) RRECOMMENDS =
> >> PKGSIZE = 283679
> >> FILES = /usr/bin/* /usr/sbin/* /usr/lib/libuser/* /usr/lib/lib*.so.* /etc
> >> /com /var /bin/* /sbin/* /lib/*.so.* /lib/udev/rules.d
> >> /usr/lib/udev/rules.d /usr/share/libuser /usr/lib/libuser/*
> >> /usr/share/pixmaps /usr/share/applications /usr/share/idl /usr/share/omf
> >> /usr/share/sounds /usr/lib/bonobo/servers FILELIST = /etc/libuser.conf
> >> /usr/bin/lchfn /usr/bin/lchsh /usr/lib/libuser.so.1
> >> /usr/lib/libuser.so.1.4.0 /usr/lib/libuser/libuser_files.so
> >> /usr/lib/libuser/libuser_shadow.so /usr/sbin/lchage /usr/sbin/lgroupadd
> >> /usr/sbin/lgroupdel /usr/sbin/lgroupmod /usr/sbin/lid /usr/sbin/lnewusers
> >> /usr/sbin/lpasswd /usr/sbin/luseradd /usr/sbin/luserdel /usr/sbin/lusermod
> > 
> > Right, in that case, ignore me :)
> 
> But I still don't know what it does and why it needs to be in packagegroup-core-basic, though.

Looks like it has a number of pam user tools (groupadd, useradd and so
on) and this goes with the other contents of
packagegroup-core-multiuser...

Cheers,

Richard



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-10-16 12:24 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-15 22:22 [PATCH] packagegroup-core-basic: libuser has a hard depenency on libpam Saul Wold
2013-10-16 10:25 ` Paul Eggleton
2013-10-16 11:23   ` Koen Kooi
2013-10-16 11:47     ` Paul Eggleton
2013-10-16 12:21       ` Koen Kooi
2013-10-16 12:24         ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox