* [PATCH] pseudo: fix library path in FILES_${PN}
@ 2013-10-29 4:54 rongqing.li
2013-10-29 23:03 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: rongqing.li @ 2013-10-29 4:54 UTC (permalink / raw)
To: openembedded-core
From: Roy Li <rongqing.li@windriver.com>
libpseudo.so is always installed into ${prefix}/lib/, not ${libdir},
so fix these paths; and skip libdir WARN_QA checking to ignore the
warning in 64bit and multilib enabled system
Signed-off-by: Roy Li <rongqing.li@windriver.com>
---
meta/recipes-devtools/pseudo/pseudo.inc | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-devtools/pseudo/pseudo.inc b/meta/recipes-devtools/pseudo/pseudo.inc
index 0471cd6..9411c57 100644
--- a/meta/recipes-devtools/pseudo/pseudo.inc
+++ b/meta/recipes-devtools/pseudo/pseudo.inc
@@ -13,8 +13,11 @@ SRC_URI_append_class-nativesdk = " file://symver.patch"
SRC_URI_append_class-native = " file://symver.patch"
-FILES_${PN} = "${libdir}/pseudo/lib*/libpseudo.so ${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
-FILES_${PN}-dbg += "${libdir}/pseudo/lib*/.debug"
+FILES_${PN} = "${prefix}/lib/pseudo/lib*/libpseudo.so ${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
+FILES_${PN}-dbg += "${prefix}/lib/pseudo/lib*/.debug"
+INSANE_SKIP_${PN} += "libdir"
+INSANE_SKIP_${PN}-dbg += "libdir"
+
PROVIDES += "virtual/fakeroot"
MAKEOPTS = ""
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] pseudo: fix library path in FILES_${PN}
2013-10-29 4:54 [PATCH] pseudo: fix library path in FILES_${PN} rongqing.li
@ 2013-10-29 23:03 ` Khem Raj
2013-10-30 10:43 ` Richard Purdie
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2013-10-29 23:03 UTC (permalink / raw)
To: rongqing.li@windriver.com; +Cc: Patches and discussions about the oe-core layer
On Mon, Oct 28, 2013 at 9:54 PM, <rongqing.li@windriver.com> wrote:
> -FILES_${PN} = "${libdir}/pseudo/lib*/libpseudo.so ${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
> -FILES_${PN}-dbg += "${libdir}/pseudo/lib*/.debug"
> +FILES_${PN} = "${prefix}/lib/pseudo/lib*/libpseudo.so ${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
> +FILES_${PN}-dbg += "${prefix}/lib/pseudo/lib*/.debug"
> +INSANE_SKIP_${PN} += "libdir"
> +INSANE_SKIP_${PN}-dbg += "libdir"
> +
may be you can use ${nonarch_base_libdir} instead of hardcoding
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pseudo: fix library path in FILES_${PN}
2013-10-29 23:03 ` Khem Raj
@ 2013-10-30 10:43 ` Richard Purdie
2013-10-31 0:45 ` Rongqing Li
0 siblings, 1 reply; 4+ messages in thread
From: Richard Purdie @ 2013-10-30 10:43 UTC (permalink / raw)
To: Khem Raj; +Cc: Patches and discussions about the oe-core layer
On Tue, 2013-10-29 at 16:03 -0700, Khem Raj wrote:
> On Mon, Oct 28, 2013 at 9:54 PM, <rongqing.li@windriver.com> wrote:
> > -FILES_${PN} = "${libdir}/pseudo/lib*/libpseudo.so ${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
> > -FILES_${PN}-dbg += "${libdir}/pseudo/lib*/.debug"
> > +FILES_${PN} = "${prefix}/lib/pseudo/lib*/libpseudo.so ${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
> > +FILES_${PN}-dbg += "${prefix}/lib/pseudo/lib*/.debug"
> > +INSANE_SKIP_${PN} += "libdir"
> > +INSANE_SKIP_${PN}-dbg += "libdir"
> > +
>
> may be you can use ${nonarch_base_libdir} instead of hardcoding
It is pointless using that expression if the path is hardcoded into the
source though, which in this case, I suspect it is :(
Cheers,
Richard
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] pseudo: fix library path in FILES_${PN}
2013-10-30 10:43 ` Richard Purdie
@ 2013-10-31 0:45 ` Rongqing Li
0 siblings, 0 replies; 4+ messages in thread
From: Rongqing Li @ 2013-10-31 0:45 UTC (permalink / raw)
To: Richard Purdie; +Cc: Patches and discussions about the oe-core layer
On 10/30/2013 06:43 PM, Richard Purdie wrote:
> On Tue, 2013-10-29 at 16:03 -0700, Khem Raj wrote:
>> On Mon, Oct 28, 2013 at 9:54 PM, <rongqing.li@windriver.com> wrote:
>>> -FILES_${PN} = "${libdir}/pseudo/lib*/libpseudo.so ${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
>>> -FILES_${PN}-dbg += "${libdir}/pseudo/lib*/.debug"
>>> +FILES_${PN} = "${prefix}/lib/pseudo/lib*/libpseudo.so ${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
>>> +FILES_${PN}-dbg += "${prefix}/lib/pseudo/lib*/.debug"
>>> +INSANE_SKIP_${PN} += "libdir"
>>> +INSANE_SKIP_${PN}-dbg += "libdir"
>>> +
>>
>> may be you can use ${nonarch_base_libdir} instead of hardcoding
>
> It is pointless using that expression if the path is hardcoded into the
> source though, which in this case, I suspect it is :(
>
> Cheers,
It is true, if we use ${nonarch_base_libdir}, we need to change the all:
lirq@lirq-OptiPlex-780:/home/prj/oe-core/meta/recipes-devtools/pseudo$
grep "${prefix}/lib" ./ -r
./pseudo.inc:FILES_${PN} = "${prefix}/lib/pseudo/lib*/libpseudo.so
${bindir}/* ${localstatedir}/pseudo ${prefix}/var/pseudo"
./pseudo.inc:FILES_${PN}-dbg += "${prefix}/lib/pseudo/lib*/.debug"
./pseudo.inc: ${S}/configure ${PSEUDO_EXTRA_OPTS} --prefix=${prefix}
--libdir=${prefix}/lib/pseudo/lib${SITEINFO_BITS}
--with-sqlite-lib=${baselib}
--with-sqlite=${STAGING_DIR_TARGET}${exec_prefix} --cflags="${CFLAGS}"
--bits=${SITEINFO_BITS} --enable-static-sqlite --without-rpath
./pseudo.inc: ${S}/configure ${PSEUDO_EXTRA_OPTS} --prefix=${prefix}
--libdir=${prefix}/lib/pseudo/lib --with-sqlite-lib=${baselib}
--with-sqlite=${STAGING_DIR_TARGET}${exec_prefix} --cflags="${CFLAGS}"
--bits=${SITEINFO_BITS} --enable-static-sqlite --without-rpath
./pseudo.inc: ./configure ${PSEUDO_EXTRA_OPTS} --prefix=${prefix}
--libdir=${prefix}/lib/pseudo/lib --with-sqlite-lib=${baselib}
--with-sqlite=${STAGING_DIR_TARGET}${exec_prefix} --bits=32 --without-rpath
./pseudo.inc: ./configure ${PSEUDO_EXTRA_OPTS} --prefix=${prefix}
--libdir=${prefix}/lib/pseudo/lib --with-sqlite-lib=${baselib}
--with-sqlite=${STAGING_DIR_TARGET}${exec_prefix} --bits=32 --without-rpath
./pseudo.inc: oe_runmake 'DESTDIR=${D}' ${MAKEOPTS}
'LIB=lib/pseudo/lib$(MARK64)' install
./pseudo.inc: mkdir -p ${D}${prefix}/lib/pseudo/lib
./pseudo.inc: cp lib/pseudo/lib/libpseudo.so ${D}${prefix}/lib/pseudo/lib/.
./pseudo.inc: mkdir -p ${D}${prefix}/lib/pseudo/lib
./pseudo.inc: cp lib/pseudo/lib/libpseudo.so ${D}${prefix}/lib/pseudo/lib/.
lirq@lirq-OptiPlex-780:/home/prj/oe-core/meta/recipes-devtools/pseudo$
-Roy
>
> Richard
>
>
>
--
Best Reagrds,
Roy | RongQing Li
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-10-31 0:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-29 4:54 [PATCH] pseudo: fix library path in FILES_${PN} rongqing.li
2013-10-29 23:03 ` Khem Raj
2013-10-30 10:43 ` Richard Purdie
2013-10-31 0:45 ` Rongqing Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox