Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Koen Kooi <koen.kooi@linaro.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [RFC][PATCH] package.bbclass: fix strip and split logic
Date: Tue, 21 Jan 2014 13:57:13 +0000	[thread overview]
Message-ID: <1390312633.874.84.camel@ted> (raw)
In-Reply-To: <1390297632-9966-1-git-send-email-koen.kooi@linaro.org>

On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
> Marks original commit message and variable documentation state that stripping and splitting are independent of eachother, but package.bbclass ANDs the two INHIBIT flags to see which files can be stripped and/or split.
> 
> Original behaviour:
> 
> INHIBIT_PACKAGE_STRIP: no strip, no debug split
> INHIBIT_PACAKGE_DEBUG_SPLIT: no strip, no debug split
> 
> Behaviour after this patch:
> 
> INHIBIT_PACKAGE_STRIP: no strip, no debug split
> INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split
> 
> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
> ---
>  meta/classes/package.bbclass | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

FWIW this resulted in a failure on minnow:

http://autobuilder.yoctoproject.org/main/builders/minnow/builds/15/steps/BuildImages/logs/stdio

So we may have some fixing up to do before this change can be merged...

Cheers,

Richard



  reply	other threads:[~2014-01-21 13:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-21  9:47 [RFC][PATCH] package.bbclass: fix strip and split logic Koen Kooi
2014-01-21 13:57 ` Richard Purdie [this message]
2014-01-21 14:03   ` Koen Kooi
2014-01-21 15:04     ` Mark Hatle
2014-01-21 15:09     ` Richard Purdie
2014-01-23  9:34       ` Koen Kooi
2014-01-23 11:33         ` Otavio Salvador
2014-01-23 12:41         ` Martin Jansa
2014-02-04  8:58       ` Koen Kooi
2014-02-04  9:32         ` Richard Purdie
2014-02-04 11:20           ` Otavio Salvador
2014-02-04 11:27             ` Koen Kooi
2014-02-04 12:12               ` Otavio Salvador
2014-02-04 10:10         ` Paul Eggleton
2014-02-04 11:01           ` Koen Kooi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1390312633.874.84.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=koen.kooi@linaro.org \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox