Re: [RFC][PATCH] package.bbclass: fix strip and split logic

[Koen Kooi <koen.kooi@linaro.org>]

On 01/21/2014 04:09 PM, Richard Purdie wrote:
> On Tue, 2014-01-21 at 15:03 +0100, Koen Kooi wrote:
>> On 01/21/2014 02:57 PM, Richard Purdie wrote:
>>> On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
>>>> Marks original commit message and variable documentation state that stripping and splitting are independent of eachother, but package.bbclass ANDs the two INHIBIT flags to see which files can be stripped and/or split.
>>>>
>>>> Original behaviour:
>>>>
>>>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
>>>> INHIBIT_PACAKGE_DEBUG_SPLIT: no strip, no debug split
>>>>
>>>> Behaviour after this patch:
>>>>
>>>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
>>>> INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split
>>>>
>>>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>>>> ---
>>>>    meta/classes/package.bbclass | 3 +--
>>>>    1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> FWIW this resulted in a failure on minnow:
>>>
>>> http://autobuilder.yoctoproject.org/main/builders/minnow/builds/15/steps/BuildImages/logs/stdio
>>>
>>> So we may have some fixing up to do before this change can be merged...
>>
>> I have that QA issue as warning not as error. I guess that's why my
>> builds kept working :)
>>
>> Aside from that, what are your thoughts on this patch?
>
> I'm ok with it in principle but I'd like to see known build issues fixed
> before it goes in since red autobuilders cause me enough grief
> already ;-).

I've changed all occurrences of INHIBIT_PACKAGE_DEBUG_SPLIT to have 
INHIBIT_PACKAGE_STRIP as well in all the layers angstrom has configured. 
I've sent patches to:

meta-intel
meta-initramfs
meta-oe
meta-fsl-arm
meta-android
meta-aurora
meta-linaro-toolchain

Which brings me to my next point:

If you list a mailinglist in your README where you want to have patches 
sent, don't make it automatically reject them. I'm looking at you, 
shr-devel!

-- 
Koen Kooi
Builds and Baselines | Release Manager
Linaro.org | Open source software for ARM SoCs