Re: [RFC][PATCH] package.bbclass: fix strip and split logic

[Mark Hatle <mark.hatle@windriver.com>]

On 1/21/14, 8:03 AM, Koen Kooi wrote:
> On 01/21/2014 02:57 PM, Richard Purdie wrote:
>> On Tue, 2014-01-21 at 10:47 +0100, Koen Kooi wrote:
>>> Marks original commit message and variable documentation state that stripping and splitting are independent of eachother, but package.bbclass ANDs the two INHIBIT flags to see which files can be stripped and/or split.
>>>
>>> Original behaviour:
>>>
>>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
>>> INHIBIT_PACAKGE_DEBUG_SPLIT: no strip, no debug split
>>>
>>> Behaviour after this patch:
>>>
>>> INHIBIT_PACKAGE_STRIP: no strip, no debug split
>>> INHIBIT_PACKAGE_DEBUG_SPLIT: strip, no split

My memory of the original theory was that there would be three different uses:

1 - I want no debug (stripped) software on the target and debug binaries (split)

2 - I want debug (not-stripped/not-split) software on the target

3 - I want no debug (stripped) software on the target, and I don't want debug 
binaries

So based on that, it looks like your change fixes things.  As the original 
implementation didn't allow for #3.

--Mark

>>> Signed-off-by: Koen Kooi <koen.kooi@linaro.org>
>>> ---
>>>    meta/classes/package.bbclass | 3 +--
>>>    1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> FWIW this resulted in a failure on minnow:
>>
>> http://autobuilder.yoctoproject.org/main/builders/minnow/builds/15/steps/BuildImages/logs/stdio
>>
>> So we may have some fixing up to do before this change can be merged...
>
> I have that QA issue as warning not as error. I guess that's why my
> builds kept working :)
>
> Aside from that, what are your thoughts on this patch?
>
> regards,
>
> Koen
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>