Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 0/6 V3] refactor the archiver*.bbclass
Date: Fri, 21 Mar 2014 17:03:47 +0000	[thread overview]
Message-ID: <1395421427.24232.3.camel@ted> (raw)
In-Reply-To: <53231A33.8000800@windriver.com>

On Fri, 2014-03-14 at 23:03 +0800, Robert Yang wrote:
> 
> On 03/14/2014 01:45 AM, Burton, Ross wrote:
> > On 11 March 2014 17:08, Robert Yang <liezhi.yang@windriver.com> wrote:
> >> Robert Yang (6):
> >>    classes/archive*.bbclass: remove archive-*-source.bbclass
> >>    archiver.bbclass: refactor it
> >>    package_rpm.bbclass: archive the source to srpm package
> >>    archiver.bbclass: move a few code to copyleft_compliance.bbclass
> >>    local.conf.sample.extended: update for the archiver
> >>    patch.bbclass: do_patch: unset TMPDIR from environment
> >
> > This series appears to work for me and doesn't cause rebuilds (after
> > removing the patch change, as that obviously does).  Can anyone else
> > who actively uses the archiver verify that it still works for them?
> >
> 
> Thank you very much for the testing and suggestions, I've updated it
> a little:
> 
> * Remove the [PATCH 6/6] which is used for unset the TMPDIR, we can fix
>    it in another thread as bug 5968 describes since it doesn't affect the
>    archiver.
> 
> * Modified the do_ar_configured a little and tested the "bitbake
>    core-image-sato world meta-toolchain", it worked well.
> 
> Here is the repo: (the same repo as before)
> 
>    git://git.openembedded.org/openembedded-core-contrib rbt/archiver_v3
>  
> http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/archiver_v3
> 
> Robert Yang (5):
>    classes/archive*.bbclass: remove archive-*-source.bbclass
>    archiver.bbclass: refactor it
>    package_rpm.bbclass: archive the source to srpm package
>    archiver.bbclass: move a few code to copyleft_compliance.bbclass
>    local.conf.sample.extended: update for the archiver

I'm going to merge this into master (its queued in master-next for final
testing) but this is on the condition that we work on follow up patches
to the issues raised during review.

Cheers,

Richard



  reply	other threads:[~2014-03-21 17:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11 17:08 [PATCH 0/6 V3] refactor the archiver*.bbclass Robert Yang
2014-03-11 17:08 ` [PATCH 1/6] classes/archive*.bbclass: remove archive-*-source.bbclass Robert Yang
2014-03-11 17:08 ` [PATCH 2/6] archiver.bbclass: refactor it Robert Yang
2014-03-19 12:12   ` Paul Eggleton
2014-03-20  1:22     ` Robert Yang
2014-03-20  7:38     ` Robert Yang
2014-03-11 17:08 ` [PATCH 3/6] package_rpm.bbclass: archive the source to srpm package Robert Yang
2014-03-13 17:39   ` Burton, Ross
2014-03-14  2:14     ` Robert Yang
2014-03-14 10:59       ` Burton, Ross
2014-03-11 17:08 ` [PATCH 4/6] archiver.bbclass: move a few code to copyleft_compliance.bbclass Robert Yang
2014-03-19 12:09   ` Paul Eggleton
2014-03-20  1:18     ` Robert Yang
2014-03-11 17:08 ` [PATCH 5/6] local.conf.sample.extended: update for the archiver Robert Yang
2014-03-11 17:08 ` [PATCH 6/6] patch.bbclass: do_patch: unset TMPDIR from environment Robert Yang
2014-03-13 16:46   ` Burton, Ross
2014-03-13 16:54     ` Burton, Ross
2014-03-13 18:11       ` Chris Larson
2014-03-14 10:17       ` Robert Yang
2014-03-13 17:45 ` [PATCH 0/6 V3] refactor the archiver*.bbclass Burton, Ross
2014-03-14 15:03   ` Robert Yang
2014-03-21 17:03     ` Richard Purdie [this message]
2014-03-19 12:14 ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1395421427.24232.3.camel@ted \
    --to=richard.purdie@linuxfoundation.org \
    --cc=liezhi.yang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox