Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Robert Yang <liezhi.yang@windriver.com>
To: <openembedded-core@lists.openembedded.org>, <ross.burton@intel.com>
Subject: [PATCH 0/6 V3] refactor the archiver*.bbclass
Date: Wed, 12 Mar 2014 01:08:18 +0800	[thread overview]
Message-ID: <cover.1394555880.git.liezhi.yang@windriver.com> (raw)

=== V3:
* Do the unpack, patch and configure in another WORKDIR as RP and Ross
  suggested, so that it would not affact the default build dependencies,
  thanks for Ross' prototype.
* Don't archive the logs (temp/log.do*), mainly because of:
  - We can easily get the log via reset the T rather than use the
    archiver.
  - If we need archive the logs, we must let the task to run as the last
    one, but it's hard to do this.

=== V2:
* Fix the warning between different machines which is reported by Martin
* Fix the error when the archiver.bbclass is not inherited but
  ARCHIVER_MODE[type] = "srpm" is set, reported by Ross.
* Fix the archiving for gcc staff which uses the shared source according
  to the recently changes of prefuncs and postfuncs in bitbake, so it only
  works well with bitbake's up to date master branch, if we want to backport it,
  we also need backport the pre/postfuncs related patches.

=== V1:
* The archive*.bbclass didn't work, and there were a few problems, for
  example:
  1) There were a few duplicated code
  2) There was no src_dir.org (or orig), but the diff command still use
     it, and it is not easy to fix this issue if we don't change a lot
     of the code.
  3) It didn't archive the source for the native or gcc
  4) The work flow is not very well
  5) The "subprocess.call('fakeroot cp xxxx'" should be removed
  6) And others ...

* So that we have to refactor it, the benefits are:
  1) Fix the problems and make it work well.
  2) Reduce more than 400 lines in total.
  3) Make it easy to use.

// Robert


The following changes since commit 23f7decb84922a3467c5b10b013e66596926b5cf:

  .templateconf: New file for customized template defaults (2014-03-11 08:11:07 -0700)

are available in the git repository at:

  git://git.openembedded.org/openembedded-core-contrib rbt/archiver_v3
  http://cgit.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=rbt/archiver_v3

Robert Yang (6):
  classes/archive*.bbclass: remove archive-*-source.bbclass
  archiver.bbclass: refactor it
  package_rpm.bbclass: archive the source to srpm package
  archiver.bbclass: move a few code to copyleft_compliance.bbclass
  local.conf.sample.extended: update for the archiver
  patch.bbclass: do_patch: unset TMPDIR from environment

 meta/classes/archive-configured-source.bbclass |  65 --
 meta/classes/archive-original-source.bbclass   |  65 --
 meta/classes/archive-patched-source.bbclass    |  65 --
 meta/classes/archiver.bbclass                  | 791 +++++++++----------------
 meta/classes/copyleft_compliance.bbclass       |  55 +-
 meta/classes/package_rpm.bbclass               |  33 +-
 meta/classes/patch.bbclass                     |   1 +
 meta/conf/local.conf.sample.extended           |  63 +-
 8 files changed, 367 insertions(+), 771 deletions(-)
 delete mode 100644 meta/classes/archive-configured-source.bbclass
 delete mode 100644 meta/classes/archive-original-source.bbclass
 delete mode 100644 meta/classes/archive-patched-source.bbclass

-- 
1.8.3.1



             reply	other threads:[~2014-03-11 17:03 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11 17:08 Robert Yang [this message]
2014-03-11 17:08 ` [PATCH 1/6] classes/archive*.bbclass: remove archive-*-source.bbclass Robert Yang
2014-03-11 17:08 ` [PATCH 2/6] archiver.bbclass: refactor it Robert Yang
2014-03-19 12:12   ` Paul Eggleton
2014-03-20  1:22     ` Robert Yang
2014-03-20  7:38     ` Robert Yang
2014-03-11 17:08 ` [PATCH 3/6] package_rpm.bbclass: archive the source to srpm package Robert Yang
2014-03-13 17:39   ` Burton, Ross
2014-03-14  2:14     ` Robert Yang
2014-03-14 10:59       ` Burton, Ross
2014-03-11 17:08 ` [PATCH 4/6] archiver.bbclass: move a few code to copyleft_compliance.bbclass Robert Yang
2014-03-19 12:09   ` Paul Eggleton
2014-03-20  1:18     ` Robert Yang
2014-03-11 17:08 ` [PATCH 5/6] local.conf.sample.extended: update for the archiver Robert Yang
2014-03-11 17:08 ` [PATCH 6/6] patch.bbclass: do_patch: unset TMPDIR from environment Robert Yang
2014-03-13 16:46   ` Burton, Ross
2014-03-13 16:54     ` Burton, Ross
2014-03-13 18:11       ` Chris Larson
2014-03-14 10:17       ` Robert Yang
2014-03-13 17:45 ` [PATCH 0/6 V3] refactor the archiver*.bbclass Burton, Ross
2014-03-14 15:03   ` Robert Yang
2014-03-21 17:03     ` Richard Purdie
2014-03-19 12:14 ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1394555880.git.liezhi.yang@windriver.com \
    --to=liezhi.yang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross.burton@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox