From: Robert Yang <liezhi.yang@windriver.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 4/6] archiver.bbclass: move a few code to copyleft_compliance.bbclass
Date: Thu, 20 Mar 2014 09:18:11 +0800 [thread overview]
Message-ID: <532A41D3.3040605@windriver.com> (raw)
In-Reply-To: <1728094.yUuhkgzBIz@peggleto-mobl5.ger.corp.intel.com>
On 03/19/2014 08:09 PM, Paul Eggleton wrote:
> On Wednesday 12 March 2014 01:08:22 Robert Yang wrote:
>> Move the code which is only used by copyleft_compliance.bbclass from
>> archiver.bbclassc, and remove the "inherit archiver" from
>> copyleft_compliance.bbclass.
>>
>> The archiver.bbclass is used for archiving various types of sources, but
>> the copyleft_compliance.bbclass is used for analysing the license, they
>> don't have much relationships.
>>
>> [YOCTO #4986]
>> [YOCTO #5113]
>
> I can see the benefit of tidying this up, however I think it's still desirable
> for archiver.bbclass to have the ability to filter the recipes that it archives
> by LICENSE value, so that you can easily exclude archiving proprietary sources
> if you wish. At the moment it doesn't seem like there's an easy way even to
> disable archiving on an individual recipe basis.
>
Thanks, sounds reasonable, we can treat this as an enhancement, I notice
that it is already on master-next, how about we let them get merged atm?
And I will send another patch to fix it.
// Robert
> Cheers,
> Paul
>
next prev parent reply other threads:[~2014-03-20 1:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 17:08 [PATCH 0/6 V3] refactor the archiver*.bbclass Robert Yang
2014-03-11 17:08 ` [PATCH 1/6] classes/archive*.bbclass: remove archive-*-source.bbclass Robert Yang
2014-03-11 17:08 ` [PATCH 2/6] archiver.bbclass: refactor it Robert Yang
2014-03-19 12:12 ` Paul Eggleton
2014-03-20 1:22 ` Robert Yang
2014-03-20 7:38 ` Robert Yang
2014-03-11 17:08 ` [PATCH 3/6] package_rpm.bbclass: archive the source to srpm package Robert Yang
2014-03-13 17:39 ` Burton, Ross
2014-03-14 2:14 ` Robert Yang
2014-03-14 10:59 ` Burton, Ross
2014-03-11 17:08 ` [PATCH 4/6] archiver.bbclass: move a few code to copyleft_compliance.bbclass Robert Yang
2014-03-19 12:09 ` Paul Eggleton
2014-03-20 1:18 ` Robert Yang [this message]
2014-03-11 17:08 ` [PATCH 5/6] local.conf.sample.extended: update for the archiver Robert Yang
2014-03-11 17:08 ` [PATCH 6/6] patch.bbclass: do_patch: unset TMPDIR from environment Robert Yang
2014-03-13 16:46 ` Burton, Ross
2014-03-13 16:54 ` Burton, Ross
2014-03-13 18:11 ` Chris Larson
2014-03-14 10:17 ` Robert Yang
2014-03-13 17:45 ` [PATCH 0/6 V3] refactor the archiver*.bbclass Burton, Ross
2014-03-14 15:03 ` Robert Yang
2014-03-21 17:03 ` Richard Purdie
2014-03-19 12:14 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532A41D3.3040605@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox