[PATCH] kernelsrc.bbclass: Ensure fetch/unpack/patch tasks don't run

[PATCH] kernelsrc.bbclass: Ensure fetch/unpack/patch tasks don't run

[Richard Purdie]

In particular this removes a race condition where a ${S}/patches
directory could be created by do_unpack. This confuses kern-tools.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/classes/kernelsrc.bbclass b/meta/classes/kernelsrc.bbclass
index 11f04e9..4208eff 100644
--- a/meta/classes/kernelsrc.bbclass
+++ b/meta/classes/kernelsrc.bbclass
@@ -1,5 +1,8 @@
 S = "${STAGING_KERNEL_DIR}"
+do_fetch[noexec] = "1"
 do_unpack[depends] += "virtual/kernel:do_patch"
+do_unpack[noexec] = "1"
+do_patch[noexec] = "1"
 do_package[depends] += "virtual/kernel:do_populate_sysroot"
 KERNEL_VERSION = "${@get_kernelversion_file("${S}")}"
 

Re: [PATCH] kernelsrc.bbclass: Ensure fetch/unpack/patch tasks don't run

[Bruce Ashfield]

On 14-12-19 08:18 AM, Richard Purdie wrote:
> In particular this removes a race condition where a ${S}/patches
> directory could be created by do_unpack. This confuses kern-tools.

Looks good here. This will keep the dreaded 'patches' directory from 
popping up and mucking up the existing detection of meta data.

On a related note, I'll see about making things more robust on the
detection end as well.

Cheers,

Bruce

>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>
> diff --git a/meta/classes/kernelsrc.bbclass b/meta/classes/kernelsrc.bbclass
> index 11f04e9..4208eff 100644
> --- a/meta/classes/kernelsrc.bbclass
> +++ b/meta/classes/kernelsrc.bbclass
> @@ -1,5 +1,8 @@
>   S = "${STAGING_KERNEL_DIR}"
> +do_fetch[noexec] = "1"
>   do_unpack[depends] += "virtual/kernel:do_patch"
> +do_unpack[noexec] = "1"
> +do_patch[noexec] = "1"
>   do_package[depends] += "virtual/kernel:do_populate_sysroot"
>   KERNEL_VERSION = "${@get_kernelversion_file("${S}")}"
>
>
>