[PATCH] insane.bbclass: handle INSANE_SKIP for license-checksum

[PATCH] insane.bbclass: handle INSANE_SKIP for license-checksum

[Awais Belal]

The function populate_lic_qa_checksum() is used to do the
QA test for license-checksum but it does not handle the
scenario where a package adds license-checksum to its
INSANE_SKIP and hence fails in such condition.
This patch adds handling of INSANE_SKIP to the
populate_lic_qa_checksum() function so it returns
cleanly in such a scenario.

Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
 meta/classes/insane.bbclass | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/meta/classes/insane.bbclass b/meta/classes/insane.bbclass
index 2cb8cc0..719ecd4 100644
--- a/meta/classes/insane.bbclass
+++ b/meta/classes/insane.bbclass
@@ -697,6 +697,10 @@ python populate_lic_qa_checksum() {
     if lic == "CLOSED":
         return
 
+    if 'license-checksum' in (d.getVar('INSANE_SKIP_' + pn, True) or "").split():
+        bb.note("Skipping %s for license-checksum QA test", pn)
+        return
+
     if not lic_files and d.getVar('SRC_URI', True):
         package_qa_handle_error("license-checksum", pn + ": Recipe file fetches files and does not have license file information (LIC_FILES_CHKSUM)", d)
         return
-- 
1.9.1

Re: [PATCH] insane.bbclass: handle INSANE_SKIP for license-checksum

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

On 18 August 2016 at 13:37, Awais Belal <awais_belal@mentor.com> wrote:

> The function populate_lic_qa_checksum() is used to do the
> QA test for license-checksum but it does not handle the
> scenario where a package adds license-checksum to its
> INSANE_SKIP and hence fails in such condition.
> This patch adds handling of INSANE_SKIP to the
> populate_lic_qa_checksum() function so it returns
> cleanly in such a scenario.
>

Is that really a sanity check that we want to be skipping?  What's the use
case for this?

Ross

[-- Attachment #2: Type: text/html, Size: 962 bytes --]

Re: [PATCH] insane.bbclass: handle INSANE_SKIP for license-checksum

[Richard Purdie]

On Thu, 2016-08-18 at 17:37 +0500, Awais Belal wrote:
> The function populate_lic_qa_checksum() is used to do the
> QA test for license-checksum but it does not handle the
> scenario where a package adds license-checksum to its
> INSANE_SKIP and hence fails in such condition.
> This patch adds handling of INSANE_SKIP to the
> populate_lic_qa_checksum() function so it returns
> cleanly in such a scenario.

license-checksum is not per package. Its already handled based on
WARN_QA and ERROR_QA so I don't think we need to complicate this
further. You could for example set:

WARN_QA_remove_pn-XXX = "license-check"
ERROR_QA_remove_pn-XXX = "license-check"

Skipping license checksums is likely a bad idea anyway and not
something we want to make easier?

Cheers,

Richard