[PATCH 0/1] Fix corrupted path in startup.nsh for iso image

[PATCH 0/1] Fix corrupted path in startup.nsh for iso image

[Pranav Tipnis]

Hi,

startup.nsh for iso image has corrupted text because of echo command.
This patch switches to printf similar to the one submitted by
Christopher Larson for non-iso image.

Regards,
Pranav

Pranav Tipnis (1):
  grub-efi.bbclass: Fix path in startup.nsh for iso image.

 meta/classes/grub-efi.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
1.9.1

[PATCH 1/1] grub-efi.bbclass: Fix path in startup.nsh for iso image.

[Pranav Tipnis]

The path in startup.nsh for iso image is corrupted as follows:
fs0:\EFI\BOOT^Hootx64.efi

Using printf will emit correct path which is:
fs0:\EFI\BOOT\bootx64.efi

This happens because of echo command. Switching to printf
like the one used in efi_populate() function.

Signed-off-by: Pranav Tipnis <pranav.tipnis@intel.com>
---
 meta/classes/grub-efi.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes/grub-efi.bbclass b/meta/classes/grub-efi.bbclass
index ae8ee38..178d0c8 100644
--- a/meta/classes/grub-efi.bbclass
+++ b/meta/classes/grub-efi.bbclass
@@ -59,7 +59,7 @@ efi_iso_populate() {
 	cp $iso_dir/${EFIDIR}/* ${EFIIMGDIR}${EFIDIR}
 	cp $iso_dir/vmlinuz ${EFIIMGDIR}
 	EFIPATH=$(echo "${EFIDIR}" | sed 's/\//\\/g')
-	echo "fs0:${EFIPATH}\\${GRUB_IMAGE}" > ${EFIIMGDIR}/startup.nsh
+	printf 'fs0:%s\%s\n' "$EFIPATH" "$GRUB_IMAGE" > ${EFIIMGDIR}/startup.nsh
 	if [ -f "$iso_dir/initrd" ] ; then
 		cp $iso_dir/initrd ${EFIIMGDIR}
 	fi
-- 
1.9.1

Re: [PATCH 1/1] grub-efi.bbclass: Fix path in startup.nsh for iso image.

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]


> On Aug 19, 2016, at 6:28 PM, Pranav Tipnis <pranav.tipnis@intel.com> wrote:
> 
> The path in startup.nsh for iso image is corrupted as follows:
> fs0:\EFI\BOOT^Hootx64.efi
> 
> Using printf will emit correct path which is:
> fs0:\EFI\BOOT\bootx64.efi
> 
> This happens because of echo command. Switching to printf
> like the one used in efi_populate() function.

This patch is ok

> 
> Signed-off-by: Pranav Tipnis <pranav.tipnis@intel.com>
> ---
> meta/classes/grub-efi.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/classes/grub-efi.bbclass b/meta/classes/grub-efi.bbclass
> index ae8ee38..178d0c8 100644
> --- a/meta/classes/grub-efi.bbclass
> +++ b/meta/classes/grub-efi.bbclass
> @@ -59,7 +59,7 @@ efi_iso_populate() {
> 	cp $iso_dir/${EFIDIR}/* ${EFIIMGDIR}${EFIDIR}
> 	cp $iso_dir/vmlinuz ${EFIIMGDIR}
> 	EFIPATH=$(echo "${EFIDIR}" | sed 's/\//\\/g')
> -	echo "fs0:${EFIPATH}\\${GRUB_IMAGE}" > ${EFIIMGDIR}/startup.nsh
> +	printf 'fs0:%s\%s\n' "$EFIPATH" "$GRUB_IMAGE" > ${EFIIMGDIR}/startup.nsh
> 	if [ -f "$iso_dir/initrd" ] ; then
> 		cp $iso_dir/initrd ${EFIIMGDIR}
> 	fi
> --
> 1.9.1
> 
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #2: Message signed with OpenPGP using GPGMail --]
[-- Type: application/pgp-signature, Size: 211 bytes --]