[PATCH 1/2] aws-cli_1.11.66.bb: Initial commit of aws-cli

[PATCH 1/2] aws-cli_1.11.66.bb: Initial commit of aws-cli

[Elizabeth 'pidge' Flanagan]

With fetch2 supporting s3, having an aws-cli recipe makes sense.

Signed-off-by: Elizabeth 'pidge' Flanagan <pidge@toganlabs.com>
---
 meta/recipes-devtools/aws-cli/aws-cli.inc        | 14 ++++++++++++++
 meta/recipes-devtools/aws-cli/aws-cli_1.11.66.bb |  5 +++++
 2 files changed, 19 insertions(+)
 create mode 100644 meta/recipes-devtools/aws-cli/aws-cli.inc
 create mode 100644 meta/recipes-devtools/aws-cli/aws-cli_1.11.66.bb

diff --git a/meta/recipes-devtools/aws-cli/aws-cli.inc b/meta/recipes-devtools/aws-cli/aws-cli.inc
new file mode 100644
index 0000000..e9a2677
--- /dev/null
+++ b/meta/recipes-devtools/aws-cli/aws-cli.inc
@@ -0,0 +1,14 @@
+SUMMARY = "Amazon Web Services Command Line Interface"
+DESCRIPTION = "The AWS Command Line Interface (CLI) is a \
+unified tool to manage your AWS services." 
+HOMEPAGE = "https://aws.amazon.com/cli/"
+SECTION = "console/utils"
+
+SRC_URI = "https://github.com/aws/${BPN}/archive/${PV}.tar.gz"
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=71a3e14f29ac5c23e1b5b934ca4ddfc9"
+
+S = "${WORKDIR}/${BPN}-${PV}"
+
+BBCLASSEXTEND = "native nativesdk"
diff --git a/meta/recipes-devtools/aws-cli/aws-cli_1.11.66.bb b/meta/recipes-devtools/aws-cli/aws-cli_1.11.66.bb
new file mode 100644
index 0000000..a96b71e
--- /dev/null
+++ b/meta/recipes-devtools/aws-cli/aws-cli_1.11.66.bb
@@ -0,0 +1,5 @@
+require aws-cli.inc
+
+SRC_URI[md5sum] = "c556adb58d0234eb661520488b9b467f"
+SRC_URI[sha256sum] = "2c1da406203e0a9b5c717004bd463228e4fa4fa8fe47208f0e1836c02bee6f60"
+
-- 
1.9.1

[PATCH 2/2] bitbake.conf: Add aws-cli support

[Elizabeth 'pidge' Flanagan]

This commit adds aws-cli support to bitbake in order to support
the s3 fetcher in bitbake.

Signed-off-by: Elizabeth 'pidge' Flanagan <pidge@toganlabs.com>
---
 meta/conf/bitbake.conf | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index fa5445b..f21b8d3 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -458,8 +458,8 @@ HOSTTOOLS += " \
     bash sh cut sed gcc ld git rm install which find xargs cat true mktemp \
     grep tar gzip touch cp mv basename dirname tr getopt sort awk head tail \
     mkdir patch uniq perl python chmod python3 ar strip expr ls make as \
-    ranlib egrep echo chown cpio tee wc wget bzip2 stat date rmdir od diff \
-    md5sum dd chrpath file pod2man gunzip python2.7 ln g++ [ false true \
+    ranlib egrep echo chown cpio tee wc wget aws bzip2 stat date rmdir \
+    od diff md5sum dd chrpath file pod2man gunzip python2.7 ln g++ [ false true \
     uname test hostname nm objdump objcopy cmp printf env readlink gawk fgrep \
     expand pwd sleep diffstat chgrp flock ldd strings rpcgen du makeinfo \
     getconf mknod cpp readelf split \
@@ -640,6 +640,7 @@ FETCHCMD_cvs = "/usr/bin/env cvs"
 FETCHCMD_wget = "/usr/bin/env wget -t 2 -T 30 -nv --passive-ftp --no-check-certificate"
 FETCHCMD_bzr = "/usr/bin/env bzr"
 FETCHCMD_hg = "/usr/bin/env hg"
+FETCHCMD_s3 = "/usr/bin/env aws s3"
 
 SRCDATE = "${DATE}"
 SRCREV ??= "INVALID"
-- 
1.9.1

Re: [PATCH 2/2] bitbake.conf: Add aws-cli support

[Richard Purdie]

On Tue, 2017-03-28 at 13:40 +0200, Elizabeth 'pidge' Flanagan wrote:
> This commit adds aws-cli support to bitbake in order to support
> the s3 fetcher in bitbake.
> 
> Signed-off-by: Elizabeth 'pidge' Flanagan <pidge@toganlabs.com>
> ---
>  meta/conf/bitbake.conf | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index fa5445b..f21b8d3 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -458,8 +458,8 @@ HOSTTOOLS += " \
>      bash sh cut sed gcc ld git rm install which find xargs cat true mktemp \
>      grep tar gzip touch cp mv basename dirname tr getopt sort awk head tail \
>      mkdir patch uniq perl python chmod python3 ar strip expr ls make as \
> -    ranlib egrep echo chown cpio tee wc wget bzip2 stat date rmdir od diff \
> -    md5sum dd chrpath file pod2man gunzip python2.7 ln g++ [ false true \
> +    ranlib egrep echo chown cpio tee wc wget aws bzip2 stat date rmdir \
> +    od diff md5sum dd chrpath file pod2man gunzip python2.7 ln g++ [ false true \
>      uname test hostname nm objdump objcopy cmp printf env readlink gawk fgrep \
>      expand pwd sleep diffstat chgrp flock ldd strings rpcgen du makeinfo \
>      getconf mknod cpp readelf split \

Adding to HOSTTOOLS means *all* systems have to have this available
else the build fails. This for example would breaks all our
autobuilders. Past feature freeze point this tends to upset me a bit
even more than usual.

You want to add this to HOSTTOOLS_NONFATAL below.

Your patch also doesn't apply against master either.

Cheers,

Richard

✗ patchtest: failure for "aws-cli_1.11.66.bb: Initial co..." and 1 more

[Patchwork]

== Series Details ==

Series: "aws-cli_1.11.66.bb: Initial co..." and 1 more
Revision: 1
URL   : https://patchwork.openembedded.org/series/6019/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Issue             Series does not apply on top of target branch [test_series_merge_on_head] 
  Suggested fix    Rebase your series on top of targeted branch
  Targeted branch  master (currently at d68a86d87a)



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [PATCH 1/2] aws-cli_1.11.66.bb: Initial commit of aws-cli

[Andre McCurdy]

On Tue, Mar 28, 2017 at 4:40 AM, Elizabeth 'pidge' Flanagan
<pidge@toganlabs.com> wrote:
> With fetch2 supporting s3, having an aws-cli recipe makes sense.
>
> Signed-off-by: Elizabeth 'pidge' Flanagan <pidge@toganlabs.com>
> ---
>  meta/recipes-devtools/aws-cli/aws-cli.inc        | 14 ++++++++++++++
>  meta/recipes-devtools/aws-cli/aws-cli_1.11.66.bb |  5 +++++
>  2 files changed, 19 insertions(+)
>  create mode 100644 meta/recipes-devtools/aws-cli/aws-cli.inc
>  create mode 100644 meta/recipes-devtools/aws-cli/aws-cli_1.11.66.bb
>
> diff --git a/meta/recipes-devtools/aws-cli/aws-cli.inc b/meta/recipes-devtools/aws-cli/aws-cli.inc
> new file mode 100644
> index 0000000..e9a2677
> --- /dev/null
> +++ b/meta/recipes-devtools/aws-cli/aws-cli.inc
> @@ -0,0 +1,14 @@
> +SUMMARY = "Amazon Web Services Command Line Interface"
> +DESCRIPTION = "The AWS Command Line Interface (CLI) is a \
> +unified tool to manage your AWS services."
> +HOMEPAGE = "https://aws.amazon.com/cli/"
> +SECTION = "console/utils"
> +
> +SRC_URI = "https://github.com/aws/${BPN}/archive/${PV}.tar.gz"
> +
> +LICENSE = "Apache-2.0"
> +LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=71a3e14f29ac5c23e1b5b934ca4ddfc9"

According to the style guide, LICENSE should come before SRC_URI.

> +
> +S = "${WORKDIR}/${BPN}-${PV}"

That's the default.

> +
> +BBCLASSEXTEND = "native nativesdk"
> diff --git a/meta/recipes-devtools/aws-cli/aws-cli_1.11.66.bb b/meta/recipes-devtools/aws-cli/aws-cli_1.11.66.bb
> new file mode 100644
> index 0000000..a96b71e
> --- /dev/null
> +++ b/meta/recipes-devtools/aws-cli/aws-cli_1.11.66.bb
> @@ -0,0 +1,5 @@
> +require aws-cli.inc

Ross has been merging single use .inc files into their respective
recipes. Not sure if we should be creating new ones.

> +SRC_URI[md5sum] = "c556adb58d0234eb661520488b9b467f"
> +SRC_URI[sha256sum] = "2c1da406203e0a9b5c717004bd463228e4fa4fa8fe47208f0e1836c02bee6f60"
> +
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core