Re: [PATCH] autogen-native: allow user to set POSIX_SHELL as desired

["Belal, Awais" <Awais_Belal@mentor.com>]

> That's right. The file is generated from libopts.def in the same
> directory. I now looked at the code finally :) and I think it's better
> to leave the POSIX_SHELL variable alone (and not set it from the recipe
> either because it has no effect), and go back to the original idea of
> patching the place where it's used to make a shebang line - I think
> there's only one such place in the source code.

> But fixing libopts.def is okay too, I just think it's more trouble.

The usage of libopts.def has been deprecated upstream: git://git.sv.gnu.org/autogen.git # 5cbe233387d7f7b36752736338d1cd4f71287daa but they've still kept libopts.m4 so I think this patch will do for future use as well and shouldn't have a problem.

BR,
Awais

________________________________________
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
Sent: Thursday, May 18, 2017 1:36 PM
To: Robert Yang; Belal, Awais; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] autogen-native: allow user to set POSIX_SHELL as desired

On 05/18/2017 10:23 AM, Robert Yang wrote:
>> +-      test -x "$POSIX_SHELL" && break
>> ++      test -n "$POSIX_SHELL" && break
>
> The problem is libopts.m4 is auto generated, so it may override
> when upgrade autogen-native.

That's right. The file is generated from libopts.def in the same
directory. I now looked at the code finally :) and I think it's better
to leave the POSIX_SHELL variable alone (and not set it from the recipe
either because it has no effect), and go back to the original idea of
patching the place where it's used to make a shebang line - I think
there's only one such place in the source code.

But fixing libopts.def is okay too, I just think it's more trouble.

Alex