From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Robert Yang <liezhi.yang@windriver.com>,
Awais Belal <awais_belal@mentor.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] autogen-native: allow user to set POSIX_SHELL as desired
Date: Thu, 18 May 2017 11:36:44 +0300 [thread overview]
Message-ID: <a577a0c9-e1df-a657-a00b-4c5cd69c4609@linux.intel.com> (raw)
In-Reply-To: <62e4fbc9-931b-d0dd-e71b-99002495c32e@windriver.com>
On 05/18/2017 10:23 AM, Robert Yang wrote:
>> +- test -x "$POSIX_SHELL" && break
>> ++ test -n "$POSIX_SHELL" && break
>
> The problem is libopts.m4 is auto generated, so it may override
> when upgrade autogen-native.
That's right. The file is generated from libopts.def in the same
directory. I now looked at the code finally :) and I think it's better
to leave the POSIX_SHELL variable alone (and not set it from the recipe
either because it has no effect), and go back to the original idea of
patching the place where it's used to make a shebang line - I think
there's only one such place in the source code.
But fixing libopts.def is okay too, I just think it's more trouble.
Alex
next prev parent reply other threads:[~2017-05-18 8:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 6:50 [PATCH] autogen-native: allow user to set POSIX_SHELL as desired Awais Belal
2017-05-18 7:23 ` Robert Yang
2017-05-18 8:36 ` Alexander Kanavin [this message]
2017-05-18 11:23 ` Belal, Awais
2017-05-18 12:32 ` Alexander Kanavin
2017-05-18 13:20 ` Belal, Awais
2017-05-18 13:24 ` Alexander Kanavin
2017-05-18 14:24 ` Belal, Awais
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a577a0c9-e1df-a657-a00b-4c5cd69c4609@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=awais_belal@mentor.com \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox