Re: [PATCH] autogen-native: allow user to set POSIX_SHELL as desired

["Belal, Awais" <Awais_Belal@mentor.com>]

> I just checked why is autogen in oe-core in the first place. The only
> thing that needs it now is grub, and it will no longer be necessary when
> Khem's grub 2.02 patch shows up in master. So then we can remove the
> whole thing. But thanks for fixing! :)

I went through Khem's grub2 changes: http://cgit.openembedded.org/openembedded-core-contrib/commit/?h=kraj/master&id=0af89270aa83d6ad0a4859e18643b53191567c8b and in those changes the grub2.inc still reads

DEPENDS = "flex-native bison-native autogen-native"

So I think this can be valuable :)

BR,
Awais

________________________________________
From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
Sent: Thursday, May 18, 2017 5:32 PM
To: Belal, Awais; Robert Yang; openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] autogen-native: allow user to set POSIX_SHELL as desired

On 05/18/2017 02:23 PM, Belal, Awais wrote:
>> That's right. The file is generated from libopts.def in the same
>> directory. I now looked at the code finally :) and I think it's
>> better to leave the POSIX_SHELL variable alone (and not set it from
>> the recipe either because it has no effect), and go back to the
>> original idea of patching the place where it's used to make a
>> shebang line - I think there's only one such place in the source
>> code.
>
>> But fixing libopts.def is okay too, I just think it's more
>> trouble.
>
> The usage of libopts.def has been deprecated upstream:
> git://git.sv.gnu.org/autogen.git #
> 5cbe233387d7f7b36752736338d1cd4f71287daa but they've still kept
> libopts.m4 so I think this patch will do for future use as well and
> shouldn't have a problem.

I just checked why is autogen in oe-core in the first place. The only
thing that needs it now is grub, and it will no longer be necessary when
Khem's grub 2.02 patch shows up in master. So then we can remove the
whole thing. But thanks for fixing! :)

Alex