Re: [PATCH v2] runtime/dnf: Add new dnf test cases

[Jose Perez Carranza <jose.perez.carranza@linux.intel.com>]

On 05/11/2017 01:56 PM, Alexander Kanavin wrote:
> On 05/11/2017 08:33 PM, jose.perez.carranza@linux.intel.com wrote:
>> +    def test_dnf_exclude(self):
>> +        excludepkg = 'curl-dev'
>> +        self.dnf('list %s' % excludepkg, 0)
>> +        self.dnf_with_repo('remove -y curl')
>> +        self.dnf_with_repo('install -y --exclude=%s curl' % excludepkg)
>> +        self.dnf('list %s' % excludepkg, 1)
>
> 1) Why is curl-dev already installed when the test starts? Will that 
> be always the case?
Will add logic to validate if curl is not installed then not try to 
remove it and go directly to test --exclude option
>
> 2) I still don't understand how the test works. You are asking for 
> curl to be installed and curl-dev to be excluded, but curl-dev would 
> not be installed regardless of --exclude option, because curl does not 
> depend on it. You need to test a situation where --exclude makes a 
> difference, and check that there is indeed a difference.
curl-dev is always installed with curl as a weak dependency, so every 
time you install or remove curl also curl-dev is affected, hence this 
test validate that --exclude option is working correctly by checking 
that curl-dev (weak dependency) is not installed,
>
> Alex
>

-- 
Saludos
José