Re: [PATCH] runtime/dnf: Add new dnf test cases

[Alexander Kanavin <alexander.kanavin@linux.intel.com>]

On 05/10/2017 10:38 PM, jose.perez.carranza@linux.intel.com wrote:
> +    def test_dnf_installroot(self):
> +        rootpath = '/home/root/chroot/test'
> +        self.dnf_with_repo('install --installroot=%s --allowerasing -v -y busybox run-postinsts' % rootpath)
> +        status, output = self.target.run('test -e %s/var/cache/dnf' % rootpath, 1500)
> +        self.assertEqual(0, status, output)

You could also check there that the files from installed packages are 
indeed there (e.g. /home/root/chroot/test/bin/sh and such). Just in case. :)

> +    def test_dnf_exclude(self):
> +        excludepkg = 'run-postinsts-dev'
> +        self.dnf_with_repo('remove -y run-postinsts')
> +        self.dnf_with_repo('install -y --exclude=%s run-postinsts' % excludepkg)
> +        self.dnf('list %s' % excludepkg, 1)

How does this test work? I do not understand. First run-postinsts is 
removed, then it is installed again with --exclude=run-postinsts-dev, 
then we check that run-postinst-dev is not installed. Would it have been 
installed without the --exclude option? Why, if we're only asking for 
run-postinsts?

If it would, should you test that it does indeed happen, to make sure 
there is indeed a difference in the outcome when --exclude is present 
and absent?

Alex