From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: jose.perez.carranza@linux.intel.com,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH v2] runtime/dnf: Add new dnf test cases
Date: Thu, 11 May 2017 21:56:27 +0300 [thread overview]
Message-ID: <a5c78ee6-8320-7508-18d1-16762bed364c@linux.intel.com> (raw)
In-Reply-To: <20170511173303.26995-1-jose.perez.carranza@linux.intel.com>
On 05/11/2017 08:33 PM, jose.perez.carranza@linux.intel.com wrote:
> + def test_dnf_exclude(self):
> + excludepkg = 'curl-dev'
> + self.dnf('list %s' % excludepkg, 0)
> + self.dnf_with_repo('remove -y curl')
> + self.dnf_with_repo('install -y --exclude=%s curl' % excludepkg)
> + self.dnf('list %s' % excludepkg, 1)
1) Why is curl-dev already installed when the test starts? Will that be
always the case?
2) I still don't understand how the test works. You are asking for curl
to be installed and curl-dev to be excluded, but curl-dev would not be
installed regardless of --exclude option, because curl does not depend
on it. You need to test a situation where --exclude makes a difference,
and check that there is indeed a difference.
Alex
next prev parent reply other threads:[~2017-05-11 18:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 19:38 [PATCH] runtime/dnf: Add new dnf test cases jose.perez.carranza
2017-05-10 19:52 ` Alexander Kanavin
2017-05-11 17:33 ` [PATCH v2] " jose.perez.carranza
2017-05-11 18:56 ` Alexander Kanavin [this message]
2017-05-11 19:21 ` Jose Perez Carranza
2017-05-15 13:50 ` [PATCH v3] " jose.perez.carranza
2017-06-07 10:21 ` Burton, Ross
2017-06-07 17:31 ` Jose Perez Carranza
2017-06-08 11:31 ` Alexander Kanavin
2017-06-08 12:49 ` Jose Perez Carranza
2017-06-08 12:49 ` Alexander Kanavin
2017-06-08 13:11 ` Jose Perez Carranza
2017-06-08 16:35 ` Alexander Kanavin
2017-06-09 9:22 ` Alexander Kanavin
2017-06-09 12:54 ` Jose Perez Carranza
2017-06-13 19:56 ` [PATCH v4] " jose.perez.carranza
2017-06-14 12:00 ` Alexander Kanavin
2017-06-14 12:32 ` Jose Perez Carranza
2017-11-30 16:23 ` [PATCH v5] " jose.perez.carranza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5c78ee6-8320-7508-18d1-16762bed364c@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=jose.perez.carranza@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox