public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: "Valek, Andrej" <andrej.valek@siemens.com>,
	"armccurdy@gmail.com" <armccurdy@gmail.com>,
	"steve@sakoman.com" <steve@sakoman.com>
Cc: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	"raj.khem@gmail.com" <raj.khem@gmail.com>
Subject: Re: [OE-core][PATCH] vim: add option to disable NLS support
Date: Thu, 26 Aug 2021 11:59:24 +0100	[thread overview]
Message-ID: <1b35875da7fb3481400f09bcefd532be90d098cf.camel@linuxfoundation.org> (raw)
In-Reply-To: <452907b1c72251c6a445882c7dea2ea2dc1b913e.camel@siemens.com>

On Thu, 2021-08-26 at 09:58 +0000, Valek, Andrej wrote:
> Hello,
> 
> Is there any problem, which should I fix?
> I would like to include this feature into dunfell if possible.

Autotools usually has a very specific option format and this isn't following it.
I know others expressed some surprise and I share that. It can happen if the
software is doing something unusual so it is possible but I wanted to go and
double check this as it looks odd. It may be both formats can be used and if
that were the case, I'd much prefer we used the standard format we use
everywhere else.

So basically this is held pending me doing some due diligence as it worries me.
I am however struggling to do everything needed at the moment.

The other issue is that nls is an option many other recipes have but we've
always handled it at the core level in the gettext bbclass. native recipes
explictly pass --disable-nls for example.

I also wanted to check if the recipe uses the gextext class (or should?) and if
instead we should be exposing the PACKAGECONFIG differently through that class.

Cheers,

Richard


  reply	other threads:[~2021-08-26 10:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 10:12 [OE-core][PATCH] vim: add option to disable NLS support Andrej Valek
2021-08-23 11:23 ` [OE-core][PATCH v2] busybox: 1.33.1 -> 1.34.0 Andrej Valek
2021-08-23 16:12 ` [OE-core][PATCH] vim: add option to disable NLS support Khem Raj
2021-08-23 17:12   ` Andrej Valek
2021-08-23 22:14     ` Andre McCurdy
2021-08-24  6:56       ` Andrej Valek
2021-08-26  9:58         ` Andrej Valek
2021-08-26 10:59           ` Richard Purdie [this message]
2021-08-26 11:24             ` Andrej Valek
2021-08-26 12:00               ` Richard Purdie
2021-08-26 13:15 ` [OE-core][PATCH v2] " Andrej Valek
2021-09-01 19:04   ` Andrej Valek
2021-09-01 22:35     ` Steve Sakoman
2021-09-08  7:49       ` Andrej Valek
2021-09-08 14:26         ` Steve Sakoman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1b35875da7fb3481400f09bcefd532be90d098cf.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=andrej.valek@siemens.com \
    --cc=armccurdy@gmail.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=raj.khem@gmail.com \
    --cc=steve@sakoman.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox