Re: [OE-core][PATCH] vim: add option to disable NLS support

["Andrej Valek" <andrej.valek@siemens.com>]

Hello,

Is there any problem, which should I fix?
I would like to include this feature into dunfell if possible.

Thanks,
Andrej

On Tue, 2021-08-24 at 06:56 +0000, Valek, Andrej (ADV D EU SK SI-BP1)
wrote:
> Hi all,
> 
> Of course, that I tried it and it works.
> ...
> configure.ac:4517: You should run autoupdate.
> NOTE: Running ./configure  --build=x86_64-linux --host=x86_64-poky-
> linux ... --disable-static  enable_acl=yes --enable-gui=gtk3
> enable_nls=yes --disable-selinux --with-features=big --with-x 
> configure: WARNING: unrecognized options: --disable-silent-rules, --
> disable-dependency-tracking, --with-libtool-sysroot, --disable-static
> configure: loading site script /home/projects/yocto/qemux86-
> 64/layers/build/meta/site/endian-little
> configure: loading site script /home/projects/yocto/qemux86-
> 64/layers/build/meta/site/common-linux
> ...
> checking how to run man with a section nr... man
> checking --disable-nls argument... no
> checking for msgfmt... msgfmt
> checking for NLS... gettext() works
> checking for bind_textdomain_codeset... yes
> ...
> 
> So does it mean, that I should use the --enable instead anyway?
> 
> Andrej
> 
> > On Mon, Aug 23, 2021 at 10:12 AM Andrej Valek
> > <andrej.valek@siemens.com> wrote:
> > > 
> > > Hello Khem,
> > > 
> > > I looked exactly into configure.ac which arguments are expecting
> > > for those options. So I think, it has to be mentioned explicitly.
> > 
> > Assuming configure.ac is based around AC_ARG_ENABLE / AC_ARG_WITH
> > then an explicit option is not required. A default value of "yes"
> > will be set for --enable-foo / --with-foo and a default value of
> > "no" will be set for --disable-foo / --without-foo.
> > 
> > However, apart from that, you've also dropped the leaving "--" from
> > various --enable-foo options and converted dashes to underscores,
> > all of which looks wrong. How were the changes tested?
> > 
> > > Regards,
> > > Andrej
> > > 
> > > > On 8/23/21 3:12 AM, Andrej Valek wrote:
> > > > > - Some distributions with UTF-8 locale have problem when
> > > > > National Language
> > > > >   Support is enabled. Add there an option to disable it.
> > > > > - refresh options based on configure.ac
> > > > > 
> > > > > Signed-off-by: Andrej Valek <andrej.valek@siemens.com>
> > > > > ---
> > > > >   meta/recipes-support/vim/vim.inc | 8 +++++---
> > > > >   1 file changed, 5 insertions(+), 3 deletions(-)
> > > > > 
> > > > > diff --git a/meta/recipes-support/vim/vim.inc
> > > > > b/meta/recipes-support/vim/vim.inc
> > > > > index 17d1c24a7c..7cc47884f2 100644
> > > > > --- a/meta/recipes-support/vim/vim.inc
> > > > > +++ b/meta/recipes-support/vim/vim.inc
> > > > > @@ -54,19 +54,21 @@ do_compile() {
> > > > >       autotools_do_compile
> > > > >   }
> > > > > 
> > > > > -#Available PACKAGECONFIG options are gtkgui, acl, x11, tiny
> > > > > +selinux, elfutils, nls
> > > > >   PACKAGECONFIG ??= ""
> > > > >   PACKAGECONFIG += " \
> > > > >       ${@bb.utils.filter('DISTRO_FEATURES', 'acl selinux',
> > > > > d)} \
> > > > >       ${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'x11
> > > > > gtkgui', 
> > > > > '', d)} \
> > > > > +    nls \
> > > > >   "
> > > > > 
> > > > >   PACKAGECONFIG[gtkgui] = "--enable-gui=gtk3,--enable-
> > > > > gui=no,gtk+3"
> > > > > -PACKAGECONFIG[acl] = "--enable-acl,--disable-acl,acl,"
> > > > > +PACKAGECONFIG[acl] = "enable_acl="yes",--disable-acl,acl,"
> > > > 
> > > > is 'yes' needed to be explicit ? I thought --enable-XYZ meant
> > > > it 
> > > > implicitly
> > > > 
> > > > >   PACKAGECONFIG[x11] = "--with-x,--without-x,xt,"
> > > > >   PACKAGECONFIG[tiny] = "--with-features=tiny,--with-
> > > > > features=big,,"
> > > > > -PACKAGECONFIG[selinux] = "--enable-selinux,--disable-
> > > > > selinux,libselinux,"
> > > > > +PACKAGECONFIG[selinux] = "enable_selinux="yes",--disable-
> > > > > selinux,libselinux,"
> > > > >   PACKAGECONFIG[elfutils] = "--enable-elf-check,,elfutils,"
> > > > > +PACKAGECONFIG[nls] = "enable_nls="yes",--disable-nls,,"
> > > > > 
> > > > >   EXTRA_OECONF = " \
> > > > >       --disable-gpm \
> > > 
> > > 
> > >