Re: [OE-core][PATCH] vim: add option to disable NLS support

["Richard Purdie" <richard.purdie@linuxfoundation.org>]

On Thu, 2021-08-26 at 11:24 +0000, Valek, Andrej wrote:
> Hello Richard,
> 
> If it isn't a big deal, I can use the "--enable" variant. If we keep --
> enable-nls like a default, we will brake nothing I guess. (It's enabled
> by default anyway). So I'm adding there only a feature to disable it
> with PACKAGEOPTION.

Yes, lets use --enable please since that is the way the rest of the world/code 
works.

I'm a bit worried about the nls option since the recipe does have BBCLASSEXTEND
for native/nativesdk and we do disable nls for native by default. As you say,
the patch probably doesn't change anything but it is a bit of an oddity.

The code does look to be using gettext and there is a gettext-native dependency
but the recipe does not use the gettext class. Why? Not sure.

I'll put the patch in for testing if we can use the standard format though
(which should work since I checked and configure is using the standard autoconf
macros).

Cheers,

Richard