From: Martin Jansa <martin.jansa@gmail.com>
To: Darren Hart <dvhart@linux.intel.com>
Cc: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/1] create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://'
Date: Fri, 3 Jun 2011 08:03:34 +0200 [thread overview]
Message-ID: <20110603060334.GK3281@jama.jama.net> (raw)
In-Reply-To: <4DE87343.6010209@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1317 bytes --]
On Thu, Jun 02, 2011 at 10:38:11PM -0700, Darren Hart wrote:
> Hi Martin,
Hi Darren,
> No objection if this is a valid URL. I didn't include this because 1) I
> didn't know about it and 2) it isn't listed in the git pull man page,
> which is what I developed to. Is git+ssh... equivalent to ssh:// ?
before this change my pull requests had url like this
are available in the git repository at:
git+ssh://git@git.openembedded.org/meta-openembedded-contrib jansa/meta-oe
http://cgit.openembedded.org/cgit.cgi/git+ssh://git@git.openembedded.org/meta-openembedded-contrib/log/?h=jansa/meta-oe
because RE wasn't matching my URL at all
OE @ ~/shr-core/openembedded-core $ git config remote.contrib.url
git+ssh://git@git.openembedded.org/openembedded-core-contrib
IMHO this is equivalent to ssh:// or git@ without protocol but haven't
checked documentation to be sure. But I'm sure this is valid and that
this works right (as I'm able to push to contrib).
> As a minor nit, please include a body message for anything more
> complicated than whitespace or typographical fixes.
I use git+ssh:// for many projects so I'm used to it, so I expected that
this is widely used and this patch would be clear enough.
Regards,
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Type: application/pgp-signature, Size: 205 bytes --]
next prev parent reply other threads:[~2011-06-03 6:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 15:48 [PATCH 0/1] Small create-pull-request fix Martin Jansa
2011-05-31 15:48 ` [PATCH 1/1] create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://' Martin Jansa
2011-06-03 5:38 ` Darren Hart
2011-06-03 6:03 ` Martin Jansa [this message]
2011-06-03 6:40 ` Darren Hart
2011-06-03 0:05 ` [PATCH 0/1] Small create-pull-request fix Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110603060334.GK3281@jama.jama.net \
--to=martin.jansa@gmail.com \
--cc=dvhart@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox