Re: [PATCH 1/1] create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://'

[Darren Hart <dvhart@linux.intel.com>]

Hi Martin,

No objection if this is a valid URL. I didn't include this because 1) I
didn't know about it and 2) it isn't listed in the git pull man page,
which is what I developed to. Is git+ssh... equivalent to ssh:// ?

As a minor nit, please include a body message for anything more
complicated than whitespace or typographical fixes.

Thanks,

--
Darren

On 05/31/2011 08:48 AM, Martin Jansa wrote:
> Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
> ---
>  scripts/create-pull-request |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/scripts/create-pull-request b/scripts/create-pull-request
> index 19b640f..d52098e 100755
> --- a/scripts/create-pull-request
> +++ b/scripts/create-pull-request
> @@ -102,7 +102,7 @@ while getopts "b:chi:m:o:p:r:s:u:" OPT; do
>  		case "$REMOTE_URL" in
>  		*@*)
>  			USER_RE="[A-Za-z0-9_.@][A-Za-z0-9_.@-]*\$\?"
> -			PROTO_RE="[a-z][a-z]*://"
> +			PROTO_RE="[a-z][a-z+]*://"
>  			GIT_RE="\(^\($PROTO_RE\)\?$USER_RE@\)\([^:/]*\)[:/]\(.*\)"
>  			REMOTE_URL=${REMOTE_URL%.git}
>  			REMOTE_REPO=$(echo $REMOTE_URL | sed "s#$GIT_RE#\4#")

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel