Re: [PATCH 1/1] create-pull-request: allow '+' in git PROTO_RE, ie for 'git+ssh://'

[Darren Hart <dvhart@linux.intel.com>]

On 06/02/2011 11:03 PM, Martin Jansa wrote:
> On Thu, Jun 02, 2011 at 10:38:11PM -0700, Darren Hart wrote:
>> Hi Martin,
> 
> Hi Darren,
> 
>> No objection if this is a valid URL. I didn't include this because 1) I
>> didn't know about it and 2) it isn't listed in the git pull man page,
>> which is what I developed to. Is git+ssh... equivalent to ssh:// ?
> 
> before this change my pull requests had url like this
> are available in the git repository at:
>   git+ssh://git@git.openembedded.org/meta-openembedded-contrib jansa/meta-oe
>   http://cgit.openembedded.org/cgit.cgi/git+ssh://git@git.openembedded.org/meta-openembedded-contrib/log/?h=jansa/meta-oe
> 
> because RE wasn't matching my URL at all
> 
> OE @ ~/shr-core/openembedded-core $ git config remote.contrib.url
> git+ssh://git@git.openembedded.org/openembedded-core-contrib
> 
> IMHO this is equivalent to ssh:// or git@ without protocol but haven't 
> checked documentation to be sure. But I'm sure this is valid and that 
> this works right (as I'm able to push to contrib).
> 

I'm sure the patch is fine - I was just surprised git pull didn't
document the URL. It's already been pulled as well I believe.

>> As a minor nit, please include a body message for anything more
>> complicated than whitespace or typographical fixes.
> 
> I use git+ssh:// for many projects so I'm used to it, so I expected that
> this is widely used and this patch would be clear enough.

As I said, it's a nit, but it is consistent with guidelines used in many
other projects. Cramming too much into the subject line makes the git
log hard to read - especially as git doesn't wrap long lines - perhaps
due to the prejudices of the authors ;-) Yours doesn't truncate,
but it comes close. Anyway, dead horse and all that.

Thanks for the fix.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel