* [PATCH] qt4e-demo-image: improve image
@ 2011-09-07 13:17 Eric Bénard
2011-09-07 13:23 ` Paul Eggleton
0 siblings, 1 reply; 3+ messages in thread
From: Eric Bénard @ 2011-09-07 13:17 UTC (permalink / raw)
To: openembedded-core
use ${POKY_BASE_INSTALL} in order to have the base files and
ools in the image.
Signed-off-by: Eric Bénard <eric@eukrea.com>
---
meta/recipes-qt/images/qt4e-demo-image.bb | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/meta/recipes-qt/images/qt4e-demo-image.bb b/meta/recipes-qt/images/qt4e-demo-image.bb
index 6a7c086..6523379 100644
--- a/meta/recipes-qt/images/qt4e-demo-image.bb
+++ b/meta/recipes-qt/images/qt4e-demo-image.bb
@@ -11,7 +11,7 @@ RDEPENDS_${PN} += " \
"
IMAGE_INSTALL += "\
- busybox \
+ ${POKY_BASE_INSTALL} \
module-init-tools \
task-qt4e-base \
"
--
1.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] qt4e-demo-image: improve image
2011-09-07 13:17 [PATCH] qt4e-demo-image: improve image Eric Bénard
@ 2011-09-07 13:23 ` Paul Eggleton
2011-09-07 13:30 ` Eric Bénard
0 siblings, 1 reply; 3+ messages in thread
From: Paul Eggleton @ 2011-09-07 13:23 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer, Eric Bénard
On Wednesday 07 September 2011 14:17:10 Eric Bénard wrote:
> use ${POKY_BASE_INSTALL} in order to have the base files and
> ools in the image.
>
>..
>
> IMAGE_INSTALL += "\
> - busybox \
> + ${POKY_BASE_INSTALL} \
> module-init-tools \
> task-qt4e-base \
> "
Hmm, I missed this when the original patches came in; surely it would be
better to just append to IMAGE_INSTALL after the "inherit core-image" line,
then we start with the default value from core-image.bbclass?
(Of course with either fix we'll run into the build annoyance pointed out in
the other message I just sent, where a whole bunch of X apps we won't need
will get built.)
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] qt4e-demo-image: improve image
2011-09-07 13:23 ` Paul Eggleton
@ 2011-09-07 13:30 ` Eric Bénard
0 siblings, 0 replies; 3+ messages in thread
From: Eric Bénard @ 2011-09-07 13:30 UTC (permalink / raw)
To: Paul Eggleton; +Cc: Patches and discussions about the oe-core layer
Le 07/09/2011 15:23, Paul Eggleton a écrit :
> On Wednesday 07 September 2011 14:17:10 Eric Bénard wrote:
>> use ${POKY_BASE_INSTALL} in order to have the base files and
>> ools in the image.
>>
>> ..
>>
>> IMAGE_INSTALL += "\
>> - busybox \
>> + ${POKY_BASE_INSTALL} \
>> module-init-tools \
>> task-qt4e-base \
>> "
>
> Hmm, I missed this when the original patches came in; surely it would be
> better to just append to IMAGE_INSTALL after the "inherit core-image" line,
> then we start with the default value from core-image.bbclass?
>
ok I was not sure this would work this way, I'll test and send a v2.
Thanks,
Eric
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-07 13:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-09-07 13:17 [PATCH] qt4e-demo-image: improve image Eric Bénard
2011-09-07 13:23 ` Paul Eggleton
2011-09-07 13:30 ` Eric Bénard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox