* [PATCH 0/1] xcursor-transparent-theme: install index.theme explicitly
@ 2013-04-10 3:26 wenzong.fan
2013-04-10 3:26 ` [PATCH 1/1] " wenzong.fan
0 siblings, 1 reply; 5+ messages in thread
From: wenzong.fan @ 2013-04-10 3:26 UTC (permalink / raw)
To: openembedded-core
From: Wenzong Fan <wenzong.fan@windriver.com>
xcursor-transparent-theme: install index.theme explicitly
The xcursor-transparent-theme doesn't install index.theme by default,
this might cause below command fails on target:
$ gtk-update-icon-cache -q /usr/share/icons/xcursor-transparent
Error: "gtk-update-icon-cache: No theme index file"
Just install index.theme explicitly to remove those error, its content
is from xcursor-transparent-theme's README file.
[YOCTO #4234]
The following changes since commit 307e860860badd4420a01ed781c6c845fc9bf603:
udev: fix init script for the location of udevd (2013-04-09 18:09:14 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib wenzong/4234
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=wenzong/4234
Wenzong Fan (1):
xcursor-transparent-theme: install index.theme explicitly
.../xcursor-transparent-theme-0.1.1/index.theme | 2 ++
.../xcursor-transparent-theme_0.1.1.bb | 17 ++++++++++++++---
2 files changed, 16 insertions(+), 3 deletions(-)
create mode 100644 meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme-0.1.1/index.theme
--
1.7.10.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] xcursor-transparent-theme: install index.theme explicitly
2013-04-10 3:26 [PATCH 0/1] xcursor-transparent-theme: install index.theme explicitly wenzong.fan
@ 2013-04-10 3:26 ` wenzong.fan
2013-04-10 8:00 ` Martin Jansa
0 siblings, 1 reply; 5+ messages in thread
From: wenzong.fan @ 2013-04-10 3:26 UTC (permalink / raw)
To: openembedded-core
The xcursor-transparent-theme doesn't install index.theme by default,
this might cause below command fails on target:
$ gtk-update-icon-cache -q /usr/share/icons/xcursor-transparent
Error: "gtk-update-icon-cache: No theme index file"
Just install index.theme explicitly to remove those error, its content
is from xcursor-transparent-theme's README file.
[YOCTO #4234]
Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
---
.../xcursor-transparent-theme-0.1.1/index.theme | 2 ++
.../xcursor-transparent-theme_0.1.1.bb | 17 ++++++++++++++---
2 files changed, 16 insertions(+), 3 deletions(-)
create mode 100644 meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme-0.1.1/index.theme
diff --git a/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme-0.1.1/index.theme b/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme-0.1.1/index.theme
new file mode 100644
index 0000000..5300850
--- /dev/null
+++ b/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme-0.1.1/index.theme
@@ -0,0 +1,2 @@
+[Icon Theme]
+Inherits=xcursor-transparent
diff --git a/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb b/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
index fecc8ea..93770c1 100644
--- a/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
+++ b/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
@@ -6,14 +6,25 @@ LICENSE = "GPLv2"
LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
SECTION = "x11/base"
-PR = "r4"
+PR = "r5"
SRC_URI = "http://downloads.yoctoproject.org/releases/matchbox/utils/xcursor-transparent-theme-${PV}.tar.gz \
file://use-relative-symlinks.patch \
- file://fix_watch_cursor.patch"
+ file://fix_watch_cursor.patch \
+ file://index.theme"
SRC_URI[md5sum] = "7b0c623049d4aab20600d6473f8aab23"
SRC_URI[sha256sum] = "b26adf2d503d01299718390ae39dab4691a67220de09423be0364e9a060bf7e4"
-FILES_${PN} = "${datadir}/icons/xcursor-transparent/cursors/*"
+FILES_${PN} = "${datadir}/icons/xcursor-transparent/cursors/* \
+ ${datadir}/icons/xcursor-transparent/index.theme"
inherit autotools allarch
+
+# This package doesn't provide index.theme by default, this might cause
+# below command fails on target with error: "No theme index file".
+#
+# gtk-update-icon-cache -q /usr/share/icons/xcursor-transparent
+#
+do_install_append(){
+ install -m 0644 -D ${WORKDIR}/index.theme ${D}${datadir}/icons/xcursor-transparent/index.theme
+}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] xcursor-transparent-theme: install index.theme explicitly
2013-04-10 3:26 ` [PATCH 1/1] " wenzong.fan
@ 2013-04-10 8:00 ` Martin Jansa
2013-04-10 9:17 ` Burton, Ross
0 siblings, 1 reply; 5+ messages in thread
From: Martin Jansa @ 2013-04-10 8:00 UTC (permalink / raw)
To: wenzong.fan; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 3374 bytes --]
On Wed, Apr 10, 2013 at 11:26:35AM +0800, wenzong.fan@windriver.com wrote:
> The xcursor-transparent-theme doesn't install index.theme by default,
> this might cause below command fails on target:
>
> $ gtk-update-icon-cache -q /usr/share/icons/xcursor-transparent
> Error: "gtk-update-icon-cache: No theme index file"
>
> Just install index.theme explicitly to remove those error, its content
> is from xcursor-transparent-theme's README file.
Wasn't this discussed and fixed before? IIRC the conclusion was that
postinst should check if there is index.theme or ignore it missing, not
adding index.theme.
>
> [YOCTO #4234]
>
> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> ---
> .../xcursor-transparent-theme-0.1.1/index.theme | 2 ++
> .../xcursor-transparent-theme_0.1.1.bb | 17 ++++++++++++++---
> 2 files changed, 16 insertions(+), 3 deletions(-)
> create mode 100644 meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme-0.1.1/index.theme
>
> diff --git a/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme-0.1.1/index.theme b/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme-0.1.1/index.theme
> new file mode 100644
> index 0000000..5300850
> --- /dev/null
> +++ b/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme-0.1.1/index.theme
> @@ -0,0 +1,2 @@
> +[Icon Theme]
> +Inherits=xcursor-transparent
> diff --git a/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb b/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
> index fecc8ea..93770c1 100644
> --- a/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
> +++ b/meta/recipes-graphics/xcursor-transparent-theme/xcursor-transparent-theme_0.1.1.bb
> @@ -6,14 +6,25 @@ LICENSE = "GPLv2"
> LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
>
> SECTION = "x11/base"
> -PR = "r4"
> +PR = "r5"
>
> SRC_URI = "http://downloads.yoctoproject.org/releases/matchbox/utils/xcursor-transparent-theme-${PV}.tar.gz \
> file://use-relative-symlinks.patch \
> - file://fix_watch_cursor.patch"
> + file://fix_watch_cursor.patch \
> + file://index.theme"
>
> SRC_URI[md5sum] = "7b0c623049d4aab20600d6473f8aab23"
> SRC_URI[sha256sum] = "b26adf2d503d01299718390ae39dab4691a67220de09423be0364e9a060bf7e4"
> -FILES_${PN} = "${datadir}/icons/xcursor-transparent/cursors/*"
> +FILES_${PN} = "${datadir}/icons/xcursor-transparent/cursors/* \
> + ${datadir}/icons/xcursor-transparent/index.theme"
>
> inherit autotools allarch
> +
> +# This package doesn't provide index.theme by default, this might cause
> +# below command fails on target with error: "No theme index file".
> +#
> +# gtk-update-icon-cache -q /usr/share/icons/xcursor-transparent
> +#
> +do_install_append(){
> + install -m 0644 -D ${WORKDIR}/index.theme ${D}${datadir}/icons/xcursor-transparent/index.theme
> +}
> --
> 1.7.10.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] xcursor-transparent-theme: install index.theme explicitly
2013-04-10 8:00 ` Martin Jansa
@ 2013-04-10 9:17 ` Burton, Ross
2013-04-11 6:38 ` wenzong fan
0 siblings, 1 reply; 5+ messages in thread
From: Burton, Ross @ 2013-04-10 9:17 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-core
On 10 April 2013 09:00, Martin Jansa <martin.jansa@gmail.com> wrote:
> On Wed, Apr 10, 2013 at 11:26:35AM +0800, wenzong.fan@windriver.com wrote:
>> The xcursor-transparent-theme doesn't install index.theme by default,
>> this might cause below command fails on target:
>>
>> $ gtk-update-icon-cache -q /usr/share/icons/xcursor-transparent
>> Error: "gtk-update-icon-cache: No theme index file"
>>
>> Just install index.theme explicitly to remove those error, its content
>> is from xcursor-transparent-theme's README file.
>
> Wasn't this discussed and fixed before? IIRC the conclusion was that
> postinst should check if there is index.theme or ignore it missing, not
> adding index.theme.
NACK.
Martin is right, the gtk-icon-cache class uses -t when updating the caches:
--ignore-theme-index, -t
Don't check for the existence of 'index.theme' in the icon theme
directory. Without this option, gtk-update-icon-cache refuses to
create an icon cache in a directory which does not appear to be the
toplevel directory of an icon theme.
If someone is not using gtk-icon-cache.bbclass they either should, or
have a good reason and also use -t.
Ross
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] xcursor-transparent-theme: install index.theme explicitly
2013-04-10 9:17 ` Burton, Ross
@ 2013-04-11 6:38 ` wenzong fan
0 siblings, 0 replies; 5+ messages in thread
From: wenzong fan @ 2013-04-11 6:38 UTC (permalink / raw)
To: Burton, Ross, Martin Jansa; +Cc: openembedded-core
On 04/10/2013 05:17 PM, Burton, Ross wrote:
> On 10 April 2013 09:00, Martin Jansa <martin.jansa@gmail.com> wrote:
>> On Wed, Apr 10, 2013 at 11:26:35AM +0800, wenzong.fan@windriver.com wrote:
>>> The xcursor-transparent-theme doesn't install index.theme by default,
>>> this might cause below command fails on target:
>>>
>>> $ gtk-update-icon-cache -q /usr/share/icons/xcursor-transparent
>>> Error: "gtk-update-icon-cache: No theme index file"
>>>
>>> Just install index.theme explicitly to remove those error, its content
>>> is from xcursor-transparent-theme's README file.
>>
>> Wasn't this discussed and fixed before? IIRC the conclusion was that
>> postinst should check if there is index.theme or ignore it missing, not
>> adding index.theme.
>
> NACK.
>
> Martin is right, the gtk-icon-cache class uses -t when updating the caches:
>
> --ignore-theme-index, -t
> Don't check for the existence of 'index.theme' in the icon theme
> directory. Without this option, gtk-update-icon-cache refuses to
> create an icon cache in a directory which does not appear to be the
> toplevel directory of an icon theme.
>
> If someone is not using gtk-icon-cache.bbclass they either should, or
> have a good reason and also use -t.
Oh, I did think I missed something about the discussion of index.theme &
gtk-update-icon-cache. I recall this patch and sorry for the noise.
I appreciate your clarifications!
Thanks
Wenzong
>
> Ross
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-04-11 6:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-10 3:26 [PATCH 0/1] xcursor-transparent-theme: install index.theme explicitly wenzong.fan
2013-04-10 3:26 ` [PATCH 1/1] " wenzong.fan
2013-04-10 8:00 ` Martin Jansa
2013-04-10 9:17 ` Burton, Ross
2013-04-11 6:38 ` wenzong fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox