* [PATCH V1] util-linux: replace += with _append to EXTRA_OECONF_virtclass-native
@ 2013-07-17 8:19 Ming Liu
2013-07-17 8:31 ` Paul Eggleton
2013-07-17 8:34 ` Martin Jansa
0 siblings, 2 replies; 5+ messages in thread
From: Ming Liu @ 2013-07-17 8:19 UTC (permalink / raw)
To: openembedded-core
The native/nativesdk overrides of EXTRA_OECONF should take effect before
append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
of be appended at native/nativesdk build time.
Signed-off-by: Ming Liu <ming.liu@windriver.com>
---
meta/recipes-core/util-linux/util-linux_2.23.1.bb | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
index 12f5021..ae80450 100644
--- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
+++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
@@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
SRC_URI[sha256sum] = "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
-EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
-EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
+EXTRA_OECONF_append_class-native += "--disable-fallocate --disable-use-tty-group"
+EXTRA_OECONF_append_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
--
1.7.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH V1] util-linux: replace += with _append to EXTRA_OECONF_virtclass-native
2013-07-17 8:19 [PATCH V1] util-linux: replace += with _append to EXTRA_OECONF_virtclass-native Ming Liu
@ 2013-07-17 8:31 ` Paul Eggleton
2013-07-17 8:36 ` Ming Liu
2013-07-17 8:34 ` Martin Jansa
1 sibling, 1 reply; 5+ messages in thread
From: Paul Eggleton @ 2013-07-17 8:31 UTC (permalink / raw)
To: Ming Liu; +Cc: openembedded-core
Hi Ming,
On Wednesday 17 July 2013 16:19:39 Ming Liu wrote:
> The native/nativesdk overrides of EXTRA_OECONF should take effect before
> append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
> of be appended at native/nativesdk build time.
>
> Signed-off-by: Ming Liu <ming.liu@windriver.com>
> ---
> meta/recipes-core/util-linux/util-linux_2.23.1.bb | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
> b/meta/recipes-core/util-linux/util-linux_2.23.1.bb index 12f5021..ae80450
> 100644
> --- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
> +++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
> @@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
> SRC_URI[sha256sum] =
> "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
>
> CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
> -EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
> -EXTRA_OECONF_class-nativesdk += "--disable-fallocate
> --disable-use-tty-group" +EXTRA_OECONF_append_class-native +=
> "--disable-fallocate --disable-use-tty-group"
> +EXTRA_OECONF_append_class-nativesdk += "--disable-fallocate
> --disable-use-tty-group"
Could you please avoid the += in conjunction with _append? It's confusing.
(You'll need to add a leading space to the value to compensate of course.)
Thanks,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V1] util-linux: replace += with _append to EXTRA_OECONF_virtclass-native
2013-07-17 8:31 ` Paul Eggleton
@ 2013-07-17 8:36 ` Ming Liu
0 siblings, 0 replies; 5+ messages in thread
From: Ming Liu @ 2013-07-17 8:36 UTC (permalink / raw)
To: Paul Eggleton; +Cc: openembedded-core
On 07/17/2013 04:31 PM, Paul Eggleton wrote:
> Hi Ming,
>
> On Wednesday 17 July 2013 16:19:39 Ming Liu wrote:
>> The native/nativesdk overrides of EXTRA_OECONF should take effect before
>> append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
>> of be appended at native/nativesdk build time.
>>
>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>> ---
>> meta/recipes-core/util-linux/util-linux_2.23.1.bb | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> b/meta/recipes-core/util-linux/util-linux_2.23.1.bb index 12f5021..ae80450
>> 100644
>> --- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> +++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> @@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
>> SRC_URI[sha256sum] =
>> "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
>>
>> CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
>> -EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
>> -EXTRA_OECONF_class-nativesdk += "--disable-fallocate
>> --disable-use-tty-group" +EXTRA_OECONF_append_class-native +=
>> "--disable-fallocate --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-nativesdk += "--disable-fallocate
>> --disable-use-tty-group"
> Could you please avoid the += in conjunction with _append? It's confusing.
> (You'll need to add a leading space to the value to compensate of course.)
Yes, sorry, my misktake. I will send V2.
the best,
thank you
> Thanks,
> Paul
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V1] util-linux: replace += with _append to EXTRA_OECONF_virtclass-native
2013-07-17 8:19 [PATCH V1] util-linux: replace += with _append to EXTRA_OECONF_virtclass-native Ming Liu
2013-07-17 8:31 ` Paul Eggleton
@ 2013-07-17 8:34 ` Martin Jansa
2013-07-17 8:36 ` Ming Liu
1 sibling, 1 reply; 5+ messages in thread
From: Martin Jansa @ 2013-07-17 8:34 UTC (permalink / raw)
To: Ming Liu; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]
On Wed, Jul 17, 2013 at 04:19:39PM +0800, Ming Liu wrote:
> The native/nativesdk overrides of EXTRA_OECONF should take effect before
> append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
> of be appended at native/nativesdk build time.
>
> Signed-off-by: Ming Liu <ming.liu@windriver.com>
> ---
> meta/recipes-core/util-linux/util-linux_2.23.1.bb | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
> index 12f5021..ae80450 100644
> --- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
> +++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
> @@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
> SRC_URI[sha256sum] = "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
>
> CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
> -EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
> -EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
> +EXTRA_OECONF_append_class-native += "--disable-fallocate --disable-use-tty-group"
> +EXTRA_OECONF_append_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
You should change += to =, because append + += is confusing.
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V1] util-linux: replace += with _append to EXTRA_OECONF_virtclass-native
2013-07-17 8:34 ` Martin Jansa
@ 2013-07-17 8:36 ` Ming Liu
0 siblings, 0 replies; 5+ messages in thread
From: Ming Liu @ 2013-07-17 8:36 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-core
On 07/17/2013 04:34 PM, Martin Jansa wrote:
> On Wed, Jul 17, 2013 at 04:19:39PM +0800, Ming Liu wrote:
>> The native/nativesdk overrides of EXTRA_OECONF should take effect before
>> append operator, otherwise, it will cause EXTRA_OECONF be overridden instead
>> of be appended at native/nativesdk build time.
>>
>> Signed-off-by: Ming Liu <ming.liu@windriver.com>
>> ---
>> meta/recipes-core/util-linux/util-linux_2.23.1.bb | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-core/util-linux/util-linux_2.23.1.bb b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> index 12f5021..ae80450 100644
>> --- a/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> +++ b/meta/recipes-core/util-linux/util-linux_2.23.1.bb
>> @@ -18,5 +18,5 @@ SRC_URI[md5sum] = "6741eeaff93ff5a6bacdd3816bdd87c4"
>> SRC_URI[sha256sum] = "ad4a7831d7b27d0172996fd343e809716c2403b32a94e15194d8ea797223c4af"
>>
>> CACHED_CONFIGUREVARS += "scanf_cv_alloc_modifier=as"
>> -EXTRA_OECONF_class-native += "--disable-fallocate --disable-use-tty-group"
>> -EXTRA_OECONF_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-native += "--disable-fallocate --disable-use-tty-group"
>> +EXTRA_OECONF_append_class-nativesdk += "--disable-fallocate --disable-use-tty-group"
> You should change += to =, because append + += is confusing.
Yes, thanks for pointing this, it's my mistake.
the best,
thank you
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-07-17 8:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-07-17 8:19 [PATCH V1] util-linux: replace += with _append to EXTRA_OECONF_virtclass-native Ming Liu
2013-07-17 8:31 ` Paul Eggleton
2013-07-17 8:36 ` Ming Liu
2013-07-17 8:34 ` Martin Jansa
2013-07-17 8:36 ` Ming Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox