* Re: [oe-commits] Muhammad Shakeel : systemd: Remove init. d dir if systemd unit file is present and sysvinit not a distro feature
[not found] <20130731055134.2BD98504B3@opal>
@ 2013-08-03 23:23 ` Martin Jansa
2013-08-04 5:30 ` Saul Wold
0 siblings, 1 reply; 3+ messages in thread
From: Martin Jansa @ 2013-08-03 23:23 UTC (permalink / raw)
To: openembedded-core, Muhammad Shakeel; +Cc: openembedded-commits
[-- Attachment #1: Type: text/plain, Size: 1769 bytes --]
On Wed, Jul 31, 2013 at 05:51:34AM +0000, git@git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: 823c90ad344ca2205f3055e2dcae08c6616f29b7
> URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=823c90ad344ca2205f3055e2dcae08c6616f29b7
>
> Author: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> Date: Mon Jul 29 13:09:51 2013 +0500
>
> systemd: Remove init.d dir if systemd unit file is present and sysvinit not a distro feature
>
> If systemd is supported DISTRO_FEATURE and sysvinit is not and also if
> systemd_unitdir contains anything then no need to keep init.d scripts
> for sysvinit compatibility.
>
> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
There is small issue with this patch applied:
do_rootfs failing:
| Collected errors:
| * satisfy_dependencies_for: Cannot satisfy the following dependencies
for packagegroup-core-boot:
| * busybox-hwclock *
| * opkg_install_cmd: Cannot install package packagegroup-core-boot.
Systemd images with packagegroup-core-boot RDEPEND on busybox-hwclock:
meta/recipes-core/packagegroups/packagegroup-core-boot.bb:
${@base_contains("MACHINE_FEATURES", "rtc", "busybox-hwclock", "", d)} \
Which is created only when there is /etc/init.d/hwclock.sh file:
FILES_${PN}-hwclock = "${sysconfdir}/init.d/hwclock.sh"
There are at least 3 options
1) ALLOW_EMPTY_${PN}-hwclock = "1"
in busybox.inc
2) add hwclock.service to the same package
3) change packagegroup-core-boot to depend on busybox-hwclock only with
sysvinit enabled
I think the best way to resolve this is 2), any volunteer?
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [oe-commits] Muhammad Shakeel : systemd: Remove init. d dir if systemd unit file is present and sysvinit not a distro feature
2013-08-03 23:23 ` [oe-commits] Muhammad Shakeel : systemd: Remove init. d dir if systemd unit file is present and sysvinit not a distro feature Martin Jansa
@ 2013-08-04 5:30 ` Saul Wold
2013-08-04 7:12 ` Martin Jansa
0 siblings, 1 reply; 3+ messages in thread
From: Saul Wold @ 2013-08-04 5:30 UTC (permalink / raw)
To: Martin Jansa; +Cc: openembedded-core
On 08/03/2013 04:23 PM, Martin Jansa wrote:
> On Wed, Jul 31, 2013 at 05:51:34AM +0000, git@git.openembedded.org wrote:
>> Module: openembedded-core.git
>> Branch: master
>> Commit: 823c90ad344ca2205f3055e2dcae08c6616f29b7
>> URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=823c90ad344ca2205f3055e2dcae08c6616f29b7
>>
>> Author: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>> Date: Mon Jul 29 13:09:51 2013 +0500
>>
>> systemd: Remove init.d dir if systemd unit file is present and sysvinit not a distro feature
>>
>> If systemd is supported DISTRO_FEATURE and sysvinit is not and also if
>> systemd_unitdir contains anything then no need to keep init.d scripts
>> for sysvinit compatibility.
>>
>> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
>> Signed-off-by: Saul Wold <sgw@linux.intel.com>
>
> There is small issue with this patch applied:
>
> do_rootfs failing:
> | Collected errors:
> | * satisfy_dependencies_for: Cannot satisfy the following dependencies
> for packagegroup-core-boot:
> | * busybox-hwclock *
> | * opkg_install_cmd: Cannot install package packagegroup-core-boot.
>
> Systemd images with packagegroup-core-boot RDEPEND on busybox-hwclock:
> meta/recipes-core/packagegroups/packagegroup-core-boot.bb:
> ${@base_contains("MACHINE_FEATURES", "rtc", "busybox-hwclock", "", d)} \
>
> Which is created only when there is /etc/init.d/hwclock.sh file:
> FILES_${PN}-hwclock = "${sysconfdir}/init.d/hwclock.sh"
>
> There are at least 3 options
> 1) ALLOW_EMPTY_${PN}-hwclock = "1"
> in busybox.inc
> 2) add hwclock.service to the same package
> 3) change packagegroup-core-boot to depend on busybox-hwclock only with
> sysvinit enabled
>
> I think the best way to resolve this is 2), any volunteer?
>
I think my patch from Friday, which I needed to correct the commit
message should address this in packagegroup-boot-core, which is #3 on
your list.
This was discussed in Bug # 4969
(https://bugzilla.yoctoproject.org/show_bug.cgi?id=4969) and systemd
uses timedatectl.
If you have more details or other thoughts, please comment here or on
that bug.
Thanks
Sau!
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [oe-commits] Muhammad Shakeel : systemd: Remove init. d dir if systemd unit file is present and sysvinit not a distro feature
2013-08-04 5:30 ` Saul Wold
@ 2013-08-04 7:12 ` Martin Jansa
0 siblings, 0 replies; 3+ messages in thread
From: Martin Jansa @ 2013-08-04 7:12 UTC (permalink / raw)
To: Saul Wold; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2455 bytes --]
On Sat, Aug 03, 2013 at 10:30:48PM -0700, Saul Wold wrote:
> On 08/03/2013 04:23 PM, Martin Jansa wrote:
> > On Wed, Jul 31, 2013 at 05:51:34AM +0000, git@git.openembedded.org wrote:
> >> Module: openembedded-core.git
> >> Branch: master
> >> Commit: 823c90ad344ca2205f3055e2dcae08c6616f29b7
> >> URL: http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=823c90ad344ca2205f3055e2dcae08c6616f29b7
> >>
> >> Author: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> >> Date: Mon Jul 29 13:09:51 2013 +0500
> >>
> >> systemd: Remove init.d dir if systemd unit file is present and sysvinit not a distro feature
> >>
> >> If systemd is supported DISTRO_FEATURE and sysvinit is not and also if
> >> systemd_unitdir contains anything then no need to keep init.d scripts
> >> for sysvinit compatibility.
> >>
> >> Signed-off-by: Muhammad Shakeel <muhammad_shakeel@mentor.com>
> >> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> >
> > There is small issue with this patch applied:
> >
> > do_rootfs failing:
> > | Collected errors:
> > | * satisfy_dependencies_for: Cannot satisfy the following dependencies
> > for packagegroup-core-boot:
> > | * busybox-hwclock *
> > | * opkg_install_cmd: Cannot install package packagegroup-core-boot.
> >
> > Systemd images with packagegroup-core-boot RDEPEND on busybox-hwclock:
> > meta/recipes-core/packagegroups/packagegroup-core-boot.bb:
> > ${@base_contains("MACHINE_FEATURES", "rtc", "busybox-hwclock", "", d)} \
> >
> > Which is created only when there is /etc/init.d/hwclock.sh file:
> > FILES_${PN}-hwclock = "${sysconfdir}/init.d/hwclock.sh"
> >
> > There are at least 3 options
> > 1) ALLOW_EMPTY_${PN}-hwclock = "1"
> > in busybox.inc
> > 2) add hwclock.service to the same package
> > 3) change packagegroup-core-boot to depend on busybox-hwclock only with
> > sysvinit enabled
> >
> > I think the best way to resolve this is 2), any volunteer?
> >
> I think my patch from Friday, which I needed to correct the commit
> message should address this in packagegroup-boot-core, which is #3 on
> your list.
>
> This was discussed in Bug # 4969
> (https://bugzilla.yoctoproject.org/show_bug.cgi?id=4969) and systemd
> uses timedatectl.
>
> If you have more details or other thoughts, please comment here or on
> that bug.
Works fine with that patch applied, thanks!
--
Martin 'JaMa' Jansa jabber: Martin.Jansa@gmail.com
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 205 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-04 7:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20130731055134.2BD98504B3@opal>
2013-08-03 23:23 ` [oe-commits] Muhammad Shakeel : systemd: Remove init. d dir if systemd unit file is present and sysvinit not a distro feature Martin Jansa
2013-08-04 5:30 ` Saul Wold
2013-08-04 7:12 ` Martin Jansa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox