* [for dylan][PATCH] kernel.bbclass: Correct post(inst|rm) package association
@ 2013-09-24 17:58 Franklin S. Cooper Jr
2013-10-04 18:41 ` Denys Dmytriyenko
0 siblings, 1 reply; 5+ messages in thread
From: Franklin S. Cooper Jr @ 2013-09-24 17:58 UTC (permalink / raw)
To: openembedded-core; +Cc: Darren Hart
From: Darren Hart <dvhart@linux.intel.com>
Fixes [YOCTO #4991]
The kernel image is installed as part of the kernel-image package, but
the symlink creation/removal via alternatives is being done in
pkg_post(inst|rm)_kernel-base.
Move the postinst alternatives logic into the kernel-image functions.
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
---
meta/classes/kernel.bbclass | 29 +++++++++++++----------------
1 files changed, 13 insertions(+), 16 deletions(-)
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 3320747..c417038 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -237,14 +237,6 @@ do_savedefconfig() {
do_savedefconfig[nostamp] = "1"
addtask savedefconfig after do_configure
-pkg_postinst_kernel-base () {
- update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
-}
-
-pkg_postrm_kernel-base () {
- update-alternatives --remove ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} || true
-}
-
inherit cml1
EXPORT_FUNCTIONS do_compile do_install do_configure
@@ -272,14 +264,19 @@ ALLOW_EMPTY_kernel-modules = "1"
DESCRIPTION_kernel-modules = "Kernel modules meta package"
pkg_postinst_kernel-image () {
-if [ ! -e "$D/lib/modules/${KERNEL_VERSION}" ]; then
- mkdir -p $D/lib/modules/${KERNEL_VERSION}
-fi
-if [ -n "$D" ]; then
- depmodwrapper -a -b $D ${KERNEL_VERSION}
-else
- depmod -a ${KERNEL_VERSION}
-fi
+ update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
+ if [ ! -e "$D/lib/modules/${KERNEL_VERSION}" ]; then
+ mkdir -p $D/lib/modules/${KERNEL_VERSION}
+ fi
+ if [ -n "$D" ]; then
+ depmodwrapper -a -b $D ${KERNEL_VERSION}
+ else
+ depmod -a ${KERNEL_VERSION}
+ fi
+}
+
+pkg_postrm_kernel-image () {
+ update-alternatives --remove ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} || true
}
PACKAGESPLITFUNCS_prepend = "split_kernel_packages "
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [for dylan][PATCH] kernel.bbclass: Correct post(inst|rm) package association
2013-09-24 17:58 [for dylan][PATCH] kernel.bbclass: Correct post(inst|rm) package association Franklin S. Cooper Jr
@ 2013-10-04 18:41 ` Denys Dmytriyenko
2013-10-04 22:56 ` Paul Eggleton
0 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2013-10-04 18:41 UTC (permalink / raw)
To: Franklin S. Cooper Jr; +Cc: Darren Hart, openembedded-core
Ping. Is Dylan still alive?
On Tue, Sep 24, 2013 at 12:58:20PM -0500, Franklin S. Cooper Jr wrote:
> From: Darren Hart <dvhart@linux.intel.com>
>
> Fixes [YOCTO #4991]
>
> The kernel image is installed as part of the kernel-image package, but
> the symlink creation/removal via alternatives is being done in
> pkg_post(inst|rm)_kernel-base.
>
> Move the postinst alternatives logic into the kernel-image functions.
>
> Signed-off-by: Darren Hart <dvhart@linux.intel.com>
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
> meta/classes/kernel.bbclass | 29 +++++++++++++----------------
> 1 files changed, 13 insertions(+), 16 deletions(-)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 3320747..c417038 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -237,14 +237,6 @@ do_savedefconfig() {
> do_savedefconfig[nostamp] = "1"
> addtask savedefconfig after do_configure
>
> -pkg_postinst_kernel-base () {
> - update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
> -}
> -
> -pkg_postrm_kernel-base () {
> - update-alternatives --remove ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} || true
> -}
> -
> inherit cml1
>
> EXPORT_FUNCTIONS do_compile do_install do_configure
> @@ -272,14 +264,19 @@ ALLOW_EMPTY_kernel-modules = "1"
> DESCRIPTION_kernel-modules = "Kernel modules meta package"
>
> pkg_postinst_kernel-image () {
> -if [ ! -e "$D/lib/modules/${KERNEL_VERSION}" ]; then
> - mkdir -p $D/lib/modules/${KERNEL_VERSION}
> -fi
> -if [ -n "$D" ]; then
> - depmodwrapper -a -b $D ${KERNEL_VERSION}
> -else
> - depmod -a ${KERNEL_VERSION}
> -fi
> + update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
> + if [ ! -e "$D/lib/modules/${KERNEL_VERSION}" ]; then
> + mkdir -p $D/lib/modules/${KERNEL_VERSION}
> + fi
> + if [ -n "$D" ]; then
> + depmodwrapper -a -b $D ${KERNEL_VERSION}
> + else
> + depmod -a ${KERNEL_VERSION}
> + fi
> +}
> +
> +pkg_postrm_kernel-image () {
> + update-alternatives --remove ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} || true
> }
>
> PACKAGESPLITFUNCS_prepend = "split_kernel_packages "
> --
> 1.7.0.4
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [for dylan][PATCH] kernel.bbclass: Correct post(inst|rm) package association
2013-10-04 18:41 ` Denys Dmytriyenko
@ 2013-10-04 22:56 ` Paul Eggleton
2013-10-11 9:33 ` Paul Eggleton
0 siblings, 1 reply; 5+ messages in thread
From: Paul Eggleton @ 2013-10-04 22:56 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: Darren Hart, Franklin S. Cooper Jr, openembedded-core
Hi Denys,
On Friday 04 October 2013 14:41:16 Denys Dmytriyenko wrote:
> Ping. Is Dylan still alive?
It is yes. I pushed a paule/dylan-next poky-contrib branch the other day
including this fix but haven't had a chance to run it through the autobuilder
yet (been busy with 1.5 work). Will try to get it done next week.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [for dylan][PATCH] kernel.bbclass: Correct post(inst|rm) package association
2013-10-04 22:56 ` Paul Eggleton
@ 2013-10-11 9:33 ` Paul Eggleton
2013-10-11 19:42 ` Denys Dmytriyenko
0 siblings, 1 reply; 5+ messages in thread
From: Paul Eggleton @ 2013-10-11 9:33 UTC (permalink / raw)
To: Denys Dmytriyenko, Franklin S. Cooper Jr; +Cc: Darren Hart, openembedded-core
On Friday 04 October 2013 23:56:18 Paul Eggleton wrote:
> On Friday 04 October 2013 14:41:16 Denys Dmytriyenko wrote:
> > Ping. Is Dylan still alive?
>
> It is yes. I pushed a paule/dylan-next poky-contrib branch the other day
> including this fix but haven't had a chance to run it through the
> autobuilder yet (been busy with 1.5 work). Will try to get it done next
> week.
FYI the patch has now been merged to the dylan branch along with a few other
fixes.
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [for dylan][PATCH] kernel.bbclass: Correct post(inst|rm) package association
2013-10-11 9:33 ` Paul Eggleton
@ 2013-10-11 19:42 ` Denys Dmytriyenko
0 siblings, 0 replies; 5+ messages in thread
From: Denys Dmytriyenko @ 2013-10-11 19:42 UTC (permalink / raw)
To: Paul Eggleton; +Cc: Darren Hart, Franklin S. Cooper Jr, openembedded-core
On Fri, Oct 11, 2013 at 10:33:03AM +0100, Paul Eggleton wrote:
> On Friday 04 October 2013 23:56:18 Paul Eggleton wrote:
> > On Friday 04 October 2013 14:41:16 Denys Dmytriyenko wrote:
> > > Ping. Is Dylan still alive?
> >
> > It is yes. I pushed a paule/dylan-next poky-contrib branch the other day
> > including this fix but haven't had a chance to run it through the
> > autobuilder yet (been busy with 1.5 work). Will try to get it done next
> > week.
>
> FYI the patch has now been merged to the dylan branch along with a few other
> fixes.
Thanks, Paul!
--
Denys
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-10-11 19:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-09-24 17:58 [for dylan][PATCH] kernel.bbclass: Correct post(inst|rm) package association Franklin S. Cooper Jr
2013-10-04 18:41 ` Denys Dmytriyenko
2013-10-04 22:56 ` Paul Eggleton
2013-10-11 9:33 ` Paul Eggleton
2013-10-11 19:42 ` Denys Dmytriyenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox